leds: gpio: Annotate struct gpio_leds_priv with __counted_by
PATCH 1/1 leds: gpio: Annotate struct gpio_leds_priv with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct gpio_leds_priv.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/leds/leds-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-gpio.c +1 -1
@@ -142,7 +142,7 @@ static int create_gpio_led(const struct gpio_led *template,struct gpio_leds_priv {int num_leds; -struct gpio_led_data leds[]; + struct gpio_led_data leds[] __counted_by(num_leds); };static struct gpio_leds_priv *gpio_leds_create (struct platform_device *pdev)
Signature · 1 line
2.34.1
Quoted 6 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).
Quoted 8 lines
As found with Coccinelle[1], add
__counted_byfor structgpio_leds_priv.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Pavel Machek <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
Signature · 1 line
Gustavo
Quoted 17 lines
--- drivers/leds/leds-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/leds/leds-gpio.c +1
-1@@ -142,7 +142,7 @@ static int create_gpio_led(const struct gpio_led *template,struct gpio_leds_priv {int num_leds; -struct gpio_led_data leds[]; + struct gpio_led_data leds[] __counted_by(num_leds); };static struct gpio_leds_priv *gpio_leds_create (struct platform_device *pdev)
Re: (subset) [PATCH] leds: gpio: Annotate struct gpio_leds_priv with __counted_by
In reply to Kees CookQuoted 9 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structgpio_leds_priv.[...]
Applied, thanks!
[1/1] leds: gpio: Annotate struct gpio_leds_priv with __counted_by
commit: 00f91ead9c8037d044414ae44a0e75ef3df27e6f
--
Lee Jones [李琼斯]