Skip to contentSkip to conversation

dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes

PATCH Applied Rob Herring 3 participants 3 messages Sep 15, 2023 – Sep 19, 2023

Subsystems (2)
Device tree bindings libata
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes

The PATA child node schema is missing constraints to prevent unknown properties. As none of the users of this common binding extend the child nodes with additional properties, adding "additionalProperties: false" here is sufficient.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/ata/pata-common.yaml +1 -0
index 337ddf1113c4..4e867dd4d402 100644
@@ -38,6 +38,7 @@ patternProperties:
       ID number 0 and the slave drive will have ID number 1. The PATA port
       nodes will be named "ide-port".
     type: object
+    additionalProperties: false
 
     properties:
       reg:
Signature · 1 line
2.40.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Rob Herring

The PATA child node schema is missing constraints to prevent unknown properties. As none of the users of this common binding extend the child nodes with additional properties, adding "additionalProperties: false" here is sufficient.

Signed-off-by Rob Herring <[email protected]>
Acked-by Conor Dooley <[email protected]>

Thanks,
Conor.

Quoted 19 lines
---
 Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/ata/pata-common.yaml +1 -0
index 337ddf1113c4..4e867dd4d402 100644
@@ -38,6 +38,7 @@ patternProperties:
       ID number 0 and the slave drive will have ID number 1. The PATA port
       nodes will be named "ide-port".
     type: object
+    additionalProperties: false
 
     properties:
       reg:
Signature · 1 line
2.40.1
maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

The PATA child node schema is missing constraints to prevent unknown properties. As none of the users of this common binding extend the child nodes with additional properties, adding "additionalProperties: false" here is sufficient.

Signed-off-by Rob Herring <[email protected]>

Applied to for-6.6-fixes. Thanks !

Quoted 16 lines
---
 Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/ata/pata-common.yaml +1 -0
index 337ddf1113c4..4e867dd4d402 100644
@@ -38,6 +38,7 @@ patternProperties:
       ID number 0 and the slave drive will have ID number 1. The PATA port
       nodes will be named "ide-port".
     type: object
+    additionalProperties: false
 
     properties:
       reg:
Signature · 2 lines
Damien Le Moal
Western Digital Research