ACPI: video: Move Xiaomi Mi Pad 2 quirk to its own section
PATCH 1/2 ACPI: video: Move Xiaomi Mi Pad 2 quirk to its own section
The Xiaomi Mi Pad 2 is currently listed under the:
"Models which should use the vendor backlight interface, because of broken ACPI video backlight control." section.
But this is not 100% correct. The Xiaomi Mi Pad 2 is one of a set of x86 tablets which shipped with Android as factory OS. These tablets have a TI LP8557 backlight controller with its PWM input _not_ connected to the PMIC or chipset (LPSS) PWM output.
Instead the backlight can be controlled by configuring the LP8557 for direct control through its brightness I2C register and then using the lp855x driver.
This setup means that neither i915's native or acpi_video backlight control works, so a "vendor" quirk is added for these tablets to disable both the native and acpi_video backlight devices, but these devices do not use vendor control in the typical meaning of vendor specific SMBIOS or ACPI calls being used.
This patch is a preparation patch for adding "vendor" quirks for a couple more such tablet models.
--- drivers/acpi/video_detect.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)
drivers/acpi/video_detect.c +18 -8
@@ -229,14 +229,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "NC210/NC110"), }, }, - { - .callback = video_detect_force_vendor, - /* Xiaomi Mi Pad 2 */ - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Xiaomi Inc"), - DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"), - }, - },/* * Models which should use the vendor backlight interface,
@@ -799,6 +791,24 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 15 3535"), }, }, + +/* +* x86 android tablets which directly control the backlight through +* an external backlight controller, typically TI's LP8557. +* The backlight is directly controlled by the lp855x driver on these. +* This setup means that neither i915's native nor acpi_video backlight +* control works. Add a "vendor" quirk to disable both. Note these +* devices do not use vendor control in the typical meaning of +* vendor specific SMBIOS or ACPI calls being used. +*/ + { + .callback = video_detect_force_vendor, + /* Xiaomi Mi Pad 2 */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Xiaomi Inc"), + DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"), + }, + }, { }, };
Signature · 1 line
2.41.0
PATCH 2/2 ACPI: video: Add "vendor" quirks for 3 Lenovo x86 Android tablets
Like the Xiaomi Mi Pad 2 these 3 Lenovo x86 Android tablet models also use a TI LP8557 backlight controller in direct I2C brightness register control mode.
Add "vendor" quirks for these 3 models to disable the non-working native / acpi_video backlight devices.
--- drivers/acpi/video_detect.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
drivers/acpi/video_detect.c +32 -0
@@ -801,6 +801,38 @@ static const struct dmi_system_id video_detect_dmi_table[] = {* devices do not use vendor control in the typical meaning of * vendor specific SMBIOS or ACPI calls being used. */ + { + .callback = video_detect_force_vendor, + /* Lenovo Yoga Book X90F / X90L */ + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"Intel Corporation" ), +DMI_EXACT_MATCH (DMI_PRODUCT_NAME ,"CHERRYVIEW D1 PLATFORM" ), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"), + }, + }, + { + .callback = video_detect_force_vendor, +/* +* Lenovo Yoga Tablet 2 830F/L or 1050F/L (The 8" and 10" +* Lenovo Yoga Tablet 2 use the same mainboard) +*/ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Intel Corp." ), +DMI_MATCH (DMI_PRODUCT_NAME ,"VALLEYVIEW C0 PLATFORM" ), +DMI_MATCH (DMI_BOARD_NAME ,"BYT-T FFD8" ), +/* Partial match on beginning of BIOS version */ + DMI_MATCH(DMI_BIOS_VERSION, "BLADE_21"), + }, + }, + { + .callback = video_detect_force_vendor, +/* Lenovo Yoga Tab 3 Pro YT3-X90F */ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Intel Corporation" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"CHERRYVIEW D1 PLATFORM" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"), + }, + }, { .callback = video_detect_force_vendor,/* Xiaomi Mi Pad 2 */
Signature · 1 line
2.41.0
Quoted 63 lines · Hans de Goede
The Xiaomi Mi Pad 2 is currently listed under the:
"Models which should use the vendor backlight interface, because of broken ACPI video backlight control." section.But this is not 100% correct. The Xiaomi Mi Pad 2 is one of a set of x86 tablets which shipped with Android as factory OS. These tablets have a TI LP8557 backlight controller with its PWM input _not_ connected to the PMIC or chipset (LPSS) PWM output.
Instead the backlight can be controlled by configuring the LP8557 for direct control through its brightness I2C register and then using the lp855x driver.
This setup means that neither i915's native or
acpi_videobacklight control works, so a "vendor" quirk is added for these tablets to disable both the native andacpi_videobacklight devices, but these devices do not use vendor control in the typical meaning of vendor specific SMBIOS or ACPI calls being used.This patch is a preparation patch for adding "vendor" quirks for a couple more such tablet models.
Signed-off-by Hans de Goede <[email protected]>--- drivers/acpi/video_detect.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)drivers/acpi/video_detect.c +12
-8@@ -229,14 +229,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "NC210/NC110"), }, }, - { - .callback = video_detect_force_vendor, - /* Xiaomi Mi Pad 2 */ - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Xiaomi Inc"), - DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"), - }, - },/* * Models which should use the vendor backlight interface, @@ -799,6 +791,24 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 15 3535"), }, }, + +/* +* x86 android tablets which directly control the backlight through +* an external backlight controller, typically TI's LP8557. +* The backlight is directly controlled by the lp855x driver on these. +* This setup means that neither i915's native nor acpi_video backlight +* control works. Add a "vendor" quirk to disable both. Note these +* devices do not use vendor control in the typical meaning of +* vendor specific SMBIOS or ACPI calls being used. +*/ + { + .callback = video_detect_force_vendor,
drivers/acpi/video_detect.c static const struct dmi_system_id video_detect_dmi_table[] = {
Quoted 10 lines
drivers/acpi/video_detect.c +6
-1+/* Xiaomi Mi Pad 2 */ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Xiaomi Inc" ), + DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"), + }, + }, { }, }; --
Applied as 6.7 material along with the [2/2], thanks!