Skip to contentSkip to conversation

arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3

RFC Superseded Frank Wunderlich 3 participants 7 messages Sep 16, 2023 – Oct 25, 2023

Subsystems (2)
Device tree bindings Arm MediaTek

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Frank Wunderlich

author
#0 lore raw

RFC 1/1 arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3

From: Frank Wunderlich <[email protected]>

Build devicetree binaries for testing overlays and providing users full dtb without using overlays.

Suggested-by Rob Herring <[email protected]>
Signed-off-by Frank Wunderlich <[email protected]>

---
based on discussion here:
https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/

---
 arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/mediatek/Makefile +8 -0
index c99c3372a4b5..18be027bf6b4 100644
@@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
+mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
+mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
+mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
+mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
Signature · 1 line
2.34.1
#1 lore raw

Hi,

just a friendly reminder...is this the right way to go?

regards Frank

Quoted 44 lines

Gesendet: Samstag, 16. September 2023 um 10:32 Uhr
Von: "Frank Wunderlich" <[email protected]>
An: [email protected]
Cc: "Frank Wunderlich" <[email protected]>, "Matthias Brugger" <[email protected]>, "AngeloGioacchino Del Regno" <[email protected]>, "Rob Herring" <[email protected]>, "Krzysztof Kozlowski" <[email protected]>, "Conor Dooley" <[email protected]>, [email protected], [email protected]
Betreff: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3

From: Frank Wunderlich <[email protected]>

Build devicetree binaries for testing overlays and providing users full dtb without using overlays.

Suggested-by Rob Herring <[email protected]>
Signed-off-by Frank Wunderlich <[email protected]>

---
based on discussion here:
https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/

---
 arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/mediatek/Makefile +8 -1
index c99c3372a4b5..18be027bf6b4 100644
@@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
+mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
+mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
+mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
+mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
--

2.34.1

#2 lore raw

Hi Rob/Krzysztof

can you please give an Ack or tell me if something is wrong?

regards Frank

Quoted 57 lines

Gesendet: Samstag, 30. September 2023 um 14:57 Uhr
Von: "Frank Wunderlich" <[email protected]>
An: "Rob Herring" <[email protected]>
Cc: [email protected], "Matthias Brugger" <[email protected]>, "AngeloGioacchino Del Regno" <[email protected]>, "Krzysztof Kozlowski" <[email protected]>, "Conor Dooley" <[email protected]>, [email protected], [email protected], "Frank Wunderlich" <[email protected]>
Betreff: Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3

Hi,

just a friendly reminder...is this the right way to go?

regards Frank

Quoted 44 lines

Gesendet: Samstag, 16. September 2023 um 10:32 Uhr
Von: "Frank Wunderlich" <[email protected]>
An: [email protected]
Cc: "Frank Wunderlich" <[email protected]>, "Matthias Brugger" <[email protected]>, "AngeloGioacchino Del Regno" <[email protected]>, "Rob Herring" <[email protected]>, "Krzysztof Kozlowski" <[email protected]>, "Conor Dooley" <[email protected]>, [email protected], [email protected]
Betreff: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3

From: Frank Wunderlich <[email protected]>

Build devicetree binaries for testing overlays and providing users full dtb without using overlays.

Suggested-by Rob Herring <[email protected]>
Signed-off-by Frank Wunderlich <[email protected]>

---
based on discussion here:
https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/

---
 arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/mediatek/Makefile +8 -1
index c99c3372a4b5..18be027bf6b4 100644
@@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
+mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
+mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
+mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
+mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
--

2.34.1

#3 lore raw
Quoted 3 lines · Frank Wunderlich

Hi Rob/Krzysztof

can you please give an Ack or tell me if something is wrong?

Hm? I do not recall being the maintainer of Mediatek. Why do you need an Ack from me?

Best regards,
Krzysztof

#4 lore raw

Am 23. Oktober 2023 15:25:27 MESZ schrieb Krzysztof Kozlowski <[email protected]>:

Quoted 11 lines · Frank Wunderlich
Quoted 3 lines

Hi Rob/Krzysztof

can you please give an Ack or tell me if something is wrong?

Hm? I do not recall being the maintainer of Mediatek. Why do you need an Ack from me?

Best regards,
Krzysztof

I asked you because rob suggested the fix,but does not confirm i have done it right. I guess you have same role,or am i wrong here (sorry then)?

If no ack is needed, then mtk maintainer can apply it to solve the problem rob reports? So then we can continue with additional dts changes regards Frank

#5 lore raw
Quoted 9 lines · Frank Wunderlich

Am 23. Oktober 2023 15:25:27 MESZ schrieb Krzysztof Kozlowski <[email protected]>:

Quoted 8 lines · Frank Wunderlich
Quoted 3 lines

Hi Rob/Krzysztof

can you please give an Ack or tell me if something is wrong?

Hm? I do not recall being the maintainer of Mediatek. Why do you need an Ack from me?

Quoted 7 lines
Quoted 3 lines

Best regards,
Krzysztof

I asked you because rob suggested the fix,but does not confirm i have done it right. I guess you have same role,or am i wrong here (sorry then)?

If no ack is needed, then mtk maintainer can apply it to solve the problem rob reports? So then we can continue with additional dts changes

There is no requirement from a reporter/suggester to confirm your fix. Just like with every patch, anyone is welcomed to review, so pinging specific non-mandatory reviewer is rather noise in our mailboxes.

Best regards,
Krzysztof

#6 lore raw
In reply to Frank Wunderlich

Hi

thinked a bit again on this Patch as i try to summarize sent patches in 1 series to make it easier for maintainer to pick up.

Quoted 21 lines
Quoted 21 lines

Gesendet: Samstag, 16. September 2023 um 10:32 Uhr
Von: "Frank Wunderlich" <[email protected]>
An: [email protected]
Cc: "Frank Wunderlich" <[email protected]>, "Matthias Brugger" <[email protected]>, "AngeloGioacchino Del Regno" <[email protected]>, "Rob Herring" <[email protected]>, "Krzysztof Kozlowski" <[email protected]>, "Conor Dooley" <[email protected]>, [email protected], [email protected]
Betreff: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3

From: Frank Wunderlich <[email protected]>

Build devicetree binaries for testing overlays and providing users full dtb without using overlays.

Suggested-by Rob Herring <[email protected]>
Signed-off-by Frank Wunderlich <[email protected]>

---
based on discussion here:
https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/

---
 arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
Quoted 15 lines
Quoted 5 lines
arch/arm64/boot/dts/mediatek/Makefile +0 -0
index c99c3372a4b5..18be027bf6b4 100644

arch/arm64/boot/dts/mediatek/Makefile dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo · line 22

Quoted 10 lines
arch/arm64/boot/dts/mediatek/Makefile +7 -0
@@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
+mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
+mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
+mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
+mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo

maybe this is nicer?

mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb \
					  mt7986a-bananapi-bpi-r3-emmc.dtbo \
					  mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb \
					 mt7986a-bananapi-bpi-r3-emmc.dtbo \
					 mt7986a-bananapi-bpi-r3-nor.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb \
					mt7986a-bananapi-bpi-r3-sd.dtbo \
					mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb \
				       mt7986a-bananapi-bpi-r3-sd.dtbo \
				       mt7986a-bananapi-bpi-r3-nor.dtbo

dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb

here i tried to align the text on first name, but this results in visible stairs. maybe only 1 tab to indent here (or anything else)? what do you think? In the end better readable as 1 long line.

the SATA-Patch [1] will then add a line to each of the 4 blocks here (+5 lines in total except changes by adding the backslash).

Quoted 7 lines
Quoted 7 lines
arch/arm64/boot/dts/mediatek/Makefile +1 -1
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
--

2.34.1

regards Frank

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/