vlynq: remove bus support
cover vlynq: remove bus support
From: Wolfram Sang <[email protected]>
I'd like to clean up the 'drivers' directory and Kconfig menu, at least a little. One major thing I noticed is that VLYNQ can actually be removed. From patch 2:
---
There are no users with a vlynq_driver in the Kernel tree. So, remove the bus driver which hardly has seen any activity since 2009. It was even marked EXPERIMENTAL as long as that symbol existed. OpenWRT had some out-of-tree drivers which they probably intended to upport, but AR7 devices are not supported anymore because they are "stuck with Kernel 3.18" [1]. So, this code can go nowadays.
[1] https://openwrt.org/docs/techref/targets/ar7
---
Patch 1 removes MIPS specific bus initialization code which is the only user of the VLYNQ bus currently.
Sending out as RFC to gather comments. Patches are based on 6.6-rc1 and created with "--irreversible-delete" to save some space. They are compile tested only, buildbots were happy.
I think this mainly goes to Florian Fainelli. Florian, what do you think?
All the best!
Wolfram
Wolfram Sang (2):
MIPS: AR7: remove VLYNQ init
vlynq: remove bus driver
MAINTAINERS | 7 - arch/mips/Kconfig | 1 - arch/mips/ar7/platform.c | 193 +------ arch/mips/include/asm/mach-ar7/ar7.h | 1 - drivers/Kconfig | 2 - drivers/Makefile | 1 - drivers/vlynq/Kconfig | 21 - drivers/vlynq/Makefile | 6 - drivers/vlynq/vlynq.c | 799 --------------------------- include/linux/vlynq.h | 149 ----- 10 files changed, 1 insertion(+), 1179 deletions(-) delete mode 100644 drivers/vlynq/Kconfig delete mode 100644 drivers/vlynq/Makefile delete mode 100644 drivers/vlynq/vlynq.c delete mode 100644 include/linux/vlynq.h
Signature · 1 line
2.35.1
RFC PATCH 1/2 MIPS: AR7: remove VLYNQ init
From: Wolfram Sang <[email protected]>
VLYNQ bus support is going to be removed from the Kernel because there has never been a vlynq_driver in the tree since 2009. So, it doesn't make sense to setup a bus controller when it is not going to be accessed. Remove the VLYNQ init code to remove the bus driver later.
--- arch/mips/Kconfig | 1 - arch/mips/ar7/platform.c | 193 +-------------------------- arch/mips/include/asm/mach-ar7/ar7.h | 1 - 3 files changed, 1 insertion(+), 194 deletions(-)
arch/mips/Kconfig +0 -1
@@ -219,7 +219,6 @@ config AR7 select SYS_SUPPORTS_MIPS16 select SYS_SUPPORTS_ZBOOT_UART16550 select GPIOLIB - select VLYNQ help Support for the Texas Instruments AR7 System-on-a-Chip family: TNETD7100, 7200 and 7300.
arch/mips/ar7/platform.c +1 -192
223 lines not on this page · raw message
arch/mips/include/asm/mach-ar7/ar7.h +0 -1
@@ -142,7 +142,6 @@ static inline int ar7_has_high_cpmac(void)return -ENXIO ; } } -#define ar7_has_high_vlynq ar7_has_high_cpmac#define ar7_has_second_uart ar7_has_high_cpmacstatic inline void ar7_device_enable (u32 bit)
Signature · 1 line
2.35.1
RFC PATCH 2/2 vlynq: remove bus driver
In reply to Wolfram SangFrom: Wolfram Sang <[email protected]>
There are no users with a vlynq_driver in the Kernel tree. So, remove the bus driver which hardly has seen any activity since 2009. It was even marked EXPERIMENTAL as long as that symbol existed. OpenWRT had some out-of-tree drivers which they probably intended to upport, but AR7 devices are not supported anymore because they are "stuck with Kernel 3.18" [1]. So, this code can go nowadays.
[1] https://openwrt.org/docs/techref/targets/ar7
--- MAINTAINERS | 7 - drivers/Kconfig | 2 - drivers/Makefile | 1 - drivers/vlynq/Kconfig | 21 -- drivers/vlynq/Makefile | 6 - drivers/vlynq/vlynq.c | 799 ----------------------------------------- include/linux/vlynq.h | 149 -------- 7 files changed, 985 deletions(-) delete mode 100644 drivers/vlynq/Kconfig delete mode 100644 drivers/vlynq/Makefile delete mode 100644 drivers/vlynq/vlynq.c delete mode 100644 include/linux/vlynq.h
MAINTAINERS +0 -7
@@ -22962,13 +22962,6 @@ W: https://linuxtv.org T: git git://linuxtv.org/media_tree.git F: drivers/media/test-drivers/vivid/* -VLYNQ BUS -M: Florian Fainelli <[email protected]> -L: [email protected] (subscribers-only) -S: Maintained -F: drivers/vlynq/vlynq.c -F: include/linux/vlynq.h - VM SOCKETS (AF_VSOCK) M: Stefano Garzarella <[email protected]> L: [email protected]
drivers/Kconfig +0 -2
@@ -135,8 +135,6 @@ source "drivers/uio/Kconfig" source "drivers/vfio/Kconfig" -source "drivers/vlynq/Kconfig" - source "drivers/virt/Kconfig" source "drivers/virtio/Kconfig"
drivers/Makefile +0 -1
@@ -151,7 +151,6 @@ obj-$(CONFIG_BCMA) += bcma/ obj-$(CONFIG_VHOST_RING) += vhost/ obj-$(CONFIG_VHOST_IOTLB) += vhost/ obj-$(CONFIG_VHOST) += vhost/ -obj-$(CONFIG_VLYNQ) += vlynq/ obj-$(CONFIG_GREYBUS) += greybus/ obj-$(CONFIG_COMEDI) += comedi/ obj-$(CONFIG_STAGING) += staging/
drivers/vlynq/Kconfig deleted +0 -0
drivers/vlynq/Makefile deleted +0 -0
drivers/vlynq/vlynq.c deleted +0 -0
include/linux/vlynq.h deleted +0 -0
Signature · 1 line
2.35.1
Quoted 21 lines · Wolfram Sang
From: Wolfram Sang <[email protected]>
I'd like to clean up the 'drivers' directory and
Kconfigmenu, at least a little. One major thing I noticed is that VLYNQ can actually be removed. From patch 2:---
There are no users with avlynq_driverin the Kernel tree. So, remove the bus driver which hardly has seen any activity since 2009. It was even marked EXPERIMENTAL as long as that symbol existed. OpenWRT had some out-of-tree drivers which they probably intended to upport, but AR7 devices are not supported anymore because they are "stuck with Kernel 3.18" [1]. So, this code can go nowadays.[1] https://openwrt.org/docs/techref/targets/ar7
---Patch 1 removes MIPS specific bus initialization code which is the only user of the VLYNQ bus currently.
Quoted 6 lines
Sending out as RFC to gather comments. Patches are based on 6.6-rc1 and created with "--irreversible-delete" to save some space. They are compile tested only, buildbots were happy.
I think this mainly goes to Florian Fainelli. Florian, what do you think?
I'm not Florian, but I worked a bit with AR7 as well, and going through the (previously) supported/known devices they topped out at 8 MiB Flash and 32 MiB RAM, which isn't enough to run any reasonably modern OpenWrt even if one would be willing to re-add support for it.
So from my perspective I suggest even dropping the AR7 code entirely. I seriously doubt anyone is running a modern kernel on that.
Best Regards,
Jonas
Quoted 20 lines · Wolfram Sang
From: Wolfram Sang <[email protected]>
I'd like to clean up the 'drivers' directory and
Kconfigmenu, at least a little. One major thing I noticed is that VLYNQ can actually be removed. From patch 2:---
There are no users with avlynq_driverin the Kernel tree. So, remove the bus driver which hardly has seen any activity since 2009. It was even marked EXPERIMENTAL as long as that symbol existed. OpenWRT had some out-of-tree drivers which they probably intended to upport, but AR7 devices are not supported anymore because they are "stuck with Kernel 3.18" [1]. So, this code can go nowadays.[1] https://openwrt.org/docs/techref/targets/ar7
---Patch 1 removes MIPS specific bus initialization code which is the only user of the VLYNQ bus currently.
Quoted 6 lines
Sending out as RFC to gather comments. Patches are based on 6.6-rc1 and created with "--irreversible-delete" to save some space. They are compile tested only, buildbots were happy.
I think this mainly goes to Florian Fainelli. Florian, what do you think?
Quoted 29 lines · Jonas Gorski
Quoted 21 lines · Wolfram Sang
From: Wolfram Sang <[email protected]>
I'd like to clean up the 'drivers' directory and
Kconfigmenu, at least a little. One major thing I noticed is that VLYNQ can actually be removed. From patch 2:---
There are no users with avlynq_driverin the Kernel tree. So, remove the bus driver which hardly has seen any activity since 2009. It was even marked EXPERIMENTAL as long as that symbol existed. OpenWRT had some out-of-tree drivers which they probably intended to upport, but AR7 devices are not supported anymore because they are "stuck with Kernel 3.18" [1]. So, this code can go nowadays.[1] https://openwrt.org/docs/techref/targets/ar7
---Patch 1 removes MIPS specific bus initialization code which is the only user of the VLYNQ bus currently.
Quoted 6 lines
Sending out as RFC to gather comments. Patches are based on 6.6-rc1 and created with "--irreversible-delete" to save some space. They are compile tested only, buildbots were happy.
I think this mainly goes to Florian Fainelli. Florian, what do you think?
Quoted 7 lines
I'm not Florian, but I worked a bit with AR7 as well, and going through the (previously) supported/known devices they topped out at 8 MiB Flash and 32 MiB RAM, which isn't enough to run any reasonably modern OpenWrt even if one would be willing to re-add support for it.
So from my perspective I suggest even dropping the AR7 code entirely. I seriously doubt anyone is running a modern kernel on that.
Agreed, TI AR7 is nearly 25 years old now, we should be able to remove that. Wolfram, do you feel like doing that or would you rather have me do it, say next week?
Signature · 1 line
Florian
Quoted 4 lines
Agreed, TI AR7 is nearly 25 years old now, we should be able to remove that. Wolfram, do you feel like doing that or would you rather have me do it, say next week?
I will try it, thanks for the heads up everyone!
Hi all,
Quoted 3 lines
Agreed, TI AR7 is nearly 25 years old now, we should be able to remove that. Wolfram, do you feel like doing that or would you rather have me do it, say next week?
So, I pushed out an RC here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/cleanup/remove_ar7
Just waiting for the buildbot report before I send out patches. buildbot was already happy with my protoype, though. But I needed to reorder the patches. (I do wonder, though, if they build AR7. I would have expected a build failure with my prototype).
Happy hacking,
Wolfram
Quoted 6 lines · Wolfram Sang
Hi all,
Quoted 3 lines
Agreed, TI AR7 is nearly 25 years old now, we should be able to remove that. Wolfram, do you feel like doing that or would you rather have me do it, say next week?
Quoted 8 lines
So, I pushed out an RC here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.gitrenesas/cleanup/remove_ar7Just waiting for the buildbot report before I send out patches. buildbot was already happy with my protoype, though. But I needed to reorder the patches. (I do wonder, though, if they build AR7. I would have expected a build failure with my prototype).
Looks good to me, just a few nits:
arch/arm/configs/pxa_defconfig:CONFIG_MTD_AR7_PARTS=m
this is clearly a stray reference to begin with, but should be folded in your commit removing the MTD partition parser.
Other than that, LGTM and thanks for doing that clean up.
Signature · 1 line
Florian
Hi Florian,
Quoted 1 line
arch/arm/configs/pxa_defconfig:CONFIG_MTD_AR7_PARTS=m
Thanks, I removed this line as well.
Quoted 1 line
Other than that, LGTM and thanks for doing that clean up.
Cool, thanks for the review!
Happy hacking,
Wolfram