staging: vme_user: Fixed prink formatting issues
PATCH 1/1 staging: vme_user: Fixed prink formatting issues
Fixed issues relating to prink message including:
a. using __func__ to replace function's name
b. using pr_warn to replace "printk(KERN_ERR"
Issue found by checkpatch
--- drivers/staging/vme_user/vme.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/vme_user/vme.c +8 -8
@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -568,7 +568,7 @@ int vme_master_set(struct vme_resource *resource, int enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_set) { -printk (KERN_WARNING "vme_master_set not supported\n" ); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -618,7 +618,7 @@ int vme_master_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_get) { -printk (KERN_WARNING "%s not supported\n" , __func__); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -1552,7 +1552,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_set) { -printk (KERN_ERR "vme_lm_set not supported\n" ); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -1588,7 +1588,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_get) { -printk (KERN_ERR "vme_lm_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1625,7 +1625,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_attach) { -printk (KERN_ERR "vme_lm_attach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1658,7 +1658,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor) lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_detach) { -printk (KERN_ERR "vme_lm_detach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1725,7 +1725,7 @@ int vme_slot_num(struct vme_dev *vdev) }if (!bridge->slot_get) { -printk (KERN_WARNING "vme_slot_num not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }
Signature · 1 line
2.25.1
PATCH RESEND 1/1 staging: vme_user: Fixed prink formatting issues
Fixed issues relating to prink message including:
a. using __func__ to replace function's name
b. using pr_warn to replace "printk(KERN_ERR"
Issue found by checkpatch
--- drivers/staging/vme_user/vme.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/vme_user/vme.c +8 -8
@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -568,7 +568,7 @@ int vme_master_set(struct vme_resource *resource, int enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_set) { -printk (KERN_WARNING "vme_master_set not supported\n" ); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -618,7 +618,7 @@ int vme_master_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_get) { -printk (KERN_WARNING "%s not supported\n" , __func__); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -1552,7 +1552,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_set) { -printk (KERN_ERR "vme_lm_set not supported\n" ); +pr_warn ("%s not supported\n" , __func__);return -EINVAL ; }
@@ -1588,7 +1588,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_get) { -printk (KERN_ERR "vme_lm_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1625,7 +1625,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_attach) { -printk (KERN_ERR "vme_lm_attach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1658,7 +1658,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor) lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_detach) { -printk (KERN_ERR "vme_lm_detach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1725,7 +1725,7 @@ int vme_slot_num(struct vme_dev *vdev) }if (!bridge->slot_get) { -printk (KERN_WARNING "vme_slot_num not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }
Signature · 1 line
2.25.1
Greg KH
maintainerQuoted 11 lines · Piro Yang
Fixed issues relating to prink message including:
a. using
__func__to replace function's name
b. usingpr_warnto replace "printk(KERN_ERR"Issue found by checkpatch
Signed-off-by Piro Yang <[email protected]>--- drivers/staging/vme_user/vme.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
Why is this a RESEND?
Greg KH
maintainerQuoted 17 lines · Piro Yang
Fixed issues relating to prink message including:
a. using
__func__to replace function's name
b. usingpr_warnto replace "printk(KERN_ERR"Issue found by checkpatch
Signed-off-by Piro Yang <[email protected]>--- drivers/staging/vme_user/vme.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/staging/vme_user/vme.c +0
-0
drivers/staging/vme_user/vme.c int vme_slave_get(struct vme_resource *resource, int *enabled, · line 421
Quoted 5 lines
drivers/staging/vme_user/vme.c +1
-1@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +pr_warn ("%s not supported\n" , __func__);
KERN_ERR is not the same thing a pr_warn(), why did you make this change?
And you are doing multiple things in the same change, why?
Also, drivers should always use dev_warn(), not pr_*() calls.
thanks,
greg k-h
PATCH v2 1/1 staging: vme_user: Fixed prink formatting issue
Fixed issue relating to prink message:
*using __func__ to replace function's name
Issue found by checkpatch
--- drivers/staging/vme_user/vme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/vme_user/vme.c +7 -7
@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -568,7 +568,7 @@ int vme_master_set(struct vme_resource *resource, int enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_set) { -printk (KERN_WARNING "vme_master_set not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1552,7 +1552,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_set) { -printk (KERN_ERR "vme_lm_set not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1588,7 +1588,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_get) { -printk (KERN_ERR "vme_lm_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1625,7 +1625,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_attach) { -printk (KERN_ERR "vme_lm_attach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1658,7 +1658,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor) lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_detach) { -printk (KERN_ERR "vme_lm_detach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1725,7 +1725,7 @@ int vme_slot_num(struct vme_dev *vdev) }if (!bridge->slot_get) { -printk (KERN_WARNING "vme_slot_num not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }
Signature · 1 line
2.25.1
Re: [PATCH v2] staging: vme_user: Fixed prink formatting issue
Quoted 9 lines · Piro Yang
Fixed issue relating to prink message:
*using__func__to replace function's nameIssue found by checkpatch
Signed-off-by Piro Yang<[email protected]>--- drivers/staging/vme_user/vme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Hi,
you need in any case a changelog what you changed with the v2 Version.
Your subject is to general. Please consider that the maintainer needs to recognize what it is about. So make it more unique.
Bye Philipp
PATCH v2 1/1 staging: vme_user: using __func__ to replace function's name in printk
Fix issue relating to prink message:
*using __func__ to replace function's name
Issue found by checkpatch
---
Changes in v2:
- Firstly, fix only one type of Waring by checkpatch.
using '"%s...", __func__' substitute for function's name of printked information
drivers/staging/vme_user/vme.c +7 -7
@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -568,7 +568,7 @@ int vme_master_set(struct vme_resource *resource, int enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_set) { -printk (KERN_WARNING "vme_master_set not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1552,7 +1552,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_set) { -printk (KERN_ERR "vme_lm_set not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1588,7 +1588,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_get) { -printk (KERN_ERR "vme_lm_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1625,7 +1625,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_attach) { -printk (KERN_ERR "vme_lm_attach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1658,7 +1658,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor) lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_detach) { -printk (KERN_ERR "vme_lm_detach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }
@@ -1725,7 +1725,7 @@ int vme_slot_num(struct vme_dev *vdev) }if (!bridge->slot_get) { -printk (KERN_WARNING "vme_slot_num not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }
Signature · 1 line
2.25.1
Greg KH
maintainerRe: [PATCH v2] staging: vme_user: using __func__ to replace function's name in printk
Quoted 10 lines · Piro Yang
Fix issue relating to prink message:
*using__func__to replace function's nameIssue found by checkpatch
Signed-off-by Piro Yang <[email protected]>---
Changes in v2:
- Firstly, fix only one type of Waring by checkpatch.
using '"%s...",__func__' substitute for function's name of printked information
This is v3, right?
drivers/staging/vme_user/vme.c int vme_slave_get(struct vme_resource *resource, int *enabled, · line 421
Quoted 11 lines
drivers/staging/vme_user/vme.c +1
-1@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);
Please move to real dev_err() calls instead of trying to fix up old and broken printk() calls. That's the correct solution here for this codebase and if you look on the list, I think there are patches that do this already, right?
thanks,
greg k-h
Greg KH
maintainerRe: [PATCH v2] staging: vme_user: Fixed prink formatting issue
In reply to Piro YangQuoted 81 lines · Piro Yang
Fixed issue relating to prink message:
*using__func__to replace function's nameIssue found by checkpatch
Signed-off-by Piro Yang <[email protected]>--- drivers/staging/vme_user/vme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/staging/vme_user/vme.c +7
-7@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, image = list_entry(resource->entry, struct vme_slave_resource, list);if (!bridge->slave_get) { -printk (KERN_ERR "vme_slave_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }@@ -568,7 +568,7 @@ int vme_master_set(struct vme_resource *resource, int enabled, image = list_entry(resource->entry, struct vme_master_resource, list);if (!bridge->master_set) { -printk (KERN_WARNING "vme_master_set not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }@@ -1552,7 +1552,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_set) { -printk (KERN_ERR "vme_lm_set not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }@@ -1588,7 +1588,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_get) { -printk (KERN_ERR "vme_lm_get not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }@@ -1625,7 +1625,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor, lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_attach) { -printk (KERN_ERR "vme_lm_attach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }@@ -1658,7 +1658,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor) lm = list_entry(resource->entry, struct vme_lm_resource, list);if (!bridge->lm_detach) { -printk (KERN_ERR "vme_lm_detach not supported\n" ); +printk (KERN_ERR "%s not supported\n" , __func__);return -EINVAL ; }@@ -1725,7 +1725,7 @@ int vme_slot_num(struct vme_dev *vdev) }if (!bridge->slot_get) { -printk (KERN_WARNING "vme_slot_num not supported\n" ); +printk (KERN_WARNING "%s not supported\n" , __func__);return -EINVAL ; }Signature · 1 line
2.25.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot