RDMA/rtrs: Require holding rcu_read_lock explicitly
Subsystems (2)
PATCH v2 1/1 RDMA/rtrs: Require holding rcu_read_lock explicitly
From: Zhu Yanjun <[email protected]>
No functional change. The function get_next_path_rr needs to hold rcu_read_lock. As such, if no rcu read lock, warnings will pop out.
Acked-by Jack Wang <[email protected]>
Signed-off-by Zhu Yanjun <[email protected]>
---V1->V2: Replace WARN_ON_ONCE with RCU_LOCKDEP_WARN
--- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/infiniband/ulp/rtrs/rtrs-clt.c +6 -1
@@ -775,7 +775,7 @@ rtrs_clt_get_next_path_or_null(struct list_head *head, struct rtrs_clt_path *clt* Related to @MP_POLICY_RR * * Locks: -* rcu_read_lock() must be hold. +* rcu_read_lock() must be held. */ static struct rtrs_clt_path *get_next_path_rr (struct path_it *it) {
@@ -783,6 +783,11 @@ static struct rtrs_clt_path *get_next_path_rr(struct path_it *it)struct rtrs_clt_path *path;struct rtrs_clt_sess *clt; +/* +* Assert that rcu lock must be held +*/ +RCU_LOCKDEP_WARN (!rcu_read_lock_held (),"no rcu read lock held" ); + clt = it->clt;/*
Signature · 1 line
2.27.0
Leon Romanovsky
AppliedQuoted 4 lines · Zhu Yanjun
No functional change. The function
get_next_path_rrneeds to holdrcu_read_lock. As such, if no rcu read lock, warnings will pop out.
Applied, thanks!
[1/1] RDMA/rtrs: Require holding rcu_read_lock explicitly
https://git.kernel.org/rdma/rdma/c/20a02837fb5e16
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>