Skip to contentSkip to conversation

MAINTAINERS: Update drm-misc entry to match all drivers

PATCH Superseded Maxime Ripard 7 participants 13 messages Sep 19, 2023 – Sep 21, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Update drm-misc entry to match all drivers

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
 MAINTAINERS | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +20 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
 S:	Maintained
 W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
 T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
 F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
 F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
 F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
 
 DRM DRIVERS FOR ALLWINNER A10
 M:	Maxime Ripard <[email protected]>
Signature · 1 line
2.41.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

FWIW,

Quoted 41 lines
---
 MAINTAINERS | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +20 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
 S:	Maintained
 W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
 T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
 F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
 F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
 F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
 
 DRM DRIVERS FOR ALLWINNER A10
 M:	Maxime Ripard <[email protected]>
Signature · 1 line
Jani Nikula, Intel
#2 lore raw
In reply to Maxime Ripard

Hi,

Quoted 40 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---
  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +13 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
  S:	Maintained
  W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
  F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
  F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
  F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/
+X:	drivers/gpu/drm/ingenic/

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6888

Quoted 10 lines
MAINTAINERS +7 -0
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
 
  DRM DRIVERS FOR ALLWINNER A10
  M:	Maxime Ripard <[email protected]>

Nice patch!

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).
2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the code for this link is not up to date.

I think at least the drm/ingenic and drm/gma500 drivers are *actually* maintained through drm-misc, So perhaps, these two drivers should not be excluded. Am I correct?

#3 lore raw

Hi,

Adding Paul in Cc

Quoted 54 lines · suijingfeng
Quoted 39 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---
  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +12 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
  S:	Maintained
  W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
  F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
  F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
  F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6887

Quoted 10 lines
MAINTAINERS +8 -0
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
  DRM DRIVERS FOR ALLWINNER A10
  M:	Maxime Ripard <[email protected]>

Nice patch!

Quoted 4 lines

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).

Yeah, I wasn't sure about that one indeed. I remained conservative since it's a sensitive topic for some.

Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, could you clarify which git tree is supposed to merge those patches in MAINTAINERS?

Quoted 1 line

2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the

code for this link is not up to date.

For gma500, I think it's mostly historical since it was there before drm-misc was a thing.

Quoted 3 lines

I think at least the drm/ingenic and drm/gma500 drivers are *actually* maintained through drm-misc, So perhaps, these two drivers should not be excluded. Am I correct?

It's likely :)

Either way, I think it can be solved/clarified later on

Maxime

#4 lore raw

Hi,

Le jeudi 21 septembre 2023 à 10:47 +0200, Maxime Ripard a écrit :

Quoted 75 lines

Hi,

Adding Paul in Cc

Quoted 59 lines · suijingfeng
Quoted 52 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't
pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all
the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---

  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +0 -0
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:      Thomas Zimmermann

<[email protected]>
  S:    Maintained

W:    https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-
misc.html
  T:    git git://anongit.freedesktop.org/drm/drm-misc

MAINTAINERS +2 -0
+F:     Documentation/devicetree/bindings/display/
+F:     Documentation/devicetree/bindings/gpu/

  F:    Documentation/gpu/

MAINTAINERS +1 -1
-F:     drivers/gpu/drm/*
+F:     drivers/gpu/drm/

  F:    drivers/gpu/vga/

MAINTAINERS +1 -1
-F:     include/drm/drm*
+F:     include/drm/drm

  F:    include/linux/vga*

MAINTAINERS +16 -1
-F:     include/uapi/drm/drm*
+F:     include/uapi/drm/
+X:     drivers/gpu/drm/amd/
+X:     drivers/gpu/drm/armada/
+X:     drivers/gpu/drm/etnaviv/
+X:     drivers/gpu/drm/exynos/
+X:     drivers/gpu/drm/gma500/
+X:     drivers/gpu/drm/i915/
+X:     drivers/gpu/drm/imx/
+X:     drivers/gpu/drm/ingenic/
+X:     drivers/gpu/drm/kmb/
+X:     drivers/gpu/drm/mediatek/
+X:     drivers/gpu/drm/msm/
+X:     drivers/gpu/drm/nouveau/
+X:     drivers/gpu/drm/radeon/
+X:     drivers/gpu/drm/renesas/
+X:     drivers/gpu/drm/tegra/
Quoted 2 lines

  DRM DRIVERS FOR ALLWINNER A10
  M:    Maxime Ripard <[email protected]>

Nice patch!

Quoted 6 lines

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).

Yeah, I wasn't sure about that one indeed. I remained conservative since it's a
sensitive topic for some.

Quoted 5 lines

Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way,
could you clarify which git tree is supposed to merge those patches in
MAINTAINERS?

drm/ingenic is maintained through drm-misc, yes.

Looking at the MAINTAINERS file, it seems to be one of the only DRM drivers without its own entry. I'll add one then.

Cheers,
-Paul

Quoted 20 lines
Quoted 3 lines

2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-
gma500", but the

  code for this link is not up to date.

For gma500, I think it's mostly historical since it was there before drm-misc
was a thing.

Quoted 5 lines

I think at least the drm/ingenic and drm/gma500 drivers are *actually*
maintained through drm-misc, So perhaps, these two drivers should not be
excluded. Am I correct?

It's likely :)

Either way, I think it can be solved/clarified later on

Maxime

#9 lore raw
In reply to Maxime Ripard

Hi Maxime

Am 19.09.23 um 15:12 schrieb Maxime Ripard:

Quoted 27 lines

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---
  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +3 -2
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
  S:	Maintained
  W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
  F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
  F:	drivers/gpu/vga/
-F:	include/drm/drm*

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6876

Quoted 10 lines
MAINTAINERS +7 -1
+F:	include/drm/drm
  F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
 
+X:	drivers/gpu/drm/gma500/

We always had gma500 in drm-misc. Where else would these go?

Best regards
Thomas

Quoted 13 lines
MAINTAINERS +10 -0
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
 
  DRM DRIVERS FOR ALLWINNER A10

M: Maxime Ripard <[email protected]>

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
#6 lore raw
In reply to Maxime Ripard

Hi,

Quoted 75 lines · Maxime Ripard

Hi,

Adding Paul in Cc

Quoted 53 lines · suijingfeng
Quoted 39 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
   MAINTAINERS | 23 ++++++++++++++++++++---
   1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +12 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
   S:	Maintained
   W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
   T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
   F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
   F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
   F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6887

Quoted 10 lines
MAINTAINERS +8 -0
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
   DRM DRIVERS FOR ALLWINNER A10
   M:	Maxime Ripard <[email protected]>

Nice patch!

Quoted 4 lines

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).

Yeah, I wasn't sure about that one indeed. I remained conservative since it's a sensitive topic for some.

Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, could you clarify which git tree is supposed to merge those patches in MAINTAINERS?

Quoted 1 line

2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the

code for this link is not up to date.

For gma500, I think it's mostly historical since it was there before drm-misc was a thing.

Quoted 6 lines
Quoted 3 lines

I think at least the drm/ingenic and drm/gma500 drivers are *actually* maintained through drm-misc, So perhaps, these two drivers should not be excluded. Am I correct?

It's likely :)

Either way, I think it can be solved/clarified later on

OK, that's sound fairly enough. I will respect you and Paul's opinion. By the way, I also want to say that I think the drm/imb and various drm/imx drivers are also belong to the drm-misc. They are also lack the "T" annotation. Hopes someone can help to check that. Thanks.
Thanks for the patch.

Quoted 1 line

Maxime

#10 lore raw
In reply to Thomas Zimmermann

Hi Thomas,

Quoted 37 lines · Thomas Zimmermann

Am 19.09.23 um 15:12 schrieb Maxime Ripard:

Quoted 35 lines

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---
  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +9 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
  S:	Maintained
  W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
  F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
  F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
  F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
Quoted 3 lines

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6875

Quoted 1 line
MAINTAINERS +1 -0
+X:	drivers/gpu/drm/gma500/

We always had gma500 in drm-misc. Where else would these go?

The maintainers entry has a git repo. I'll update it (and that patch too) then

Maxime

#5 lore raw
In reply to Paul Cercueil

Hi Paul,

Quoted 78 lines · Paul Cercueil

Le jeudi 21 septembre 2023 à 10:47 +0200, Maxime Ripard a écrit :

Quoted 71 lines · suijingfeng
Quoted 59 lines · Maxime Ripard
Quoted 52 lines

We've had a number of times when a patch slipped through and we couldn't
pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all
the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---

  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +0 -0
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:      Thomas Zimmermann

<[email protected]>
  S:    Maintained

W:    https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-
misc.html
  T:    git git://anongit.freedesktop.org/drm/drm-misc

MAINTAINERS +2 -0
+F:     Documentation/devicetree/bindings/display/
+F:     Documentation/devicetree/bindings/gpu/

  F:    Documentation/gpu/

MAINTAINERS +1 -1
-F:     drivers/gpu/drm/*
+F:     drivers/gpu/drm/

  F:    drivers/gpu/vga/

MAINTAINERS +1 -1
-F:     include/drm/drm*
+F:     include/drm/drm

  F:    include/linux/vga*

MAINTAINERS +16 -1
-F:     include/uapi/drm/drm*
+F:     include/uapi/drm/
+X:     drivers/gpu/drm/amd/
+X:     drivers/gpu/drm/armada/
+X:     drivers/gpu/drm/etnaviv/
+X:     drivers/gpu/drm/exynos/
+X:     drivers/gpu/drm/gma500/
+X:     drivers/gpu/drm/i915/
+X:     drivers/gpu/drm/imx/
+X:     drivers/gpu/drm/ingenic/
+X:     drivers/gpu/drm/kmb/
+X:     drivers/gpu/drm/mediatek/
+X:     drivers/gpu/drm/msm/
+X:     drivers/gpu/drm/nouveau/
+X:     drivers/gpu/drm/radeon/
+X:     drivers/gpu/drm/renesas/
+X:     drivers/gpu/drm/tegra/
Quoted 2 lines

  DRM DRIVERS FOR ALLWINNER A10
  M:    Maxime Ripard <[email protected]>

Nice patch!

Quoted 6 lines

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).

Yeah, I wasn't sure about that one indeed. I remained conservative since it's a
sensitive topic for some.

Quoted 5 lines

Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way,
could you clarify which git tree is supposed to merge those patches in
MAINTAINERS?

Quoted 4 lines

drm/ingenic is maintained through drm-misc, yes.

Looking at the MAINTAINERS file, it seems to be one of the only DRM drivers without its own entry. I'll add one then.

Ack, thanks!
Maxime

#8 lore raw
In reply to Maxime Ripard
Quoted 71 lines · Maxime Ripard

Hi,

Adding Paul in Cc

Quoted 54 lines · suijingfeng
Quoted 39 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---
  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +12 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
  S:	Maintained
  W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
  F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
  F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
  F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6887

Quoted 10 lines
MAINTAINERS +8 -0
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
  DRM DRIVERS FOR ALLWINNER A10
  M:	Maxime Ripard <[email protected]>

Nice patch!

Quoted 4 lines

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).

Yeah, I wasn't sure about that one indeed. I remained conservative since it's a sensitive topic for some.

Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, could you clarify which git tree is supposed to merge those patches in MAINTAINERS?

Quoted 5 lines
Quoted 1 line

2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the

code for this link is not up to date.

For gma500, I think it's mostly historical since it was there before drm-misc was a thing.

Yes, that's the reason. I used do PRs from my github before we had drm-misc but now everything gma500 related goes through drm-misc.

Quoted 10 lines
Quoted 4 lines

I think at least the drm/ingenic and drm/gma500 drivers are *actually* maintained through drm-misc, So perhaps, these two drivers should not be excluded. Am I correct?

It's likely :)

Either way, I think it can be solved/clarified later on

Maxime

#7 lore raw
In reply to Sui Jingfeng
Quoted 79 lines · Sui Jingfeng
Quoted 78 lines · Maxime Ripard

Adding Paul in Cc

Quoted 53 lines · suijingfeng
Quoted 39 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
   MAINTAINERS | 23 ++++++++++++++++++++---
   1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +12 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
   S:	Maintained
   W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
   T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
   F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
   F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
   F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6887

Quoted 10 lines
MAINTAINERS +8 -0
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/
   DRM DRIVERS FOR ALLWINNER A10
   M:	Maxime Ripard <[email protected]>

Nice patch!

Quoted 4 lines

Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?

As far as I know:
1) the drm/ingenic driver don't have a "T" annotation (location of the link).

Yeah, I wasn't sure about that one indeed. I remained conservative since it's a sensitive topic for some.

Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, could you clarify which git tree is supposed to merge those patches in MAINTAINERS?

Quoted 1 line

2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the

code for this link is not up to date.

For gma500, I think it's mostly historical since it was there before drm-misc was a thing.

Quoted 3 lines

I think at least the drm/ingenic and drm/gma500 drivers are *actually* maintained through drm-misc, So perhaps, these two drivers should not be excluded. Am I correct?

It's likely :)

Quoted 8 lines
Quoted 1 line

Either way, I think it can be solved/clarified later on

OK, that's sound fairly enough. I will respect you and Paul's opinion. By the way, I also want to say that I think the drm/imb and various drm/imx drivers are also belong to the drm-misc. They are also lack the "T" annotation. Hopes someone can help to check that. Thanks.
Thanks for the patch.

As far as I know, imx is kind of in-between at the moment. Some patches are going through drm-misc, but others are coming through their tree. For kmb (if that's what you meant), then I would expect intel to do the maintenance like they do for i915.

But given this discussion it could be a good idea to add all the maintainers of those excluded drivers in Cc in the next revision.

Maxime

#11 lore raw
In reply to Maxime Ripard

Hi,

Quoted 36 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---
  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +10 -3
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <[email protected]>
  S:	Maintained
  W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/
+F:	Documentation/devicetree/bindings/gpu/
  F:	Documentation/gpu/
-F:	drivers/gpu/drm/*
+F:	drivers/gpu/drm/
  F:	drivers/gpu/vga/
-F:	include/drm/drm*
+F:	include/drm/drm
  F:	include/linux/vga*
-F:	include/uapi/drm/drm*
+F:	include/uapi/drm/
+X:	drivers/gpu/drm/amd/
+X:	drivers/gpu/drm/armada/
+X:	drivers/gpu/drm/etnaviv/
+X:	drivers/gpu/drm/exynos/
+X:	drivers/gpu/drm/gma500/

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6885

Quoted 10 lines
MAINTAINERS +10 -0
+X:	drivers/gpu/drm/i915/
+X:	drivers/gpu/drm/imx/
+X:	drivers/gpu/drm/ingenic/
+X:	drivers/gpu/drm/kmb/
+X:	drivers/gpu/drm/mediatek/
+X:	drivers/gpu/drm/msm/
+X:	drivers/gpu/drm/nouveau/
+X:	drivers/gpu/drm/radeon/
+X:	drivers/gpu/drm/renesas/
+X:	drivers/gpu/drm/tegra/

Should drivers/gpu/drm/ci/ be in the list too?

Thanks,
Helen

Quoted 3 lines
MAINTAINERS +0 -0
  DRM DRIVERS FOR ALLWINNER A10
  M:	Maxime Ripard <[email protected]>
#12 lore raw
Quoted 43 lines · Helen Koike

Hi,

Quoted 40 lines · Maxime Ripard

We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd.

Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

---
  MAINTAINERS | 23 ++++++++++++++++++++---

  1 file changed, 20 insertions(+), 3 deletions(-)
MAINTAINERS +0 -0
index 90f13281d297..757d4f33e158 100644
@@ -6860,12 +6860,29 @@ M:    Thomas Zimmermann <[email protected]>

  S:    Maintained
  W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
  T:    git git://anongit.freedesktop.org/drm/drm-misc

MAINTAINERS +2 -0
+F:    Documentation/devicetree/bindings/display/
+F:    Documentation/devicetree/bindings/gpu/

  F:    Documentation/gpu/

MAINTAINERS +1 -1
-F:    drivers/gpu/drm/*
+F:    drivers/gpu/drm/

  F:    drivers/gpu/vga/

MAINTAINERS +1 -1
-F:    include/drm/drm*
+F:    include/drm/drm

  F:    include/linux/vga*

MAINTAINERS +10 -1
-F:    include/uapi/drm/drm*
+F:    include/uapi/drm/
+X:    drivers/gpu/drm/amd/
+X:    drivers/gpu/drm/armada/
+X:    drivers/gpu/drm/etnaviv/
+X:    drivers/gpu/drm/exynos/
+X:    drivers/gpu/drm/gma500/
+X:    drivers/gpu/drm/i915/
+X:    drivers/gpu/drm/imx/
+X:    drivers/gpu/drm/ingenic/
+X:    drivers/gpu/drm/kmb/
Quoted 8 lines

MAINTAINERS M: Thomas Zimmermann <[email protected]> · line 6885

Quoted 6 lines
MAINTAINERS +6 -0
+X:    drivers/gpu/drm/mediatek/
+X:    drivers/gpu/drm/msm/
+X:    drivers/gpu/drm/nouveau/
+X:    drivers/gpu/drm/radeon/
+X:    drivers/gpu/drm/renesas/
+X:    drivers/gpu/drm/tegra/

Should drivers/gpu/drm/ci/ be in the list too?

ops, please ignore this message, I misread the patch, it is already included by default (instead of excluded).

sorry for the noise.
Helen

Quoted 6 lines

Thanks,
Helen

Quoted 2 lines

  DRM DRIVERS FOR ALLWINNER A10
  M:    Maxime Ripard <[email protected]>