mm/slub: add sanity check for slub_min/max_order cmdline setup
Subsystems (2)
PATCH 1/1 mm/slub: add sanity check for slub_min/max_order cmdline setup
Currently there are 2 parameters could be setup from kernel cmdline:slub_min_order and slub_max_order. It's possible that the user configured slub_min_order is bigger than the default slub_max_order [1], which can still take effect, as calculate_oder() will use MAX_ORDER as a fallback to check against, but has some downsides:
* the kernel message about SLUB will be strange in showing min/max orders:
SLUB: HWalign=64, Order=9-3, MinObjects=0, CPUs=16, Nodes=1
* in calculate_order() called by each slab, the 2 loops of calc_slab_order() will all be meaningless due to slub_min_order is bigger than slub_max_order
* prevent future code cleanup like in [2].
Fix it by adding some sanity check to enforce the min/max semantics.
[1]. https://lore.kernel.org/lkml/[email protected]/
[2]. https://lore.kernel.org/lkml/[email protected]/
--- mm/slub.c | 6 ++++++ 1 file changed, 6 insertions(+)
mm/slub.c +6 -0
@@ -4711,6 +4711,9 @@ static int __init setup_slub_min_order(char *str) {get_option (&str, (int *)&slub_min_order); +if (slub_min_order > slub_max_order) + slub_max_order = slub_min_order; +return 1 ; }
@@ -4721,6 +4724,9 @@ static int __init setup_slub_max_order(char *str)get_option (&str, (int *)&slub_max_order); slub_max_order = min_t(unsigned int, slub_max_order, MAX_ORDER); +if (slub_min_order > slub_max_order) + slub_min_order = slub_max_order; +return 1 ; }
Signature · 1 line
2.27.0
Vlastimil Babka
AppliedQuoted 15 lines · Feng Tang
Currently there are 2 parameters could be setup from kernel cmdline:
slub_min_orderandslub_max_order. It's possible that the user configuredslub_min_orderis bigger than the defaultslub_max_order[1], which can still take effect, ascalculate_oder()will useMAX_ORDERas a fallback to check against, but has some downsides:* the kernel message about SLUB will be strange in showing min/max orders:
SLUB: HWalign=64, Order=9-3, MinObjects=0, CPUs=16, Nodes=1* in
calculate_order()called by each slab, the 2 loops ofcalc_slab_order()will all be meaningless due toslub_min_orderis bigger thanslub_max_order
Quoted 7 lines
* prevent future code cleanup like in [2].
Fix it by adding some sanity check to enforce the min/max semantics.
[1]. https://lore.kernel.org/lkml/[email protected]/
[2]. https://lore.kernel.org/lkml/[email protected]/Signed-off-by Feng Tang <[email protected]>
Thanks, applied!
Quoted 28 lines
--- mm/slub.c | 6 ++++++ 1 file changed, 6 insertions(+)mm/slub.c +6
-0@@ -4711,6 +4711,9 @@ static int __init setup_slub_min_order(char *str) {get_option (&str, (int *)&slub_min_order); +if (slub_min_order > slub_max_order) + slub_max_order = slub_min_order; +return 1 ; }@@ -4721,6 +4724,9 @@ static int __init setup_slub_max_order(char *str)get_option (&str, (int *)&slub_max_order); slub_max_order = min_t(unsigned int, slub_max_order, MAX_ORDER); +if (slub_min_order > slub_max_order) + slub_min_order = slub_max_order; +return 1 ; }