seccomp01.c: Add SECCOMP_RET_USER_NOTIF check
PATCH 1/1 seccomp01.c: Add SECCOMP_RET_USER_NOTIF check
This case will report EINVAL error when execute SAFE_IOCTL(notifyFd, SECCOMP_IOCTL_NOTIF_RECV, req) such as 5.6.19, so i put current case's .min_kver = "5.7.19"
NOTE: If your old kernel compile env is ubuntu 22.04 LTS, better use old gcc-8 and also apply patch base following link:
https://www.spinics.net/lists/kernel/msg3797871.html
--- configure.ac | 1 + include/lapi/seccomp.h | 7 + runtest/syscalls | 2 + testcases/kernel/syscalls/seccomp/.gitignore | 1 + testcases/kernel/syscalls/seccomp/Makefile | 8 + testcases/kernel/syscalls/seccomp/seccomp01.c | 456 ++++++++++++++++++ 6 files changed, 475 insertions(+) create mode 100644 testcases/kernel/syscalls/seccomp/.gitignore create mode 100644 testcases/kernel/syscalls/seccomp/Makefile create mode 100644 testcases/kernel/syscalls/seccomp/seccomp01.c
configure.ac +1 -0
@@ -138,6 +138,7 @@ AC_CHECK_FUNCS_ONCE([ \ renameat \ renameat2 \ sched_getcpu \ + seccomp \ sendmmsg \ sethostid \ setns \
include/lapi/seccomp.h +7 -0
@@ -37,4 +37,11 @@ struct seccomp_data { };#endif /* HAVE_LINUX_SECCOMP_H*/ + +# ifndef HAVE_SECCOMP +int seccomp (unsigned int operation,unsigned int flags,void *args) +{ +return syscall (__NR_seccomp, operation, flags, args); +} +# endif /* HAVE_SECCOMP */ #endif /* LAPI_SECCOMP_H__ */
runtest/syscalls +2 -0
@@ -1242,6 +1242,8 @@ select02 select02 select03 select03 select04 select04 +seccomp01 seccomp01 + semctl01 semctl01 semctl02 semctl02 semctl03 semctl03
testcases/kernel/syscalls/seccomp/.gitignore new file +1 -0
@@ -0,0 +1 @@ +seccomp01
testcases/kernel/syscalls/seccomp/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Copyright (c) 2023 Wei Gao <[email protected]> + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/seccomp/seccomp01.c new file +456 -0
456 lines not on this page · raw message
Signature · 5 lines
2.35.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hello,
Quoted 141 lines · Wei Gao via ltp
This case will report EINVAL error when execute
SAFE_IOCTL(notifyFd, SECCOMP_IOCTL_NOTIF_RECV, req)such as 5.6.19, so i put current case's .min_kver = "5.7.19"NOTE: If your old kernel compile env is ubuntu 22.04 LTS, better use old gcc-8 and also apply patch base following link:
https://www.spinics.net/lists/kernel/msg3797871.htmlSigned-off-by Wei Gao <[email protected]>--- configure.ac | 1 + include/lapi/seccomp.h | 7 + runtest/syscalls | 2 + testcases/kernel/syscalls/seccomp/.gitignore | 1 + testcases/kernel/syscalls/seccomp/Makefile | 8 + testcases/kernel/syscalls/seccomp/seccomp01.c | 456 ++++++++++++++++++ 6 files changed, 475 insertions(+) create mode 100644 testcases/kernel/syscalls/seccomp/.gitignore create mode 100644 testcases/kernel/syscalls/seccomp/Makefile create mode 100644 testcases/kernel/syscalls/seccomp/seccomp01.cconfigure.ac +1
-0@@ -138,6 +138,7 @@ AC_CHECK_FUNCS_ONCE([ \ renameat \ renameat2 \ sched_getcpu \ + seccomp \ sendmmsg \ sethostid \ setns \include/lapi/seccomp.h +7
-0@@ -37,4 +37,11 @@ struct seccomp_data { };#endif /* HAVE_LINUX_SECCOMP_H*/ + +# ifndef HAVE_SECCOMP +int seccomp (unsigned int operation,unsigned int flags,void *args) +{ +return syscall (__NR_seccomp, operation, flags, args); +} +# endif /* HAVE_SECCOMP */ #endif /* LAPI_SECCOMP_H__ */ runtest/syscalls +2
-0@@ -1242,6 +1242,8 @@ select02 select02 select03 select03 select04 select04 +seccomp01 seccomp01 + semctl01 semctl01 semctl02 semctl02 semctl03 semctl03testcases/kernel/syscalls/seccomp/.gitignore new file +1
-0@@ -0,0 +1 @@ +seccomp01testcases/kernel/syscalls/seccomp/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Copyright (c) 2023 Wei Gao <[email protected]> + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mktestcases/kernel/syscalls/seccomp/seccomp01.c new file +52
-0@@ -0,0 +1,456 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Copyright (c) 2023 Michael Kerrisk <[email protected]> +* Copyright (c) 2023 Wei Gao <[email protected]> +*/ + +/*\ +* [Description] +* +* Verify seccomp and seccomp_user_notif +*/ + +#define _GNU_SOURCE +#include <sys/types.h> +#include <sys/prctl.h> +#include <fcntl.h> +#include <limits.h> +#include <signal.h> +#include <stddef.h> +#include <stdint.h> +#include <stdbool.h> +#include <linux/audit.h> +#include <sys/syscall.h> +#include <sys/stat.h> +#include <linux/filter.h> +#include <linux/seccomp.h> +#include <sys/ioctl.h> +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <errno.h> +#include <sys/socket.h> +#include <sys/un.h> + +#include "tst_test.h" +#include "lapi/seccomp.h" + +#define TMP_PREFIX_DIR "/tmp/ltp_test" +#define CWD_DIR "./abc" +#define OTHER_DIR "/aa" + +static struct tcase { +char *dir; +int expect_ret; +char *desc; +} tcases[] = { + {TMP_PREFIX_DIR ,strlen (TMP_PREFIX_DIR ),"pathname begins with the prefix /tmp/" }, + {CWD_DIR ,0 ,"pathname begins with ./" }, + {OTHER_DIR ,-1 ,"pathname begins with /abc" }, +}; + +static int sendfd (int sockfd,int fd)
testcases/kernel/syscalls/seccomp/seccomp01.c line 62
Quoted 10 lines
testcases/kernel/syscalls/seccomp/seccomp01.c new file +10
-0+{ +struct msghdr msgh; +struct iovec iov; +int data; +struct cmsghdr *cmsgp; + +/* Allocate a char array of suitable size to hold the ancillary data. +* However, since this buffer is in reality a 'struct cmsghdr', use a +* union to ensure that it is suitable aligned. +*/
Comments like this are not LTP style. Explanations can go in the description. Inline comments are reserved for special cases.
testcases/kernel/syscalls/seccomp/seccomp01.c line 67
Quoted 5 lines
testcases/kernel/syscalls/seccomp/seccomp01.c new file +5
-0+union { +char buf[CMSG_SPACE (sizeof (int ))]; +/* Space large enough to hold an 'int' */ +struct cmsghdr align; + } controlMsg;
Also controlMsg is not LTP style. This continues thoughout the patch.
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp