firewire: Annotate struct fw_node with __counted_by
PATCH 1/1 firewire: Annotate struct fw_node with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct fw_node.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/firewire/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firewire/core.h +1 -1
@@ -191,7 +191,7 @@ struct fw_node {/* Upper layer specific data. */ void *data; -struct fw_node *ports[]; + struct fw_node *ports[] __counted_by(port_count); };static inline struct fw_node *fw_node_get (struct fw_node *node)
Signature · 1 line
2.34.1
Quoted 6 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).
Quoted 7 lines
As found with Coccinelle[1], add
__counted_byfor structfw_node.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Takashi Sakamoto <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
Signature · 1 line
Gustavo
Quoted 17 lines
--- drivers/firewire/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firewire/core.h +1
-1@@ -191,7 +191,7 @@ struct fw_node {/* Upper layer specific data. */ void *data; -struct fw_node *ports[]; + struct fw_node *ports[] __counted_by(port_count); };static inline struct fw_node *fw_node_get (struct fw_node *node)
Hi,
Quoted 8 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structfw_node.
Quoted 8 lines
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Takashi Sakamoto <[email protected]>Signed-off-by Kees Cook <[email protected]>--- drivers/firewire/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next branch, thanks.
Regards
Takashi Sakamoto