Skip to contentSkip to conversation

prime_vgem: Add mmap forwarding tests

igt-dev Tvrtko Ursulin 2 participants 4 messages Sep 25, 2023

lore
Share & tools
lore
#0 lore raw

From: Tvrtko Ursulin <[email protected]>

...

---
 tests/prime_vgem.c | 45 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 41 insertions(+), 4 deletions(-)
tests/prime_vgem.c +41 -4
index 876e04ed02a1..29eb7eccad61 100644
@@ -72,6 +72,21 @@
  * Feature: gtt, prime
  * Run type: BAT
  *
+ * SUBTEST: forwarded-wc
+ * Description: Examine access path through imported buffer mmap forwarding
+ * Feature: mmap, prime
+ * Run type: FULL
+ *
+ * SUBTEST: forwarded-uc
+ * Description: Examine access path through imported buffer mmap forwarding
+ * Feature: mmap, prime
+ * Run type: FULL
+ *
+ * SUBTEST: forwarded-wb
+ * Description: Examine access path through imported buffer mmap forwarding
+ * Feature: mmap, prime
+ * Run type: FULL
+ *
  * SUBTEST: basic-read
  * Description: Examine read access path.
  * Feature: gtt, prime
@@ -420,7 +435,7 @@ static void test_write(int vgem, int i915)
 	munmap(ptr, scratch.size);
 }
 
-static void test_gtt(int vgem, int i915)
+static void test_mmap_offset(int vgem, int i915, unsigned int flags)
 {
 	struct vgem_bo scratch;
 	uint32_t handle;
@@ -436,7 +451,16 @@ static void test_gtt(int vgem, int i915)
 	handle = prime_fd_to_handle(i915, dmabuf);
 	close(dmabuf);
 
-	ptr = gem_mmap__gtt(i915, handle, scratch.size, PROT_WRITE);
+	ptr = __gem_mmap_offset(i915, handle, 0, scratch.size, PROT_WRITE,
+				flags);
+	if (flags == I915_MMAP_OFFSET_GTT) {
+		/* Only allowed to fail if no aperture. */
+		igt_require(ptr || !gem_mappable_aperture_size(i915));
+
+	} else {
+		/* Skip on old kernels. */
+		igt_require(ptr);
+	}
 	for (i = 0; i < 1024; i++)
 		ptr[1024*i] = i;
 	munmap(ptr, scratch.size);
@@ -448,7 +472,8 @@ static void test_gtt(int vgem, int i915)
 	}
 	munmap(ptr, scratch.size);
 
-	ptr = gem_mmap__gtt(i915, handle, scratch.size, PROT_READ);
+	ptr = __gem_mmap_offset(i915, handle, 0, scratch.size, PROT_READ,
+				flags);
 	for (i = 0; i < 1024; i++)
 		igt_assert_eq(ptr[1024*i], ~i);
 	munmap(ptr, scratch.size);
@@ -1225,9 +1250,21 @@ igt_main
 	igt_describe("Examine access path through GTT.");
 	igt_subtest("basic-gtt") {
 		gem_require_mappable_ggtt(i915);
-		test_gtt(vgem, i915);
+		test_mmap_offset(vgem, i915, I915_MMAP_OFFSET_GTT);
 	}
 
+	igt_describe("Examine access path through mmap forwarding.");
+	igt_subtest("forwarded-wc")
+		test_mmap_offset(vgem, i915, I915_MMAP_OFFSET_WC);
+
+	igt_describe("Examine access path through mmap forwarding.");
+	igt_subtest("forwarded-uc")
+		test_mmap_offset(vgem, i915, I915_MMAP_OFFSET_UC);
+
+	igt_describe("Examine access path through mmap forwarding.");
+	igt_subtest("forwarded-wb")
+		test_mmap_offset(vgem, i915, I915_MMAP_OFFSET_WB);
+
 	igt_describe("Examine blitter access path.");
 	igt_subtest("basic-blt")
 		test_blt(vgem, i915);
Signature · 1 line
2.39.2
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for prime_vgem: Add mmap forwarding tests

== Series Details ==

== Series Details ==

Series: prime_vgem: Add mmap forwarding tests
URL : https://patchwork.freedesktop.org/series/124191/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13676 -> IGTPW_9863
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_9863 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_9863, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/index.html

Participating hosts (38 -> 38)
------------------------------

Additional (1): fi-ilk-650
Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_9863:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-dg1-5/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-dg1-5/igt@i915_selftest@[email protected]
- fi-skl-guc: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/fi-skl-guc/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/fi-skl-guc/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_9863 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3@lmem0:
- bat-atsm-1: NOTRUN -> [DMESG-WARN][5] ([i915#8841]) +4 other tests dmesg-warn
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-atsm-1/igt@gem_exec_suspend@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-ilk-650: NOTRUN -> [SKIP][6] ([fdo#109271]) +21 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/fi-ilk-650/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#6645])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-atsm-1/igt@[email protected]

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271]) +12 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/fi-hsw-4770/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][9] -> [ABORT][10] ([i915#8668])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlm-1: NOTRUN -> [SKIP][11] ([i915#1845])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-adlm-1/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#1836])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-atsm-1/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-vga-1:
- fi-hsw-4770: NOTRUN -> [DMESG-WARN][13] ([i915#8841]) +6 other tests dmesg-warn
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/fi-hsw-4770/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1072]) +3 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [DMESG-FAIL][15] ([i915#5334]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [INCOMPLETE][17] ([i915#7609] / [i915#7913]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@hangcheck:
- bat-atsm-1: [INCOMPLETE][19] ([i915#7913]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-atsm-1/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-atsm-1/igt@i915_selftest@[email protected]
- bat-dg2-9: [ABORT][21] ([i915#7913]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-dg2-9/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-dg2-9/igt@i915_selftest@[email protected]
- bat-adlm-1: [INCOMPLETE][23] -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-adlm-1/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-adlm-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-adlp-9: [INCOMPLETE][25] ([i915#7913]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-adlp-9/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-adlp-9/igt@i915_selftest@[email protected]

* igt@kms_chamelium_edid@hdmi-edid-read:
- {bat-dg2-13}: [DMESG-WARN][27] ([i915#7952]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13676/bat-dg2-13/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/bat-dg2-13/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7952]: https://gitlab.freedesktop.org/drm/intel/issues/7952
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7501 -> IGTPW_9863

CI-20190529: 20190529
CI_DRM_13676: ac2a5eb0159954ef31edf33ac4346e7153b883f5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9863: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/index.html
IGT_7501: f95083bb410e7a5521cca9c6908760a2de6f6591 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

+igt@prime_vgem@forwarded-uc
+igt@prime_vgem@forwarded-wb
+igt@prime_vgem@forwarded-wc

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/index.html

#2 lore raw

[igt-dev] ✓ CI.xeBAT: success for prime_vgem: Add mmap forwarding tests

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: prime_vgem: Add mmap forwarding tests
URL : https://patchwork.freedesktop.org/series/124191/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7501_BAT -> XEIGTPW_9863_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (4 -> 4)
------------------------------

No changes in participating hosts

Changes
-------

No changes found

Build changes
-------------

* IGT: IGT_7501 -> IGTPW_9863

IGTPW_9863: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9863/index.html
IGT_7501: f95083bb410e7a5521cca9c6908760a2de6f6591 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-394-6378241543c29ce3a7df5828323f1684b4bb19e3: 6378241543c29ce3a7df5828323f1684b4bb19e3

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_9863/index.html

#3 lore raw

[Intel-gfx] ✗ Fi.CI.BUILD: failure for prime_vgem: Add mmap forwarding tests

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: prime_vgem: Add mmap forwarding tests
URL : https://patchwork.freedesktop.org/series/124192/
State : failure

== Summary ==

Error: patch https://patchwork.freedesktop.org/api/1.0/series/124192/revisions/1/mbox/ not applied
Applying: prime_vgem: Add mmap forwarding tests
error: sha1 information is lacking or useless (tests/prime_vgem.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 prime_vgem: Add mmap forwarding tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Build failed, no error log produced