Skip to contentSkip to conversation

ASoC: cs35l56: Disable low-power hibernation mode

PATCH In review Richard Fitzgerald 2 participants 2 messages Sep 25, 2023 – Sep 28, 2023 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: cs35l56: Disable low-power hibernation mode

commit 18789be8e0d9fbb78b2290dcf93f500726ed19f0 upstream. Please apply to 6.4 and 6.5.

Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI and SoundWire.

Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake.

Backport note: This is the same change as upstream commit, to delete one line, but the upstream commit would not apply cleanly on older branches because of minor differences to the surrounding code.

---
 sound/soc/codecs/cs35l56-i2c.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/cs35l56-i2c.c +0 -1
index c613a2554fa3..494adabd4f43 100644
@@ -27,7 +27,6 @@ static int cs35l56_i2c_probe(struct i2c_client *client)
 		return -ENOMEM;
 
 	cs35l56->dev = dev;
-	cs35l56->can_hibernate = true;
 
 	i2c_set_clientdata(client, cs35l56);
 	cs35l56->regmap = devm_regmap_init_i2c(client, regmap_config);
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 7 lines · Richard Fitzgerald

commit 18789be8e0d9fbb78b2290dcf93f500726ed19f0 upstream. Please apply to 6.4 and 6.5.

Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI and SoundWire.

Quoted 7 lines

Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake.

Backport note: This is the same change as upstream commit, to delete one line, but the upstream commit would not apply cleanly on older branches because of minor differences to the surrounding code.

Queued up for 6.5. 6.4 is EOL.

Signature · 2 lines
Thanks,
Sasha