Skip to contentSkip to conversation

ASoC: dt-bindings: rt5616: Convert to dtschema

PATCH Superseded Bragatheswaran Manickavel 2 participants 3 messages Sep 25, 2023 – Sep 29, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: rt5616: Convert to dtschema

Convert the rt5616 audio CODEC bindings to DT schema No error/warning seen when running make dt_binding_check

---
 .../bindings/sound/realtek,rt5616.yaml        | 53 +++++++++++++++++++
 .../devicetree/bindings/sound/rt5616.txt      | 32 -----------
 2 files changed, 53 insertions(+), 32 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5616.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +53 -0
new file mode 100644
index 000000000000..00ff9b4e3c7e
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek rt5616 ALSA SoC audio codec driver
+
+description: |
+  Pins on the device (for linking into audio routes) for RT5616:
+
+      * IN1P
+      * IN2P
+      * IN2N
+      * LOUTL
+      * LOUTR
+      * HPOL
+      * HPOR
+
+maintainers:
+  - Bard Liao <[email protected]>
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: realtek,rt5616
+
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - '#sound-dai-cells'
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        codec@1b {
+            compatible = "realtek,rt5616";
+            reg = <0x1b>;
+            #sound-dai-cells = <0>;
+        };
+    };
Documentation/devicetree/bindings/sound/rt5616.txt deleted +0 -32
deleted file mode 100644
index 540a4bf252e4..000000000000
@@ -1,32 +0,0 @@
-RT5616 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-- compatible : "realtek,rt5616".
-
-- reg : The I2C address of the device.
-
-Optional properties:
-
-- clocks: The phandle of the master clock to the CODEC.
-
-- clock-names: Should be "mclk".
-
-Pins on the device (for linking into audio routes) for RT5616:
-
-  * IN1P
-  * IN2P
-  * IN2N
-  * LOUTL
-  * LOUTR
-  * HPOL
-  * HPOR
-
-Example:
-
-rt5616: codec@1b {
-	compatible = "realtek,rt5616";
-	reg = <0x1b>;
-};
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 3 lines · Bragatheswaran Manickavel

Convert the rt5616 audio CODEC bindings to DT schema

No error/warning seen when running make dt_binding_check

No need to say that. That's the assumption and it should never get applied if not.

Quoted 44 lines
---
 .../bindings/sound/realtek,rt5616.yaml        | 53 +++++++++++++++++++
 .../devicetree/bindings/sound/rt5616.txt      | 32 -----------
 2 files changed, 53 insertions(+), 32 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5616.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +29 -0
new file mode 100644
index 000000000000..00ff9b4e3c7e
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek rt5616 ALSA SoC audio codec driver
+
+description: |
+  Pins on the device (for linking into audio routes) for RT5616:
+
+      * IN1P
+      * IN2P
+      * IN2N
+      * LOUTL
+      * LOUTR
+      * HPOL
+      * HPOR
+
+maintainers:
+  - Bard Liao <[email protected]>
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: realtek,rt5616
+

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml line 39

Quoted 10 lines
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +10 -0
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - '#sound-dai-cells'

This was not in the original doc. Was that an error? If so, just state that in the commit msg.

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml line 47

Quoted 8 lines
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +8 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;

blank line

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml line 48

Quoted 1 line
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +1 -0
+        codec@1b {

audio-codec@1b

Quoted 5 lines
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +5 -0
+            compatible = "realtek,rt5616";
+            reg = <0x1b>;
+            #sound-dai-cells = <0>;
+        };
+    };
#2 lore raw
Quoted 53 lines · Rob Herring
Quoted 2 lines · Bragatheswaran Manickavel

Convert the rt5616 audio CODEC bindings to DT schema No error/warning seen when running make dt_binding_check

No need to say that. That's the assumption and it should never get applied if not.

Quoted 47 lines
---
  .../bindings/sound/realtek,rt5616.yaml        | 53 +++++++++++++++++++
  .../devicetree/bindings/sound/rt5616.txt      | 32 -----------
  2 files changed, 53 insertions(+), 32 deletions(-)

create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5616.yaml delete mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +33 -0
new file mode 100644
index 000000000000..00ff9b4e3c7e
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek rt5616 ALSA SoC audio codec driver
+
+description: |
+  Pins on the device (for linking into audio routes) for RT5616:
+
+      * IN1P
+      * IN2P
+      * IN2N
+      * LOUTL
+      * LOUTR
+      * HPOL
+      * HPOR
+
+maintainers:
+  - Bard Liao <[email protected]>
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: realtek,rt5616
+
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
Quoted 8 lines

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml line 39

Quoted 6 lines
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +6 -0
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - '#sound-dai-cells'

This was not in the original doc. Was that an error? If so, just state that in the commit msg.

Its was added by me. Will remove it

Quoted 10 lines

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml line 47

Quoted 8 lines
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +8 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;

blank line

Quoted 8 lines

Documentation/devicetree/bindings/sound/realtek,rt5616.yaml line 48

Quoted 1 line
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +1 -0
+        codec@1b {

audio-codec@1b

Quoted 5 lines
Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file +5 -0
+            compatible = "realtek,rt5616";
+            reg = <0x1b>;
+            #sound-dai-cells = <0>;
+        };
+    };

Will make these changes and send a new patch

Thanks,

Bragathe