Skip to contentSkip to conversation

spi: dt-bindings: Make "additionalProperties: true" explicit

PATCH In review Rob Herring 6 participants 6 messages Sep 25, 2023 – Oct 5, 2023

Subsystems (5)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 spi: dt-bindings: Make "additionalProperties: true" explicit

Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.

---
 .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml        | 2 ++
 .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml        | 2 ++
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml         | 2 ++
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml      | 2 ++
 5 files changed, 9 insertions(+)
Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml +2 -0
index a6f34bdd1d3c..e1ab3f523ad6 100644
@@ -46,6 +46,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml +2 -0
index 28b8ace63044..3b47b68b92cb 100644
@@ -68,6 +68,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +1 -0
index 9ae1611175f2..48e97e240265 100644
@@ -50,6 +50,7 @@ properties:
 patternProperties:
   "@[0-9a-f]+$":
     type: object
+    additionalProperties: true
 
     properties:
       spi-rx-bus-width:
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +2 -0
index 339fb39529f3..ac1503de0478 100644
@@ -47,6 +47,8 @@ properties:
 patternProperties:
   "^flash@[0-3]$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml +2 -0
index a47cb144b09f..6348a387a21c 100644
@@ -160,6 +160,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Signature · 1 line
2.40.1
maintainer Acked-by on v1 1/1
#1 lore raw

Dne ponedeljek, 25. september 2023 ob 23:26:00 CEST je Rob Herring napisal(a):

Quoted 8 lines

Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.

---
 .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml        | 2 ++
 .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml        | 2 ++

For Allwinner:

Best regards,
Jernej

Quoted 70 lines
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml         | 2 ++
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml      | 2 ++
 5 files changed, 9 insertions(+)
Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml +2 -0
index a6f34bdd1d3c..e1ab3f523ad6 100644
@@ -46,6 +46,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml +2 -0
index 28b8ace63044..3b47b68b92cb 100644
@@ -68,6 +68,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +1 -0
index 9ae1611175f2..48e97e240265 100644
@@ -50,6 +50,7 @@ properties:
 patternProperties:
   "@[0-9a-f]+$":
     type: object
+    additionalProperties: true
 
     properties:
       spi-rx-bus-width:
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +2 -0
index 339fb39529f3..ac1503de0478 100644
@@ -47,6 +47,8 @@ properties:
 patternProperties:
   "^flash@[0-3]$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml +2 -0
index a47cb144b09f..6348a387a21c 100644
@@ -160,6 +160,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.

For the DW APB/AHB SSI bindings:

-Serge(y)

Quoted 75 lines
---
 .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml        | 2 ++
 .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml        | 2 ++
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml         | 2 ++
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml      | 2 ++
 5 files changed, 9 insertions(+)
Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml +2 -0
index a6f34bdd1d3c..e1ab3f523ad6 100644
@@ -46,6 +46,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml +2 -0
index 28b8ace63044..3b47b68b92cb 100644
@@ -68,6 +68,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +1 -0
index 9ae1611175f2..48e97e240265 100644
@@ -50,6 +50,7 @@ properties:
 patternProperties:
   "@[0-9a-f]+$":
     type: object
+    additionalProperties: true
 
     properties:
       spi-rx-bus-width:
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +2 -0
index 339fb39529f3..ac1503de0478 100644
@@ -47,6 +47,8 @@ properties:
 patternProperties:
   "^flash@[0-3]$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml +2 -0
index a47cb144b09f..6348a387a21c 100644
@@ -160,6 +160,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Signature · 1 line
2.40.1
maintainer
#3 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: dt-bindings: Make "additionalProperties: true" explicit

      commit: 9f778f377cd3b8d6699025ea75732ca91a239cd1

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Acked-by on v1 1/1
#4 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.

Thanks,
Conor.

Quoted 75 lines
---
 .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml        | 2 ++
 .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml        | 2 ++
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml         | 2 ++
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml      | 2 ++
 5 files changed, 9 insertions(+)
Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml +2 -0
index a6f34bdd1d3c..e1ab3f523ad6 100644
@@ -46,6 +46,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml +2 -0
index 28b8ace63044..3b47b68b92cb 100644
@@ -68,6 +68,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +1 -0
index 9ae1611175f2..48e97e240265 100644
@@ -50,6 +50,7 @@ properties:
 patternProperties:
   "@[0-9a-f]+$":
     type: object
+    additionalProperties: true
 
     properties:
       spi-rx-bus-width:
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +2 -0
index 339fb39529f3..ac1503de0478 100644
@@ -47,6 +47,8 @@ properties:
 patternProperties:
   "^flash@[0-3]$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml +2 -0
index a47cb144b09f..6348a387a21c 100644
@@ -160,6 +160,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0
Signature · 1 line
2.40.1
maintainer Acked-by on v1 1/1
#5 lore raw
In reply to Rob Herring

Am Montag, 25. September 2023, 23:26:00 CEST schrieb Rob Herring:

Quoted 13 lines

Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.

---
 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml         | 2 ++
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +0 -0
index 339fb39529f3..ac1503de0478 100644

Documentation/devicetree/bindings/spi/rockchip-sfc.yaml properties: · line 54

Quoted 8 lines
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +2 -0
@@ -47,6 +47,8 @@ properties:
 patternProperties:
   "^flash@[0-3]$":
     type: object
+    additionalProperties: true
+
     properties:
       reg:
         minimum: 0

For rockchip-sfc:

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip