Skip to contentSkip to conversation

dt-bindings: remoteproc: mtk,scp: Add missing additionalProperties on child node schemas

PATCH In review Rob Herring 4 participants 5 messages Sep 26, 2023 – Sep 28, 2023

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: remoteproc: mtk,scp: Add missing additionalProperties on child node schemas

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.

---
 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +1 -0
index 895415772d1d..24422fd56e83 100644
@@ -91,6 +91,7 @@ allOf:
 
 additionalProperties:
   type: object
+  additionalProperties: false
   description:
     Subnodes of the SCP represent rpmsg devices. The names of the devices
     are not important. The properties of these nodes are defined by the
Signature · 1 line
2.40.1
Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 7 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.

---

Quoted 18 lines
 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +1 -0
index 895415772d1d..24422fd56e83 100644
@@ -91,6 +91,7 @@ allOf:
 
 additionalProperties:
   type: object
+  additionalProperties: false
   description:
     Subnodes of the SCP represent rpmsg devices. The names of the devices
     are not important. The properties of these nodes are defined by the
Signature · 1 line
2.40.1
maintainer
#3 lore raw
In reply to Rob Herring

Hi Rob,

Quoted 15 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.

---
 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +0 -0
index 895415772d1d..24422fd56e83 100644

Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml allOf: · line 94

Quoted 4 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +1 -0
@@ -91,6 +91,7 @@ allOf:
 
 additionalProperties:
   type: object
+  additionalProperties: false

Things have changed in the remoteproc tree [1] and this patch doesn't apply. Please see if it is still needed.

Thanks,
Mathieu

[1]. https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/tree/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml?h=rproc-next#n80

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +0 -0
   description:
     Subnodes of the SCP represent rpmsg devices. The names of the devices
     are not important. The properties of these nodes are defined by the
Signature · 1 line
2.40.1
author maintainer
#4 lore raw
Quoted 20 lines · Mathieu Poirier

Hi Rob,

Quoted 16 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.

---
 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +0 -0
index 895415772d1d..24422fd56e83 100644
@@ -91,6 +91,7 @@ allOf:
 
Quoted 6 lines

Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml allOf: · line 94

Quoted 3 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +1 -0
 additionalProperties:
   type: object
+  additionalProperties: false

Things have changed in the remoteproc tree [1] and this patch doesn't apply. Please see if it is still needed.

It is not needed any more.

Thanks,
Rob