Skip to contentSkip to conversation

perf intel-pt: Fix async branch flags

PATCH Applied Adrian Hunter 2 participants 3 messages Sep 28, 2023 – Oct 3, 2023 perf events

lore
Share & tools
lore

Adrian Hunter

author reviewer
#0 lore raw

PATCH 1/1 perf intel-pt: Fix async branch flags

Ensure PERF_IP_FLAG_ASYNC is set always for asynchronous branches (i.e. interrupts etc).

Fixes 90e457f7be08 ("perf tools: Add Intel PT support")
---
 tools/perf/util/intel-pt.c | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/util/intel-pt.c +2 -0
index dbf0bc71a63b..f38893e0b036 100644
@@ -1512,9 +1512,11 @@ static void intel_pt_sample_flags(struct intel_pt_queue *ptq)
 	} else if (ptq->state->flags & INTEL_PT_ASYNC) {
 		if (!ptq->state->to_ip)
 			ptq->flags = PERF_IP_FLAG_BRANCH |
+				     PERF_IP_FLAG_ASYNC |
 				     PERF_IP_FLAG_TRACE_END;
 		else if (ptq->state->from_nr && !ptq->state->to_nr)
 			ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
+				     PERF_IP_FLAG_ASYNC |
 				     PERF_IP_FLAG_VMEXIT;
 		else
 			ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
Signature · 1 line
2.34.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Adrian Hunter

Ensure PERF_IP_FLAG_ASYNC is set always for asynchronous branches (i.e. interrupts etc).

Fixes 90e457f7be08 ("perf tools: Add Intel PT support")

Thanks,
Namhyung

Quoted 24 lines
---
 tools/perf/util/intel-pt.c | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/util/intel-pt.c +2 -1
index dbf0bc71a63b..f38893e0b036 100644
@@ -1512,9 +1512,11 @@ static void intel_pt_sample_flags(struct intel_pt_queue *ptq)
        } else if (ptq->state->flags & INTEL_PT_ASYNC) {
                if (!ptq->state->to_ip)
                        ptq->flags = PERF_IP_FLAG_BRANCH |
+                                    PERF_IP_FLAG_ASYNC |
                                     PERF_IP_FLAG_TRACE_END;
                else if (ptq->state->from_nr && !ptq->state->to_nr)
                        ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
+                                    PERF_IP_FLAG_ASYNC |
                                     PERF_IP_FLAG_VMEXIT;
                else
                        ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
--

2.34.1