ARM: dts: mxs: Use dma-controller as node name
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 ARM: dts: mxs: Use dma-controller as node name
From: Fabio Estevam <[email protected]>
Devicetree nodes should be generic.
Use 'dma-controller' as node names to fix the following schema warnings:
dma-apbx@80024000: $nodename:0: 'dma-apbx@80024000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
--- arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 2 +- arch/arm/boot/dts/nxp/mxs/imx28.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/nxp/mxs/imx23.dtsi +1 -1
@@ -412,7 +412,7 @@ emi@80020000 { status = "disabled"; }; - dma_apbx: dma-apbx@80024000 { + dma_apbx: dma-controller@80024000 { compatible = "fsl,imx23-dma-apbx"; reg = <0x80024000 0x2000>; interrupts = <7>, <5>, <9>, <26>,
arch/arm/boot/dts/nxp/mxs/imx28.dtsi +1 -1
@@ -990,7 +990,7 @@ etm: etm@80022000 { status = "disabled"; }; - dma_apbx: dma-apbx@80024000 { + dma_apbx: dma-controller@80024000 { compatible = "fsl,imx28-dma-apbx"; reg = <0x80024000 0x2000>; interrupts = <78>, <79>, <66>, <0>,
Signature · 7 lines
2.34.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerPATCH 2/2 ARM: dts: imx23: Remove dma interrupt-names
From: Fabio Estevam <[email protected]>
Per fsl,mxs-dma.yaml, 'interrupt-names' is not a valid property.
Remove it to fix the following schema warning:
dma-apbx@80024000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
--- arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 4 ---- 1 file changed, 4 deletions(-)
arch/arm/boot/dts/nxp/mxs/imx23.dtsi +0 -4
@@ -419,10 +419,6 @@ dma_apbx: dma-controller@80024000 { <19>, <0>, <25>, <23>, <60>, <58>, <9>, <0>, <0>, <0>, <0>, <0>; - interrupt-names = "audio-adc", "audio-dac", "spdif-tx", "i2c", - "saif0", "empty", "auart0-rx", "auart0-tx", - "auart1-rx", "auart1-tx", "saif1", "empty", - "empty", "empty", "empty", "empty"; #dma-cells = <1>; dma-channels = <16>; clocks = <&clks 16>;
Signature · 7 lines
2.34.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names
Hi Fabio,
Am 02.10.23 um 02:32 schrieb Fabio Estevam:
Quoted 19 lines
From: Fabio Estevam <[email protected]>
Per fsl,mxs-dma.yaml, 'interrupt-names' is not a valid property.
Remove it to fix the following schema warning:
dma-apbx@80024000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 4 ---- 1 file changed, 4 deletions(-)arch/arm/boot/dts/nxp/mxs/imx23.dtsi +0
-0
arch/arm/boot/dts/nxp/mxs/imx23.dtsi dma_apbx: dma-controller@80024000 { · line 425
Quoted 7 lines
arch/arm/boot/dts/nxp/mxs/imx23.dtsi +0
-4@@ -419,10 +419,6 @@ dma_apbx: dma-controller@80024000 { <19>, <0>, <25>, <23>, <60>, <58>, <9>, <0>, <0>, <0>, <0>, <0>; - interrupt-names = "audio-adc", "audio-dac", "spdif-tx", "i2c", - "saif0", "empty", "auart0-rx", "auart0-tx", - "auart1-rx", "auart1-tx", "saif1", "empty", - "empty", "empty", "empty", "empty";
dropping these useful information looks wrong to me and also there is a chance to break possible users beside Mainline Linux. I would prefer to fix the schema by making interrupt-names optional.
Best regards
arch/arm/boot/dts/nxp/mxs/imx23.dtsi dma_apbx: dma-controller@80024000 { · line 424
Quoted 3 lines
arch/arm/boot/dts/nxp/mxs/imx23.dtsi +0
-0#dma-cells = <1>; dma-channels = <16>; clocks = <&clks 16>;
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Am 02.10.23 um 02:32 schrieb Fabio Estevam:
Quoted 11 lines
From: Fabio Estevam <[email protected]>
Devicetree nodes should be generic.
Use 'dma-controller' as node names to fix the following schema warnings:
dma-apbx@80024000: $nodename:0: 'dma-apbx@80024000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
Signed-off-by Fabio Estevam <[email protected]>
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel