Skip to contentSkip to conversation

scsi: ufs: ufs-pci: Switch to use acpi_evaluate_dsm_typed()

PATCH Applied Andy Shevchenko 3 participants 4 messages Oct 2, 2023 – Oct 13, 2023 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: ufs-pci: Switch to use acpi_evaluate_dsm_typed()

The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant.

---
 drivers/ufs/host/ufshcd-pci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/ufs/host/ufshcd-pci.c +3 -2
index 248a49e5e7f3..0aca666d2199 100644
@@ -58,11 +58,12 @@ static int __intel_dsm(struct intel_host *intel_host, struct device *dev,
 	int err = 0;
 	size_t len;
 
-	obj = acpi_evaluate_dsm(ACPI_HANDLE(dev), &intel_dsm_guid, 0, fn, NULL);
+	obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(dev), &intel_dsm_guid, 0, fn, NULL,
+				      ACPI_TYPE_BUFFER);
 	if (!obj)
 		return -EOPNOTSUPP;
 
-	if (obj->type != ACPI_TYPE_BUFFER || obj->buffer.length < 1) {
+	if (obj->buffer.length < 1) {
 		err = -EINVAL;
 		goto out;
 	}
Signature · 1 line
2.40.0.1.gaa8946217a0b
#2 lore raw
In reply to Andy Shevchenko

Andy,

Quoted 2 lines

The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant.

Applied to 6.7/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering