Skip to contentSkip to conversation

perf intel-pt: pkt-decoder: Fix alignment issues

PATCH In review Ian Rogers 3 participants 10 messages Oct 2, 2023 – Oct 13, 2023 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf intel-pt: pkt-decoder: Fix alignment issues

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

---
 .../intel-pt-decoder/intel-pt-pkt-decoder.c   | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +14 -7
index af9710622a1f..28659874d84e 100644
@@ -83,7 +83,7 @@ static int intel_pt_get_long_tnt(const unsigned char *buf, size_t len,
 	if (len < 8)
 		return INTEL_PT_NEED_MORE_BYTES;
 
-	payload = le64_to_cpu(*(uint64_t *)buf);
+	memcpy_le64(&payload, buf, sizeof(payload));
 
 	for (count = 47; count; count--) {
 		if (payload & BIT63)
@@ -220,6 +220,8 @@ static int intel_pt_get_3byte(const unsigned char *buf, size_t len,
 static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
 				struct intel_pt_pkt *packet)
 {
+	uint32_t tmp;
+
 	packet->count = (buf[1] >> 5) & 0x3;
 	packet->type = buf[1] & BIT(7) ? INTEL_PT_PTWRITE_IP :
 					 INTEL_PT_PTWRITE;
@@ -228,12 +230,13 @@ static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
 	case 0:
 		if (len < 6)
 			return INTEL_PT_NEED_MORE_BYTES;
-		packet->payload = le32_to_cpu(*(uint32_t *)(buf + 2));
+		memcpy(&tmp, buf + 2, sizeof(tmp));
+		packet->payload = le32_to_cpu(tmp);
 		return 6;
 	case 1:
 		if (len < 10)
 			return INTEL_PT_NEED_MORE_BYTES;
-		packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+		memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
 		return 10;
 	default:
 		return INTEL_PT_BAD_PACKET;
@@ -258,7 +261,7 @@ static int intel_pt_get_mwait(const unsigned char *buf, size_t len,
 	if (len < 10)
 		return INTEL_PT_NEED_MORE_BYTES;
 	packet->type = INTEL_PT_MWAIT;
-	packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+	memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
 	return 10;
 }
 
@@ -454,6 +457,8 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
 			   struct intel_pt_pkt *packet)
 {
 	int ip_len;
+	uint16_t tmp16;
+	uint32_t tmp32;
 
 	packet->count = byte >> 5;
 
@@ -465,13 +470,15 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
 		if (len < 3)
 			return INTEL_PT_NEED_MORE_BYTES;
 		ip_len = 2;
-		packet->payload = le16_to_cpu(*(uint16_t *)(buf + 1));
+		memcpy(&tmp16, buf + 1, sizeof(tmp16));
+		packet->payload = le16_to_cpu(tmp16);
 		break;
 	case 2:
 		if (len < 5)
 			return INTEL_PT_NEED_MORE_BYTES;
 		ip_len = 4;
-		packet->payload = le32_to_cpu(*(uint32_t *)(buf + 1));
+		memcpy(&tmp32, buf + 1, sizeof(tmp32));
+		packet->payload = le32_to_cpu(tmp32);
 		break;
 	case 3:
 	case 4:
@@ -484,7 +491,7 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
 		if (len < 9)
 			return INTEL_PT_NEED_MORE_BYTES;
 		ip_len = 8;
-		packet->payload = le64_to_cpu(*(uint64_t *)(buf + 1));
+		memcpy_le64(&packet->payload, buf + 1, sizeof(packet->payload));
 		break;
 	default:
 		return INTEL_PT_BAD_PACKET;
Signature · 1 line
2.42.0.582.g8ccd20d70d-goog
author reviewer
#1 lore raw
Quoted 8 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks,
Ian

Quoted 89 lines
 .../intel-pt-decoder/intel-pt-pkt-decoder.c   | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +14 -8
index af9710622a1f..28659874d84e 100644
@@ -83,7 +83,7 @@ static int intel_pt_get_long_tnt(const unsigned char *buf, size_t len,
        if (len < 8)
                return INTEL_PT_NEED_MORE_BYTES;
 
-       payload = le64_to_cpu(*(uint64_t *)buf);
+       memcpy_le64(&payload, buf, sizeof(payload));
 
        for (count = 47; count; count--) {
                if (payload & BIT63)
@@ -220,6 +220,8 @@ static int intel_pt_get_3byte(const unsigned char *buf, size_t len,
 static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
                                struct intel_pt_pkt *packet)
 {
+       uint32_t tmp;
+
        packet->count = (buf[1] >> 5) & 0x3;
        packet->type = buf[1] & BIT(7) ? INTEL_PT_PTWRITE_IP :
                                         INTEL_PT_PTWRITE;
@@ -228,12 +230,13 @@ static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
        case 0:
                if (len < 6)
                        return INTEL_PT_NEED_MORE_BYTES;
-               packet->payload = le32_to_cpu(*(uint32_t *)(buf + 2));
+               memcpy(&tmp, buf + 2, sizeof(tmp));
+               packet->payload = le32_to_cpu(tmp);
                return 6;
        case 1:
                if (len < 10)
                        return INTEL_PT_NEED_MORE_BYTES;
-               packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+               memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
                return 10;
        default:
                return INTEL_PT_BAD_PACKET;
@@ -258,7 +261,7 @@ static int intel_pt_get_mwait(const unsigned char *buf, size_t len,
        if (len < 10)
                return INTEL_PT_NEED_MORE_BYTES;
        packet->type = INTEL_PT_MWAIT;
-       packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+       memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
        return 10;
 }
 
@@ -454,6 +457,8 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                           struct intel_pt_pkt *packet)
 {
        int ip_len;
+       uint16_t tmp16;
+       uint32_t tmp32;
 
        packet->count = byte >> 5;
 
@@ -465,13 +470,15 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                if (len < 3)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 2;
-               packet->payload = le16_to_cpu(*(uint16_t *)(buf + 1));
+               memcpy(&tmp16, buf + 1, sizeof(tmp16));
+               packet->payload = le16_to_cpu(tmp16);
                break;
        case 2:
                if (len < 5)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 4;
-               packet->payload = le32_to_cpu(*(uint32_t *)(buf + 1));
+               memcpy(&tmp32, buf + 1, sizeof(tmp32));
+               packet->payload = le32_to_cpu(tmp32);
                break;
        case 3:
        case 4:
@@ -484,7 +491,7 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                if (len < 9)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 8;
-               packet->payload = le64_to_cpu(*(uint64_t *)(buf + 1));
+               memcpy_le64(&packet->payload, buf + 1, sizeof(packet->payload));
                break;
        default:
                return INTEL_PT_BAD_PACKET;
--

2.42.0.582.g8ccd20d70d-goog

reviewer
#2 lore raw
Quoted 7 lines · Ian Rogers
Quoted 6 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

Quoted 6 lines
Quoted 2 lines

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Quoted 93 lines

Thanks,
Ian

Quoted 89 lines
 .../intel-pt-decoder/intel-pt-pkt-decoder.c   | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +14 -8
index af9710622a1f..28659874d84e 100644
@@ -83,7 +83,7 @@ static int intel_pt_get_long_tnt(const unsigned char *buf, size_t len,
        if (len < 8)
                return INTEL_PT_NEED_MORE_BYTES;
 
-       payload = le64_to_cpu(*(uint64_t *)buf);
+       memcpy_le64(&payload, buf, sizeof(payload));
 
        for (count = 47; count; count--) {
                if (payload & BIT63)
@@ -220,6 +220,8 @@ static int intel_pt_get_3byte(const unsigned char *buf, size_t len,
 static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
                                struct intel_pt_pkt *packet)
 {
+       uint32_t tmp;
+
        packet->count = (buf[1] >> 5) & 0x3;
        packet->type = buf[1] & BIT(7) ? INTEL_PT_PTWRITE_IP :
                                         INTEL_PT_PTWRITE;
@@ -228,12 +230,13 @@ static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
        case 0:
                if (len < 6)
                        return INTEL_PT_NEED_MORE_BYTES;
-               packet->payload = le32_to_cpu(*(uint32_t *)(buf + 2));
+               memcpy(&tmp, buf + 2, sizeof(tmp));
+               packet->payload = le32_to_cpu(tmp);
                return 6;
        case 1:
                if (len < 10)
                        return INTEL_PT_NEED_MORE_BYTES;
-               packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+               memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
                return 10;
        default:
                return INTEL_PT_BAD_PACKET;
@@ -258,7 +261,7 @@ static int intel_pt_get_mwait(const unsigned char *buf, size_t len,
        if (len < 10)
                return INTEL_PT_NEED_MORE_BYTES;
        packet->type = INTEL_PT_MWAIT;
-       packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+       memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
        return 10;
 }
 
@@ -454,6 +457,8 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                           struct intel_pt_pkt *packet)
 {
        int ip_len;
+       uint16_t tmp16;
+       uint32_t tmp32;
 
        packet->count = byte >> 5;
 
@@ -465,13 +470,15 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                if (len < 3)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 2;
-               packet->payload = le16_to_cpu(*(uint16_t *)(buf + 1));
+               memcpy(&tmp16, buf + 1, sizeof(tmp16));
+               packet->payload = le16_to_cpu(tmp16);
                break;
        case 2:
                if (len < 5)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 4;
-               packet->payload = le32_to_cpu(*(uint32_t *)(buf + 1));
+               memcpy(&tmp32, buf + 1, sizeof(tmp32));
+               packet->payload = le32_to_cpu(tmp32);
                break;
        case 3:
        case 4:
@@ -484,7 +491,7 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                if (len < 9)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 8;
-               packet->payload = le64_to_cpu(*(uint64_t *)(buf + 1));
+               memcpy_le64(&packet->payload, buf + 1, sizeof(packet->payload));
                break;
        default:
                return INTEL_PT_BAD_PACKET;
--

2.42.0.582.g8ccd20d70d-goog

author reviewer
#3 lore raw
Quoted 12 lines · Adrian Hunter
Quoted 10 lines · Ian Rogers
Quoted 8 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

---

Quoted 7 lines
Quoted 3 lines

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

Ian

Quoted 94 lines
Quoted 93 lines

Thanks,
Ian

Quoted 89 lines
 .../intel-pt-decoder/intel-pt-pkt-decoder.c   | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +14 -8
index af9710622a1f..28659874d84e 100644
@@ -83,7 +83,7 @@ static int intel_pt_get_long_tnt(const unsigned char *buf, size_t len,
        if (len < 8)
                return INTEL_PT_NEED_MORE_BYTES;
 
-       payload = le64_to_cpu(*(uint64_t *)buf);
+       memcpy_le64(&payload, buf, sizeof(payload));
 
        for (count = 47; count; count--) {
                if (payload & BIT63)
@@ -220,6 +220,8 @@ static int intel_pt_get_3byte(const unsigned char *buf, size_t len,
 static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
                                struct intel_pt_pkt *packet)
 {
+       uint32_t tmp;
+
        packet->count = (buf[1] >> 5) & 0x3;
        packet->type = buf[1] & BIT(7) ? INTEL_PT_PTWRITE_IP :
                                         INTEL_PT_PTWRITE;
@@ -228,12 +230,13 @@ static int intel_pt_get_ptwrite(const unsigned char *buf, size_t len,
        case 0:
                if (len < 6)
                        return INTEL_PT_NEED_MORE_BYTES;
-               packet->payload = le32_to_cpu(*(uint32_t *)(buf + 2));
+               memcpy(&tmp, buf + 2, sizeof(tmp));
+               packet->payload = le32_to_cpu(tmp);
                return 6;
        case 1:
                if (len < 10)
                        return INTEL_PT_NEED_MORE_BYTES;
-               packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+               memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
                return 10;
        default:
                return INTEL_PT_BAD_PACKET;
@@ -258,7 +261,7 @@ static int intel_pt_get_mwait(const unsigned char *buf, size_t len,
        if (len < 10)
                return INTEL_PT_NEED_MORE_BYTES;
        packet->type = INTEL_PT_MWAIT;
-       packet->payload = le64_to_cpu(*(uint64_t *)(buf + 2));
+       memcpy_le64(&packet->payload, buf + 2, sizeof(packet->payload));
        return 10;
 }
 
@@ -454,6 +457,8 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                           struct intel_pt_pkt *packet)
 {
        int ip_len;
+       uint16_t tmp16;
+       uint32_t tmp32;
 
        packet->count = byte >> 5;
 
@@ -465,13 +470,15 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                if (len < 3)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 2;
-               packet->payload = le16_to_cpu(*(uint16_t *)(buf + 1));
+               memcpy(&tmp16, buf + 1, sizeof(tmp16));
+               packet->payload = le16_to_cpu(tmp16);
                break;
        case 2:
                if (len < 5)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 4;
-               packet->payload = le32_to_cpu(*(uint32_t *)(buf + 1));
+               memcpy(&tmp32, buf + 1, sizeof(tmp32));
+               packet->payload = le32_to_cpu(tmp32);
                break;
        case 3:
        case 4:
@@ -484,7 +491,7 @@ static int intel_pt_get_ip(enum intel_pt_pkt_type type, unsigned int byte,
                if (len < 9)
                        return INTEL_PT_NEED_MORE_BYTES;
                ip_len = 8;
-               packet->payload = le64_to_cpu(*(uint64_t *)(buf + 1));
+               memcpy_le64(&packet->payload, buf + 1, sizeof(packet->payload));
                break;
        default:
                return INTEL_PT_BAD_PACKET;
--

2.42.0.582.g8ccd20d70d-goog

maintainer
#4 lore raw
Quoted 18 lines · Ian Rogers
Quoted 16 lines · Adrian Hunter
Quoted 13 lines · Ian Rogers
Quoted 8 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Quoted 6 lines
Quoted 3 lines

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

I think it can be done as a later step as long as the interface is the same. Can I add your Ack's to the Adrian's patchset?

Thanks,
Namhyung

author reviewer
#5 lore raw
Quoted 24 lines · Namhyung Kim
Quoted 22 lines · Ian Rogers
Quoted 19 lines · Adrian Hunter
Quoted 7 lines · Ian Rogers
Quoted 6 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

Quoted 6 lines
Quoted 2 lines

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Quoted 5 lines
Quoted 2 lines

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

I think it can be done as a later step as long as the interface is the same. Can I add your Ack's to the Adrian's patchset?

I think addressing Arnaldo's comment:
https://lore.kernel.org/lkml/[email protected]/
will need some changes to the patch series, and so I was waiting to see the outcome of that.

Thanks,
Ian

Quoted 2 lines

Thanks,
Namhyung

maintainer
#6 lore raw
Quoted 29 lines · Ian Rogers
Quoted 27 lines · Namhyung Kim
Quoted 24 lines · Ian Rogers
Quoted 12 lines · Adrian Hunter
Quoted 10 lines · Ian Rogers
Quoted 8 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

---

Quoted 7 lines
Quoted 3 lines

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

Quoted 7 lines
Quoted 2 lines

I think it can be done as a later step as long as the interface is the same. Can I add your Ack's to the Adrian's patchset?

I think addressing Arnaldo's comment:
https://lore.kernel.org/lkml/[email protected]/
will need some changes to the patch series, and so I was waiting to see the outcome of that.

It seems it's done without further changes. Can I get your Ack's now?

Thanks,
Namhyung

author reviewer
#7 lore raw
Quoted 34 lines · Namhyung Kim
Quoted 32 lines · Ian Rogers
Quoted 29 lines · Namhyung Kim
Quoted 18 lines · Ian Rogers
Quoted 16 lines · Adrian Hunter
Quoted 13 lines · Ian Rogers
Quoted 8 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Quoted 6 lines
Quoted 3 lines

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

I think it can be done as a later step as long as the interface is the same. Can I add your Ack's to the Adrian's patchset?

Quoted 6 lines
Quoted 4 lines

I think addressing Arnaldo's comment:
https://lore.kernel.org/lkml/[email protected]/
will need some changes to the patch series, and so I was waiting to see the outcome of that.

It seems it's done without further changes. Can I get your Ack's now?

With the unaligned.h patch on its own, I think patch 1 of 5 needs dropping. For the rest I'm happy to acked-by.

Thanks,
Ian

Quoted 2 lines

Thanks,
Namhyung

reviewer
#8 lore raw
Quoted 40 lines · Ian Rogers
Quoted 39 lines · Namhyung Kim
Quoted 36 lines · Ian Rogers
Quoted 24 lines · Namhyung Kim
Quoted 22 lines · Ian Rogers
Quoted 19 lines · Adrian Hunter
Quoted 7 lines · Ian Rogers
Quoted 6 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

Quoted 6 lines
Quoted 2 lines

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Quoted 5 lines
Quoted 2 lines

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

I think it can be done as a later step as long as the interface is the same. Can I add your Ack's to the Adrian's patchset?

I think addressing Arnaldo's comment:
https://lore.kernel.org/lkml/[email protected]/
will need some changes to the patch series, and so I was waiting to see the outcome of that.

Quoted 4 lines
Quoted 1 line

It seems it's done without further changes. Can I get your Ack's now?

With the unaligned.h patch on its own, I think patch 1 of 5 needs dropping. For the rest I'm happy to acked-by.

The new patch is on top of the others, so patch 1 is still needed.

maintainer
#9 lore raw
Quoted 42 lines · Adrian Hunter
Quoted 40 lines · Ian Rogers
Quoted 39 lines · Namhyung Kim
Quoted 36 lines · Ian Rogers
Quoted 24 lines · Namhyung Kim
Quoted 22 lines · Ian Rogers
Quoted 19 lines · Adrian Hunter
Quoted 7 lines · Ian Rogers
Quoted 6 lines · Ian Rogers

The byte aligned buffer is cast to large types and dereferenced causing misaligned pointer warnings from undefined behavior sanitizer. Fix the alignment issues with memcpy which may require the introduction of temporaries.

Quoted 6 lines
Quoted 2 lines

---

This is a relatively small change that fixes building with -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as this is Intel-PT could you take a look?

Thanks! This has been down my list of things to do for ages, but using get_unaligned_le16() etc seems nicer. I sent a patch set for that.

Quoted 5 lines
Quoted 2 lines

Thanks Adrian! Your patch set looks good and I think after Arnaldo's comment is addressed we should go with it.

I think it can be done as a later step as long as the interface is the same. Can I add your Ack's to the Adrian's patchset?

I think addressing Arnaldo's comment:
https://lore.kernel.org/lkml/[email protected]/
will need some changes to the patch series, and so I was waiting to see the outcome of that.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

It seems it's done without further changes. Can I get your Ack's now?

With the unaligned.h patch on its own, I think patch 1 of 5 needs dropping. For the rest I'm happy to acked-by.

The new patch is on top of the others, so patch 1 is still needed.

I think I can squash it to the patch 1 if needed.

Thanks,
Namhyung