i40e: Annotate struct i40e_qvlist_info with __counted_by
PATCH 1/1 i40e: Annotate struct i40e_qvlist_info with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct i40e_qvlist_info.
--- include/linux/net/intel/i40e_client.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/net/intel/i40e_client.h +1 -1
@@ -45,7 +45,7 @@ struct i40e_qv_info {struct i40e_qvlist_info {u32 num_vectors; -struct i40e_qv_info qv_info[]; + struct i40e_qv_info qv_info[] __counted_by(num_vectors); };
Signature · 1 line
2.34.1
Quoted 8 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structi40e_qvlist_info.
Quoted 8 lines
Cc Tony Nguyen <[email protected]>Cc Shiraz Saleem <[email protected]>Cc Jakub Kicinski <[email protected]>Cc Jesse Brandeburg <[email protected]>Cc Gurucharan G <[email protected]>Cc "Gustavo A. R. Silva" <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
--
Gustavo
Quoted 17 lines
--- include/linux/net/intel/i40e_client.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/net/intel/i40e_client.h +1
-1@@ -45,7 +45,7 @@ struct i40e_qv_info {struct i40e_qvlist_info {u32 num_vectors; -struct i40e_qv_info qv_info[]; + struct i40e_qv_info qv_info[] __counted_by(num_vectors); };
Kees Cook
AppliedQuoted 9 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structi40e_qvlist_info.[...]
Applied to for-next/hardening, thanks!
[1/1] i40e: Annotate struct i40e_qvlist_info with __counted_by
https://git.kernel.org/kees/c/da2e08d4630a
Take care,
Signature · 1 line
Kees Cook