Skip to contentSkip to conversation

ufs: core: remove dev cmd clock scaling busy

PATCH Applied [email protected] 3 participants 3 messages Oct 4, 2023 – Oct 10, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ufs: core: remove dev cmd clock scaling busy

From: Peter Wang <[email protected]>

If dev command timeout, clk_scaling.active_reqs is not decrease and cause clock scaling framework abnormal. But it is complicated to handle different dev command timeout case in legacy mode or mcq mode. Besides, dev cmd is rare used and busy time is short.
So remove clock scaling busy window for dev cmd is properly. Same as uic or tm cmd which doesn't update busy window too.

---
 drivers/ufs/core/ufshcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ufs/core/ufshcd.c +2 -2
index c2df07545f96..474d5dded7ed 100644
@@ -2165,7 +2165,8 @@ void ufshcd_send_command(struct ufs_hba *hba, unsigned int task_tag,
 	lrbp->compl_time_stamp = ktime_set(0, 0);
 	lrbp->compl_time_stamp_local_clock = 0;
 	ufshcd_add_command_trace(hba, task_tag, UFS_CMD_SEND);
-	ufshcd_clk_scaling_start_busy(hba);
+	if (lrbp->cmd)
+		ufshcd_clk_scaling_start_busy(hba);
 	if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))
 		ufshcd_start_monitor(hba, lrbp);
 
@@ -5405,7 +5406,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
 				lrbp->utr_descriptor_ptr->header.ocs = ocs;
 			}
 			complete(hba->dev_cmd.complete);
-			ufshcd_clk_scaling_update_busy(hba);
 		}
 	}
 }
Signature · 1 line
2.18.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · On Wed, Oct 4, 2023 at 2:25 PM <[email protected]> wrote:

From: Peter Wang <[email protected]>

If dev command timeout, clk_scaling.active_reqs is not decrease and cause clock scaling framework abnormal. But it is complicated to handle different dev command timeout case in legacy mode or mcq mode. Besides, dev cmd is rare used and busy time is short.
So remove clock scaling busy window for dev cmd is properly. Same as uic or tm cmd which doesn't update busy window too.

It makes sense to me since clock scaling is aimed at balancing performance and power consumption for different workloads, which should be data workloads rather than device commands.

#2 lore raw
In reply to [email protected]

Peter,

Quoted 6 lines

If dev command timeout, clk_scaling.active_reqs is not decrease and cause clock scaling framework abnormal. But it is complicated to handle different dev command timeout case in legacy mode or mcq mode. Besides, dev cmd is rare used and busy time is short. So remove clock scaling busy window for dev cmd is properly. Same as uic or tm cmd which doesn't update busy window too.

Applied to 6.7/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering