__kill_pgrp_info-simplify-the-calculation-of-return-value.patch removed from -mm tree
The quilt patch titled
Subject: __kill_pgrp_info: simplify the calculation of return value
has been removed from the -mm tree. Its filename was
__kill_pgrp_info-simplify-the-calculation-of-return-value.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Oleg Nesterov <[email protected]>
Subject: __kill_pgrp_info: simplify the calculation of return value
Date: Wed, 23 Aug 2023 19:14:55 +0200
No need to calculate/check the "success" variable, we can kill it and update retval in the main loop unless it is zero.
Signed-off-by Oleg Nesterov <[email protected]>
Suggested-by David Laight <[email protected]>
Cc Eric W. Biederman <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
kernel/signal.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
kernel/signal.c renamed from kernel/signal.c~__kill_pgrp_info-simplify-the-calculation-of-return-value +11 -6
@@ -1471,16 +1471,21 @@ int group_send_sig_info(int sig, structint __kill_pgrp_info (int sig,struct kernel_siginfo *info,struct pid *pgrp) {struct task_struct *p =NULL ; -int retval, success; +int ret = -ESRCH ; - success =0 ; - retval = -ESRCH ; do_each_pid_task(pgrp, PIDTYPE_PGID, p) {int err =group_send_sig_info (sig, info, p,PIDTYPE_PGID ); - success |= !err; - retval = err; +/* +* If group_send_sig_info() succeeds at least once ret +* becomes 0 and after that the code below has no effect. +* Otherwise we return the last err or -ESRCH if this +* process group is empty. +*/ +if (ret) + ret = err; }while_each_pid_task (pgrp,PIDTYPE_PGID , p); -return success ?0 : retval; + +return ret; }int kill_pid_info (int sig,struct kernel_siginfo *info,struct pid *pid)
_
Patches currently in -mm which might be from [email protected] are