Skip to contentSkip to conversation

devtool/upgrade: check all git config locations

PATCH New Marcus Flyckt 1 participant 1 message Oct 6, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtool/upgrade: check all git config locations

Fixes [YOCTO #15222]

In some situations its more practical to keep git configuration at /etc/gitconfig instead of $HOME/.gitconfig (e.g., when mounting git configuration into a docker container).

This change makes devtool upgrade consider any available git configuration instead of only checking --global.

---
 scripts/lib/devtool/upgrade.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/devtool/upgrade.py +1 -1
index 487308912f..9cd50be3a2 100644
@@ -442,7 +442,7 @@ def _create_new_recipe(newpv, md5, sha256, srcrev, srcbranch, srcsubdir_old, src
 def _check_git_config():
     def getconfig(name):
         try:
-            value = bb.process.run('git config --global %s' % name)[0].strip()
+            value = bb.process.run('git config %s' % name)[0].strip()
         except bb.process.ExecutionError as e:
             if e.exitcode == 1:
                 value = None
Signature · 1 line
2.34.1