LBR: filter vsyscall addresses
Subsystems (2)
PATCH 1/1 LBR: filter vsyscall addresses
We found that a panic can occur when a vsyscall is made while LBR sampling is active. If the vsyscall is interrupted (nmi) for perf sampling this call sequence can occur (most recent at top):
0 __insn_get_emulate_prefix
1 insn_get_emulate_prefix
2 insn_get_prefixes
3 insn_get_opcode
4 decode_branch_type
5 get_branch_type
6 intel_pmu_lbr_filter
7 intel_pmu_handle_irq
8 perf_event_nmi_handler
Within __insn_get_emulate_prefix at frame 0, a macro is called:
peek_nbyte_next(insn_byte_t, insn, i)
Within this macro, this dereference occurs:
(insn)->next_byte
Inspecting registers at this point, the value of the next_byte field is the address of the vsyscall made, for example the location of the vsyscall version of gettimeofday() at 0xffffffffff600000. The access to an address in the vsyscall region will trigger an oops due to an unhandled page fault.
The test program below can be used to run the vsyscall version of gettimeofday() repeatedly. In order to repro the panic, run this program with the perf command:
perf record --branch-filter any_call ./a.out
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <sys/time.h>
int vsyscall_gettimeofday(struct timeval *tv)
{
register int64_t rax __asm__("rax") = 0xffffffffff600000;
register void *rdi __asm__("rdi") = tv;
__asm__ volatile (
"callq *%%rax \n\t"
: "+r" (rax)
: "r" (rdi)
);
return rax;
}int main()
{
struct timeval tv;
for (;;) {
memset(&tv, 0, sizeof(tv));
vsyscall_gettimeofday(&tv);
printf("sec:%ld, usec:%ld\n", tv.tv_sec, tv.tv_usec);
}
}To prevent the problem, filtering for vsyscalls can be done when determining the branch type. This patch will return a "none" branch if a kernel address if found to lie in the vsyscall region.
--- arch/x86/events/utils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/events/utils.c +3 -2
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 #include <asm/insn.h> +#include <linux/mm.h> #include "perf_event.h"
@@ -132,9 +133,9 @@ static int get_branch_type(unsigned long from, unsigned long to, int abort,* The LBR logs any address in the IP, even if the IP just * faulted. This means userspace can control the from address. * Ensure we don't blindly read any address by validating it is -* a known text address. +* a known text address and not a vsyscall address. */ -if (kernel_text_address (from)) { +if (kernel_text_address (from) && !in_gate_area_no_mm (from)) { addr = (void *)from;/* * Assume we can get the maximum possible size
Signature · 1 line
2.41.0