Skip to contentSkip to conversation

firmware: meson: Use device_get_match_data()

PATCH Applied Rob Herring 2 participants 3 messages Oct 6, 2023 – Oct 9, 2023 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: meson: Use device_get_match_data()

Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers.

---
 drivers/firmware/meson/meson_sm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/firmware/meson/meson_sm.c +3 -2
index 53bf56e18743..ed60f1103053 100644
@@ -13,9 +13,10 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/printk.h>
+#include <linux/property.h>
 #include <linux/types.h>
 #include <linux/sizes.h>
  #include <linux/slab.h>
@@ -297,7 +298,7 @@ static int __init meson_sm_probe(struct platform_device *pdev)
 	if (!fw)
 		return -ENOMEM;
 
-	chip = of_match_device(meson_sm_ids, dev)->data;
+	chip = device_get_match_data(dev);
 	if (!chip)
 		return -EINVAL;
 
Signature · 1 line
2.40.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Rob Herring

Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers.

---
  drivers/firmware/meson/meson_sm.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/firmware/meson/meson_sm.c +2 -1
index 53bf56e18743..ed60f1103053 100644
@@ -13,9 +13,10 @@
  #include <linux/io.h>
  #include <linux/module.h>
  #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
  #include <linux/platform_device.h>
  #include <linux/printk.h>
+#include <linux/property.h>
  #include <linux/types.h>
  #include <linux/sizes.h>
   #include <linux/slab.h>

drivers/firmware/meson/meson_sm.c static int __init meson_sm_probe(struct platform_device *pdev) · line 304

Quoted 8 lines
drivers/firmware/meson/meson_sm.c +1 -1
@@ -297,7 +298,7 @@ static int __init meson_sm_probe(struct platform_device *pdev)
  	if (!fw)
  		return -ENOMEM;
 
-	chip = of_match_device(meson_sm_ids, dev)->data;
+	chip = device_get_match_data(dev);
  	if (!chip)
  		return -EINVAL;
 
maintainer Applied
#2 lore raw
In reply to Rob Herring

Hi,

Quoted 5 lines · Rob Herring

Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers.

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.7/drivers)

[1/1] firmware: meson: Use device_get_match_data()

      https://git.kernel.org/amlogic/c/5d59b6a49bb8f6841acf53affc0c4720fe7450e5

These changes has been applied on the intermediate git tree [1].

The v6.7/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

Signature · 1 line
Neil