Proposal to use netlink for RAS and Telemetry across drm subsystem
Subsystems (3)
v3 cover Proposal to use netlink for RAS and Telemetry across drm subsystem
Rebased on the latest XE branch
Our hardware supports RAS(Reliability, Availability, Serviceability) by reporting the errors to the host, which the KMD processes and exposes a set of error counters which can be used by observability tools to take corrective actions or repairs. Traditionally there were being exposed via PMU (for relative counters) and sysfs interface (for absolute value) in our internal branch. But, due to the limitations in this approach to use two interfaces and also not able to have an event based reporting or configurability, an alternative approach to try netlink was suggested by community for drm subsystem wide UAPI for RAS and telemetry as discussed in [1].
This [1] is the inspiration to this series. It uses the generic netlink(genl) family subsystem and exposes a set of commands that can be used by every drm driver, the framework provides a means to have custom commands too. Each drm driver instance in this example xe driver instance registers a family and operations to the genl subsystem through which it enumerates and reports the error counters. An event based notification is also supported to which userpace can subscribe to and be notified when any error occurs and read the error counter this avoids continuous polling on error counter. This can also be extended to threshold based notification.
[1]: https://airlied.blogspot.com/2022/09/accelerators-bof-outcomes-summary.html
this series is on top of https://patchwork.freedesktop.org/series/124331/,
haven't exposed all the errors yet as the series in still under discussion. But what I have here should be sufficient for a design discussion.
v3:
1. Rebase on latest RAS series for XE
2. drop DRIVER_NETLINK flag and use the driver_genl_ops structure to register to netlink subsystem
v2: define common interfaces to genl netlink subsystem that all drm drivers can leverage.
Below is an example tool drm_ras which demonstrates the use of the
supported commands. The tool will be sent to ML with the subject
"[RFC i-g-t v2 0/1] A tool to demonstrate use of netlink sockets to read RAS error counters"
https://patchwork.freedesktop.org/series/118437/#rev2
read single error counter:
$ ./drm_ras READ_ONE --device=drm:/dev/dri/card1 --error_id=0x0000000000000005 counter value 0
read all error counters:
$ ./drm_ras READ_ALL --device=drm:/dev/dri/card1 name config-id counter
error-gt0-correctable-guc 0x0000000000000001 0 error-gt0-correctable-slm 0x0000000000000003 0 error-gt0-correctable-eu-ic 0x0000000000000004 0 error-gt0-correctable-eu-grf 0x0000000000000005 0 error-gt0-fatal-guc 0x0000000000000009 0 error-gt0-fatal-slm 0x000000000000000d 0 error-gt0-fatal-eu-grf 0x000000000000000f 0 error-gt0-fatal-fpu 0x0000000000000010 0 error-gt0-fatal-tlb 0x0000000000000011 0 error-gt0-fatal-l3-fabric 0x0000000000000012 0 error-gt0-correctable-subslice 0x0000000000000013 0 error-gt0-correctable-l3bank 0x0000000000000014 0 error-gt0-fatal-subslice 0x0000000000000015 0 error-gt0-fatal-l3bank 0x0000000000000016 0 error-gt0-sgunit-correctable 0x0000000000000017 0 error-gt0-sgunit-nonfatal 0x0000000000000018 0 error-gt0-sgunit-fatal 0x0000000000000019 0 error-gt0-soc-fatal-psf-csc-0 0x000000000000001a 0 error-gt0-soc-fatal-psf-csc-1 0x000000000000001b 0 error-gt0-soc-fatal-psf-csc-2 0x000000000000001c 0 error-gt0-soc-fatal-punit 0x000000000000001d 0 error-gt0-soc-fatal-psf-0 0x000000000000001e 0 error-gt0-soc-fatal-psf-1 0x000000000000001f 0 error-gt0-soc-fatal-psf-2 0x0000000000000020 0 error-gt0-soc-fatal-cd0 0x0000000000000021 0 error-gt0-soc-fatal-cd0-mdfi 0x0000000000000022 0 error-gt0-soc-fatal-mdfi-east 0x0000000000000023 0 error-gt0-soc-fatal-mdfi-south 0x0000000000000024 0 error-gt0-soc-fatal-hbm-ss0-0 0x0000000000000025 0 error-gt0-soc-fatal-hbm-ss0-1 0x0000000000000026 0 error-gt0-soc-fatal-hbm-ss0-2 0x0000000000000027 0 error-gt0-soc-fatal-hbm-ss0-3 0x0000000000000028 0 error-gt0-soc-fatal-hbm-ss0-4 0x0000000000000029 0 error-gt0-soc-fatal-hbm-ss0-5 0x000000000000002a 0 error-gt0-soc-fatal-hbm-ss0-6 0x000000000000002b 0 error-gt0-soc-fatal-hbm-ss0-7 0x000000000000002c 0 error-gt0-soc-fatal-hbm-ss1-0 0x000000000000002d 0 error-gt0-soc-fatal-hbm-ss1-1 0x000000000000002e 0 error-gt0-soc-fatal-hbm-ss1-2 0x000000000000002f 0 error-gt0-soc-fatal-hbm-ss1-3 0x0000000000000030 0 error-gt0-soc-fatal-hbm-ss1-4 0x0000000000000031 0 error-gt0-soc-fatal-hbm-ss1-5 0x0000000000000032 0 error-gt0-soc-fatal-hbm-ss1-6 0x0000000000000033 0 error-gt0-soc-fatal-hbm-ss1-7 0x0000000000000034 0 error-gt0-soc-fatal-hbm-ss2-0 0x0000000000000035 0 error-gt0-soc-fatal-hbm-ss2-1 0x0000000000000036 0 error-gt0-soc-fatal-hbm-ss2-2 0x0000000000000037 0 error-gt0-soc-fatal-hbm-ss2-3 0x0000000000000038 0 error-gt0-soc-fatal-hbm-ss2-4 0x0000000000000039 0 error-gt0-soc-fatal-hbm-ss2-5 0x000000000000003a 0 error-gt0-soc-fatal-hbm-ss2-6 0x000000000000003b 0 error-gt0-soc-fatal-hbm-ss2-7 0x000000000000003c 0 error-gt0-soc-fatal-hbm-ss3-0 0x000000000000003d 0 error-gt0-soc-fatal-hbm-ss3-1 0x000000000000003e 0 error-gt0-soc-fatal-hbm-ss3-2 0x000000000000003f 0 error-gt0-soc-fatal-hbm-ss3-3 0x0000000000000040 0 error-gt0-soc-fatal-hbm-ss3-4 0x0000000000000041 0 error-gt0-soc-fatal-hbm-ss3-5 0x0000000000000042 0 error-gt0-soc-fatal-hbm-ss3-6 0x0000000000000043 0 error-gt0-soc-fatal-hbm-ss3-7 0x0000000000000044 0 error-gt0-gsc-correctable-sram-ecc 0x0000000000000045 0 error-gt0-gsc-nonfatal-mia-shutdown 0x0000000000000046 0 error-gt0-gsc-nonfatal-mia-int 0x0000000000000047 0 error-gt0-gsc-nonfatal-sram-ecc 0x0000000000000048 0 error-gt0-gsc-nonfatal-wdg-timeout 0x0000000000000049 0 error-gt0-gsc-nonfatal-rom-parity 0x000000000000004a 0 error-gt0-gsc-nonfatal-ucode-parity 0x000000000000004b 0 error-gt0-gsc-nonfatal-glitch-det 0x000000000000004c 0 error-gt0-gsc-nonfatal-fuse-pull 0x000000000000004d 0 error-gt0-gsc-nonfatal-fuse-crc-check 0x000000000000004e 0 error-gt0-gsc-nonfatal-selfmbist 0x000000000000004f 0 error-gt0-gsc-nonfatal-aon-parity 0x0000000000000050 0 error-gt1-correctable-guc 0x1000000000000001 0 error-gt1-correctable-slm 0x1000000000000003 0 error-gt1-correctable-eu-ic 0x1000000000000004 0 error-gt1-correctable-eu-grf 0x1000000000000005 0 error-gt1-fatal-guc 0x1000000000000009 0 error-gt1-fatal-slm 0x100000000000000d 0 error-gt1-fatal-eu-grf 0x100000000000000f 0 error-gt1-fatal-fpu 0x1000000000000010 0 error-gt1-fatal-tlb 0x1000000000000011 0 error-gt1-fatal-l3-fabric 0x1000000000000012 0 error-gt1-correctable-subslice 0x1000000000000013 0 error-gt1-correctable-l3bank 0x1000000000000014 0 error-gt1-fatal-subslice 0x1000000000000015 0 error-gt1-fatal-l3bank 0x1000000000000016 0 error-gt1-sgunit-correctable 0x1000000000000017 0 error-gt1-sgunit-nonfatal 0x1000000000000018 0 error-gt1-sgunit-fatal 0x1000000000000019 0 error-gt1-soc-fatal-psf-csc-0 0x100000000000001a 0 error-gt1-soc-fatal-psf-csc-1 0x100000000000001b 0 error-gt1-soc-fatal-psf-csc-2 0x100000000000001c 0 error-gt1-soc-fatal-punit 0x100000000000001d 0 error-gt1-soc-fatal-psf-0 0x100000000000001e 0 error-gt1-soc-fatal-psf-1 0x100000000000001f 0 error-gt1-soc-fatal-psf-2 0x1000000000000020 0 error-gt1-soc-fatal-cd0 0x1000000000000021 0 error-gt1-soc-fatal-cd0-mdfi 0x1000000000000022 0 error-gt1-soc-fatal-mdfi-east 0x1000000000000023 0 error-gt1-soc-fatal-mdfi-south 0x1000000000000024 0 error-gt1-soc-fatal-hbm-ss0-0 0x1000000000000025 0 error-gt1-soc-fatal-hbm-ss0-1 0x1000000000000026 0 error-gt1-soc-fatal-hbm-ss0-2 0x1000000000000027 0 error-gt1-soc-fatal-hbm-ss0-3 0x1000000000000028 0 error-gt1-soc-fatal-hbm-ss0-4 0x1000000000000029 0 error-gt1-soc-fatal-hbm-ss0-5 0x100000000000002a 0 error-gt1-soc-fatal-hbm-ss0-6 0x100000000000002b 0 error-gt1-soc-fatal-hbm-ss0-7 0x100000000000002c 0 error-gt1-soc-fatal-hbm-ss1-0 0x100000000000002d 0 error-gt1-soc-fatal-hbm-ss1-1 0x100000000000002e 0 error-gt1-soc-fatal-hbm-ss1-2 0x100000000000002f 0 error-gt1-soc-fatal-hbm-ss1-3 0x1000000000000030 0 error-gt1-soc-fatal-hbm-ss1-4 0x1000000000000031 0 error-gt1-soc-fatal-hbm-ss1-5 0x1000000000000032 0 error-gt1-soc-fatal-hbm-ss1-6 0x1000000000000033 0 error-gt1-soc-fatal-hbm-ss1-7 0x1000000000000034 0 error-gt1-soc-fatal-hbm-ss2-0 0x1000000000000035 0 error-gt1-soc-fatal-hbm-ss2-1 0x1000000000000036 0 error-gt1-soc-fatal-hbm-ss2-2 0x1000000000000037 0 error-gt1-soc-fatal-hbm-ss2-3 0x1000000000000038 0 error-gt1-soc-fatal-hbm-ss2-4 0x1000000000000039 0 error-gt1-soc-fatal-hbm-ss2-5 0x100000000000003a 0 error-gt1-soc-fatal-hbm-ss2-6 0x100000000000003b 0 error-gt1-soc-fatal-hbm-ss2-7 0x100000000000003c 0 error-gt1-soc-fatal-hbm-ss3-0 0x100000000000003d 0 error-gt1-soc-fatal-hbm-ss3-1 0x100000000000003e 0 error-gt1-soc-fatal-hbm-ss3-2 0x100000000000003f 0 error-gt1-soc-fatal-hbm-ss3-3 0x1000000000000040 0 error-gt1-soc-fatal-hbm-ss3-4 0x1000000000000041 0 error-gt1-soc-fatal-hbm-ss3-5 0x1000000000000042 0 error-gt1-soc-fatal-hbm-ss3-6 0x1000000000000043 0 error-gt1-soc-fatal-hbm-ss3-7 0x1000000000000044 0
wait on a error event:
$ ./drm_ras WAIT_ON_EVENT --device=drm:/dev/dri/card1 waiting for error event error event received counter value 0
list all errors:
$ ./drm_ras LIST_ERRORS --device=drm:/dev/dri/card1 name config-id
error-gt0-correctable-guc 0x0000000000000001 error-gt0-correctable-slm 0x0000000000000003 error-gt0-correctable-eu-ic 0x0000000000000004 error-gt0-correctable-eu-grf 0x0000000000000005 error-gt0-fatal-guc 0x0000000000000009 error-gt0-fatal-slm 0x000000000000000d error-gt0-fatal-eu-grf 0x000000000000000f error-gt0-fatal-fpu 0x0000000000000010 error-gt0-fatal-tlb 0x0000000000000011 error-gt0-fatal-l3-fabric 0x0000000000000012 error-gt0-correctable-subslice 0x0000000000000013 error-gt0-correctable-l3bank 0x0000000000000014 error-gt0-fatal-subslice 0x0000000000000015 error-gt0-fatal-l3bank 0x0000000000000016 error-gt0-sgunit-correctable 0x0000000000000017 error-gt0-sgunit-nonfatal 0x0000000000000018 error-gt0-sgunit-fatal 0x0000000000000019 error-gt0-soc-fatal-psf-csc-0 0x000000000000001a error-gt0-soc-fatal-psf-csc-1 0x000000000000001b error-gt0-soc-fatal-psf-csc-2 0x000000000000001c error-gt0-soc-fatal-punit 0x000000000000001d error-gt0-soc-fatal-psf-0 0x000000000000001e error-gt0-soc-fatal-psf-1 0x000000000000001f error-gt0-soc-fatal-psf-2 0x0000000000000020 error-gt0-soc-fatal-cd0 0x0000000000000021 error-gt0-soc-fatal-cd0-mdfi 0x0000000000000022 error-gt0-soc-fatal-mdfi-east 0x0000000000000023 error-gt0-soc-fatal-mdfi-south 0x0000000000000024 error-gt0-soc-fatal-hbm-ss0-0 0x0000000000000025 error-gt0-soc-fatal-hbm-ss0-1 0x0000000000000026 error-gt0-soc-fatal-hbm-ss0-2 0x0000000000000027 error-gt0-soc-fatal-hbm-ss0-3 0x0000000000000028 error-gt0-soc-fatal-hbm-ss0-4 0x0000000000000029 error-gt0-soc-fatal-hbm-ss0-5 0x000000000000002a error-gt0-soc-fatal-hbm-ss0-6 0x000000000000002b error-gt0-soc-fatal-hbm-ss0-7 0x000000000000002c error-gt0-soc-fatal-hbm-ss1-0 0x000000000000002d error-gt0-soc-fatal-hbm-ss1-1 0x000000000000002e error-gt0-soc-fatal-hbm-ss1-2 0x000000000000002f error-gt0-soc-fatal-hbm-ss1-3 0x0000000000000030 error-gt0-soc-fatal-hbm-ss1-4 0x0000000000000031 error-gt0-soc-fatal-hbm-ss1-5 0x0000000000000032 error-gt0-soc-fatal-hbm-ss1-6 0x0000000000000033 error-gt0-soc-fatal-hbm-ss1-7 0x0000000000000034 error-gt0-soc-fatal-hbm-ss2-0 0x0000000000000035 error-gt0-soc-fatal-hbm-ss2-1 0x0000000000000036 error-gt0-soc-fatal-hbm-ss2-2 0x0000000000000037 error-gt0-soc-fatal-hbm-ss2-3 0x0000000000000038 error-gt0-soc-fatal-hbm-ss2-4 0x0000000000000039 error-gt0-soc-fatal-hbm-ss2-5 0x000000000000003a error-gt0-soc-fatal-hbm-ss2-6 0x000000000000003b error-gt0-soc-fatal-hbm-ss2-7 0x000000000000003c error-gt0-soc-fatal-hbm-ss3-0 0x000000000000003d error-gt0-soc-fatal-hbm-ss3-1 0x000000000000003e error-gt0-soc-fatal-hbm-ss3-2 0x000000000000003f error-gt0-soc-fatal-hbm-ss3-3 0x0000000000000040 error-gt0-soc-fatal-hbm-ss3-4 0x0000000000000041 error-gt0-soc-fatal-hbm-ss3-5 0x0000000000000042 error-gt0-soc-fatal-hbm-ss3-6 0x0000000000000043 error-gt0-soc-fatal-hbm-ss3-7 0x0000000000000044 error-gt0-gsc-correctable-sram-ecc 0x0000000000000045 error-gt0-gsc-nonfatal-mia-shutdown 0x0000000000000046 error-gt0-gsc-nonfatal-mia-int 0x0000000000000047 error-gt0-gsc-nonfatal-sram-ecc 0x0000000000000048 error-gt0-gsc-nonfatal-wdg-timeout 0x0000000000000049 error-gt0-gsc-nonfatal-rom-parity 0x000000000000004a error-gt0-gsc-nonfatal-ucode-parity 0x000000000000004b error-gt0-gsc-nonfatal-glitch-det 0x000000000000004c error-gt0-gsc-nonfatal-fuse-pull 0x000000000000004d error-gt0-gsc-nonfatal-fuse-crc-check 0x000000000000004e error-gt0-gsc-nonfatal-selfmbist 0x000000000000004f error-gt0-gsc-nonfatal-aon-parity 0x0000000000000050 error-gt1-correctable-guc 0x1000000000000001 error-gt1-correctable-slm 0x1000000000000003 error-gt1-correctable-eu-ic 0x1000000000000004 error-gt1-correctable-eu-grf 0x1000000000000005 error-gt1-fatal-guc 0x1000000000000009 error-gt1-fatal-slm 0x100000000000000d error-gt1-fatal-eu-grf 0x100000000000000f error-gt1-fatal-fpu 0x1000000000000010 error-gt1-fatal-tlb 0x1000000000000011 error-gt1-fatal-l3-fabric 0x1000000000000012 error-gt1-correctable-subslice 0x1000000000000013 error-gt1-correctable-l3bank 0x1000000000000014 error-gt1-fatal-subslice 0x1000000000000015 error-gt1-fatal-l3bank 0x1000000000000016 error-gt1-sgunit-correctable 0x1000000000000017 error-gt1-sgunit-nonfatal 0x1000000000000018 error-gt1-sgunit-fatal 0x1000000000000019 error-gt1-soc-fatal-psf-csc-0 0x100000000000001a error-gt1-soc-fatal-psf-csc-1 0x100000000000001b error-gt1-soc-fatal-psf-csc-2 0x100000000000001c error-gt1-soc-fatal-punit 0x100000000000001d error-gt1-soc-fatal-psf-0 0x100000000000001e error-gt1-soc-fatal-psf-1 0x100000000000001f error-gt1-soc-fatal-psf-2 0x1000000000000020 error-gt1-soc-fatal-cd0 0x1000000000000021 error-gt1-soc-fatal-cd0-mdfi 0x1000000000000022 error-gt1-soc-fatal-mdfi-east 0x1000000000000023 error-gt1-soc-fatal-mdfi-south 0x1000000000000024 error-gt1-soc-fatal-hbm-ss0-0 0x1000000000000025 error-gt1-soc-fatal-hbm-ss0-1 0x1000000000000026 error-gt1-soc-fatal-hbm-ss0-2 0x1000000000000027 error-gt1-soc-fatal-hbm-ss0-3 0x1000000000000028 error-gt1-soc-fatal-hbm-ss0-4 0x1000000000000029 error-gt1-soc-fatal-hbm-ss0-5 0x100000000000002a error-gt1-soc-fatal-hbm-ss0-6 0x100000000000002b error-gt1-soc-fatal-hbm-ss0-7 0x100000000000002c error-gt1-soc-fatal-hbm-ss1-0 0x100000000000002d error-gt1-soc-fatal-hbm-ss1-1 0x100000000000002e error-gt1-soc-fatal-hbm-ss1-2 0x100000000000002f error-gt1-soc-fatal-hbm-ss1-3 0x1000000000000030 error-gt1-soc-fatal-hbm-ss1-4 0x1000000000000031 error-gt1-soc-fatal-hbm-ss1-5 0x1000000000000032 error-gt1-soc-fatal-hbm-ss1-6 0x1000000000000033 error-gt1-soc-fatal-hbm-ss1-7 0x1000000000000034 error-gt1-soc-fatal-hbm-ss2-0 0x1000000000000035 error-gt1-soc-fatal-hbm-ss2-1 0x1000000000000036 error-gt1-soc-fatal-hbm-ss2-2 0x1000000000000037 error-gt1-soc-fatal-hbm-ss2-3 0x1000000000000038 error-gt1-soc-fatal-hbm-ss2-4 0x1000000000000039 error-gt1-soc-fatal-hbm-ss2-5 0x100000000000003a error-gt1-soc-fatal-hbm-ss2-6 0x100000000000003b error-gt1-soc-fatal-hbm-ss2-7 0x100000000000003c error-gt1-soc-fatal-hbm-ss3-0 0x100000000000003d error-gt1-soc-fatal-hbm-ss3-1 0x100000000000003e error-gt1-soc-fatal-hbm-ss3-2 0x100000000000003f error-gt1-soc-fatal-hbm-ss3-3 0x1000000000000040 error-gt1-soc-fatal-hbm-ss3-4 0x1000000000000041 error-gt1-soc-fatal-hbm-ss3-5 0x1000000000000042 error-gt1-soc-fatal-hbm-ss3-6 0x1000000000000043 error-gt1-soc-fatal-hbm-ss3-7 0x1000000000000044
Aravind Iddamsetty (5):
drm/netlink: Add netlink infrastructure drm/xe/RAS: Register netlink capability drm/xe/RAS: Expose the error counters drm/netlink: Define multicast groups
drm/xe/RAS: send multicast event on occurrence of an error
drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_drv.c | 7 + drivers/gpu/drm/drm_netlink.c | 177 ++++++++++++ drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 4 + drivers/gpu/drm/xe/xe_device_types.h | 1 + drivers/gpu/drm/xe/xe_hw_error.c | 33 +++ drivers/gpu/drm/xe/xe_netlink.c | 414 +++++++++++++++++++++++++++ include/drm/drm_device.h | 8 + include/drm/drm_drv.h | 7 + include/drm/drm_netlink.h | 49 ++++ include/uapi/drm/drm_netlink.h | 87 ++++++ include/uapi/drm/xe_drm.h | 61 ++++ 13 files changed, 850 insertions(+) create mode 100644 drivers/gpu/drm/drm_netlink.c create mode 100644 drivers/gpu/drm/xe/xe_netlink.c create mode 100644 include/drm/drm_netlink.h create mode 100644 include/uapi/drm/drm_netlink.h
Signature · 1 line
2.25.1
RFC v3 1/5 drm/netlink: Add netlink infrastructure
Define the netlink registration interface and commands, attributes that can be commonly used across by drm drivers. This patch intends to use the generic netlink family to expose various stats of device. At present it defines some commands that shall be used to expose RAS error counters.
v2:
define common interfaces to genl netlink subsystem that all drm drivers can leverage.(Tomer Tayar)
v3: drop DRIVER_NETLINK flag and use the driver_genl_ops structure to register to netlink subsystem (Daniel Vetter)
--- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_drv.c | 7 ++ drivers/gpu/drm/drm_netlink.c | 175 +++++++++++++++++++++++++++++++++ include/drm/drm_device.h | 8 ++ include/drm/drm_drv.h | 7 ++ include/drm/drm_netlink.h | 39 ++++++++ include/uapi/drm/drm_netlink.h | 83 ++++++++++++++++ 7 files changed, 320 insertions(+) create mode 100644 drivers/gpu/drm/drm_netlink.c create mode 100644 include/drm/drm_netlink.h create mode 100644 include/uapi/drm/drm_netlink.h
drivers/gpu/drm/Makefile +1 -0
@@ -35,6 +35,7 @@ drm-y := \ drm_mode_object.o \ drm_modes.o \ drm_modeset_lock.o \ + drm_netlink.o \ drm_plane.o \ drm_prime.o \ drm_print.o \
drivers/gpu/drm/drm_drv.c +7 -0
@@ -928,6 +928,12 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)if (ret) goto err_minors; +if (driver->genl_ops) { + ret =drm_genl_register (dev); +if (ret) + goto err_minors; + } + ret =create_compat_control_link (dev);if (ret) goto err_minors;
@@ -1064,6 +1070,7 @@ static void drm_core_exit(void) {drm_privacy_screen_lookup_exit ();accel_core_exit (); +drm_genl_exit ();unregister_chrdev (DRM_MAJOR ,"drm" );debugfs_remove (drm_debugfs_root);drm_sysfs_destroy ();
drivers/gpu/drm/drm_netlink.c new file +175 -0
175 lines not on this page · raw message
include/drm/drm_device.h +8 -0
@@ -8,6 +8,7 @@#include <drm/drm_legacy.h> #include <drm/drm_mode_config.h> +#include <drm/drm_netlink.h> struct drm_driver ;struct drm_minor ;
@@ -326,6 +327,13 @@ struct drm_device {*/ struct list_head debugfs_list; +/** +* @drm_genl_family: +* +* Generic netlink family registration structure. +*/ +struct genl_family drm_genl_family; +/* Everything below here is for legacy driver, never use! */ /* private: */ #if IS_ENABLED (CONFIG_DRM_LEGACY )
include/drm/drm_drv.h +7 -0
@@ -434,6 +434,13 @@ struct drm_driver {*/ const struct file_operations *fops; +/** +* @genl_ops: +* +* Drivers private callback to genl commands +*/ +const struct driver_genl_ops *genl_ops; +#ifdef CONFIG_DRM_LEGACY /* Everything below here is for legacy driver, never use! */ /* private: */
include/drm/drm_netlink.h new file +39 -0
@@ -0,0 +1,39 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2023 Intel Corporation +*/ + +#ifndef __DRM_NETLINK_H__ +#define __DRM_NETLINK_H__ + +#include <linux/netdevice.h> +#include <net/genetlink.h> +#include <net/sock.h> +#include <uapi/drm/drm_netlink.h> + +struct drm_device ; + +struct driver_genl_ops { +int (*doit)(struct drm_device *dev, +struct sk_buff *skb, +struct genl_info *info); +}; + +/* attribute policies */ +static const struct nla_policy drm_attr_policy_query[DRM_ATTR_MAX +1 ] = { + [DRM_RAS_ATTR_REQUEST ] = { .type =NLA_U8 }, +}; + +static const struct nla_policy drm_attr_policy_read_one[DRM_ATTR_MAX +1 ] = { + [DRM_RAS_ATTR_ERROR_ID ] = { .type =NLA_U64 }, +}; + +int drm_genl_register (struct drm_device *dev); +void drm_genl_exit (void ); +int drm_genl_send (struct sk_buff *msg,struct genl_info *info,void *usrhdr); +struct sk_buff * +drm_genl_alloc_msg (struct drm_device *dev, +struct genl_info *info, +size_t msg_size,void **usrhdr); +#endif +
include/uapi/drm/drm_netlink.h new file +83 -0
83 lines not on this page · raw message
Signature · 1 line
2.25.1
RFC v2 2/5 drm/xe/RAS: Register netlink capability
In reply to Aravind IddamsettyRegister netlink capability with the DRM and register the driver callbacks to DRM RAS netlink commands.
v2:
Move the netlink registration parts to DRM susbsytem (Tomer Tayar)
--- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 4 ++++ drivers/gpu/drm/xe/xe_device_types.h | 1 + drivers/gpu/drm/xe/xe_netlink.c | 22 ++++++++++++++++++++++ 4 files changed, 28 insertions(+) create mode 100644 drivers/gpu/drm/xe/xe_netlink.c
drivers/gpu/drm/xe/Makefile +1 -0
@@ -86,6 +86,7 @@ xe-y += xe_bb.o \ xe_mmio.o \ xe_mocs.o \ xe_module.o \ + xe_netlink.o \ xe_pat.o \ xe_pci.o \ xe_pcode.o \
drivers/gpu/drm/xe/xe_device.c +4 -0
@@ -150,6 +150,8 @@ static void xe_driver_release(struct drm_device *dev)pci_set_drvdata (to_pci_dev (xe->drm.dev),NULL ); } +extern const struct driver_genl_ops xe_genl_ops[]; +static struct drm_driver driver = {/* Don't use MTRRs here; the Xserver or userspace app should * deal with them for Intel hardware.
@@ -158,6 +160,7 @@ static struct drm_driver driver = {DRIVER_GEM |DRIVER_RENDER |DRIVER_SYNCOBJ | DRIVER_SYNCOBJ_TIMELINE | DRIVER_GEM_GPUVA, + .open = xe_file_open, .postclose = xe_file_close,
@@ -169,6 +172,7 @@ static struct drm_driver driver = { .show_fdinfo = xe_drm_client_fdinfo, #endif .release = &xe_driver_release, + .genl_ops = xe_genl_ops, .ioctls = xe_ioctls, .num_ioctls = ARRAY_SIZE(xe_ioctls),
drivers/gpu/drm/xe/xe_device_types.h +1 -0
@@ -10,6 +10,7 @@#include <drm/drm_device.h> #include <drm/drm_file.h> +#include <drm/drm_netlink.h> #include <drm/ttm/ttm_device.h> #include "xe_devcoredump_types.h"
drivers/gpu/drm/xe/xe_netlink.c new file +22 -0
@@ -0,0 +1,22 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright © 2023 Intel Corporation +*/ +#include "xe_device.h" + +static int xe_genl_list_errors (struct drm_device *drm,struct sk_buff *msg,struct genl_info *info) +{ +return 0 ; +} + +static int xe_genl_read_error (struct drm_device *drm,struct sk_buff *msg,struct genl_info *info) +{ +return 0 ; +} + +/* driver callbacks to DRM netlink commands*/ +const struct driver_genl_ops xe_genl_ops[] = { + [DRM_RAS_CMD_QUERY ] = { .doit = xe_genl_list_errors }, + [DRM_RAS_CMD_READ_ONE ] = { .doit = xe_genl_read_error }, + [DRM_RAS_CMD_READ_ALL ] = { .doit = xe_genl_list_errors, }, +};
Signature · 1 line
2.25.1
RFC v2 3/5 drm/xe/RAS: Expose the error counters
In reply to Aravind IddamsettyWe expose the various error counters supported on a hardware via genl subsytem through the registered commands to userspace. The DRM_RAS_CMD_QUERY lists the error names with config id, DRM_RAD_CMD_READ_ONE returns the counter value for the requested config id and the DRM_RAS_CMD_READ_ALL lists the counters for all errors along with their names and config ids.
v2: Rebase
--- drivers/gpu/drm/xe/xe_netlink.c | 396 +++++++++++++++++++++++++++++++- include/uapi/drm/xe_drm.h | 61 +++++ 2 files changed, 455 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_netlink.c +394 -2
@@ -2,16 +2,408 @@/* * Copyright © 2023 Intel Corporation */ +#include <drm/xe_drm.h> +#include "xe_device.h" -static int xe_genl_list_errors (struct drm_device *drm,struct sk_buff *msg,struct genl_info *info) +#define MAX_ERROR_NAME 50 + +static const char *const xe_hw_error_events[] = { + [XE_GENL_GT_ERROR_CORRECTABLE_L3_SNG ] ="correctable-l3-sng" , + [XE_GENL_GT_ERROR_CORRECTABLE_GUC ] ="correctable-guc" , + [XE_GENL_GT_ERROR_CORRECTABLE_SAMPLER ] ="correctable-sampler" , + [XE_GENL_GT_ERROR_CORRECTABLE_SLM ] ="correctable-slm" , + [XE_GENL_GT_ERROR_CORRECTABLE_EU_IC ] ="correctable-eu-ic" , + [XE_GENL_GT_ERROR_CORRECTABLE_EU_GRF ] ="correctable-eu-grf" , + [XE_GENL_GT_ERROR_FATAL_ARR_BIST ] ="fatal-array-bist" , + [XE_GENL_GT_ERROR_FATAL_L3_DOUB ] ="fatal-l3-double" , + [XE_GENL_GT_ERROR_FATAL_L3_ECC_CHK ] ="fatal-l3-ecc-checker" , + [XE_GENL_GT_ERROR_FATAL_GUC ] ="fatal-guc" , + [XE_GENL_GT_ERROR_FATAL_IDI_PAR ] ="fatal-idi-parity" , + [XE_GENL_GT_ERROR_FATAL_SQIDI ] ="fatal-sqidi" , + [XE_GENL_GT_ERROR_FATAL_SAMPLER ] ="fatal-sampler" , + [XE_GENL_GT_ERROR_FATAL_SLM ] ="fatal-slm" , + [XE_GENL_GT_ERROR_FATAL_EU_IC ] ="fatal-eu-ic" , + [XE_GENL_GT_ERROR_FATAL_EU_GRF ] ="fatal-eu-grf" , + [XE_GENL_GT_ERROR_FATAL_FPU ] ="fatal-fpu" , + [XE_GENL_GT_ERROR_FATAL_TLB ] ="fatal-tlb" , + [XE_GENL_GT_ERROR_FATAL_L3_FABRIC ] ="fatal-l3-fabric" , + [XE_GENL_GT_ERROR_CORRECTABLE_SUBSLICE ] ="correctable-subslice" , + [XE_GENL_GT_ERROR_CORRECTABLE_L3BANK ] ="correctable-l3bank" , + [XE_GENL_GT_ERROR_FATAL_SUBSLICE ] ="fatal-subslice" , + [XE_GENL_GT_ERROR_FATAL_L3BANK ] ="fatal-l3bank" , + [XE_GENL_SGUNIT_ERROR_CORRECTABLE ] ="sgunit-correctable" , + [XE_GENL_SGUNIT_ERROR_NONFATAL ] ="sgunit-nonfatal" , + [XE_GENL_SGUNIT_ERROR_FATAL ] ="sgunit-fatal" , + [XE_GENL_SOC_ERROR_FATAL_PSF_CSC_0 ] ="soc-fatal-psf-csc-0" , + [XE_GENL_SOC_ERROR_FATAL_PSF_CSC_1 ] ="soc-fatal-psf-csc-1" , + [XE_GENL_SOC_ERROR_FATAL_PSF_CSC_2 ] ="soc-fatal-psf-csc-2" , + [XE_GENL_SOC_ERROR_FATAL_PUNIT ] ="soc-fatal-punit" , + [XE_GENL_PVC_SOC_ERROR_FATAL_PSF_0 ] ="soc-fatal-psf-0" , + [XE_GENL_PVC_SOC_ERROR_FATAL_PSF_1 ] ="soc-fatal-psf-1" , + [XE_GENL_PVC_SOC_ERROR_FATAL_PSF_2 ] ="soc-fatal-psf-2" , + [XE_GENL_PVC_SOC_ERROR_FATAL_CD0_MDFI ] ="soc-fatal-cd0-mdfi" , + [XE_GENL_PVC_SOC_ERROR_FATAL_MDFI_EAST ] ="soc-fatal-mdfi-east" , + [XE_GENL_PVC_SOC_ERROR_FATAL_MDFI_SOUTH ] ="soc-fatal-mdfi-south" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,0 )] ="soc-fatal-hbm-ss0-0" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,1 )] ="soc-fatal-hbm-ss0-1" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,2 )] ="soc-fatal-hbm-ss0-2" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,3 )] ="soc-fatal-hbm-ss0-3" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,4 )] ="soc-fatal-hbm-ss0-4" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,5 )] ="soc-fatal-hbm-ss0-5" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,6 )] ="soc-fatal-hbm-ss0-6" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,7 )] ="soc-fatal-hbm-ss0-7" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,8 )] ="soc-fatal-hbm-ss1-0" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,9 )] ="soc-fatal-hbm-ss1-1" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,10 )] ="soc-fatal-hbm-ss1-2" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,11 )] ="soc-fatal-hbm-ss1-3" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,12 )] ="soc-fatal-hbm-ss1-4" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,13 )] ="soc-fatal-hbm-ss1-5" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,14 )] ="soc-fatal-hbm-ss1-6" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,15 )] ="soc-fatal-hbm-ss1-7" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,0 )] ="soc-fatal-hbm-ss2-0" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,1 )] ="soc-fatal-hbm-ss2-1" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,2 )] ="soc-fatal-hbm-ss2-2" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,3 )] ="soc-fatal-hbm-ss2-3" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,4 )] ="soc-fatal-hbm-ss2-4" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,5 )] ="soc-fatal-hbm-ss2-5" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,6 )] ="soc-fatal-hbm-ss2-6" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,7 )] ="soc-fatal-hbm-ss2-7" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,8 )] ="soc-fatal-hbm-ss3-0" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,9 )] ="soc-fatal-hbm-ss3-1" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,10 )] ="soc-fatal-hbm-ss3-2" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,11 )] ="soc-fatal-hbm-ss3-3" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,12 )] ="soc-fatal-hbm-ss3-4" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,13 )] ="soc-fatal-hbm-ss3-5" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,14 )] ="soc-fatal-hbm-ss3-6" , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,15 )] ="soc-fatal-hbm-ss3-7" , + [XE_GENL_GSC_ERROR_CORRECTABLE_SRAM_ECC ] ="gsc-correctable-sram-ecc" , + [XE_GENL_GSC_ERROR_NONFATAL_MIA_SHUTDOWN ] ="gsc-nonfatal-mia-shutdown" , + [XE_GENL_GSC_ERROR_NONFATAL_MIA_INT ] ="gsc-nonfatal-mia-int" , + [XE_GENL_GSC_ERROR_NONFATAL_SRAM_ECC ] ="gsc-nonfatal-sram-ecc" , + [XE_GENL_GSC_ERROR_NONFATAL_WDG_TIMEOUT ] ="gsc-nonfatal-wdg-timeout" , + [XE_GENL_GSC_ERROR_NONFATAL_ROM_PARITY ] ="gsc-nonfatal-rom-parity" , + [XE_GENL_GSC_ERROR_NONFATAL_UCODE_PARITY ] ="gsc-nonfatal-ucode-parity" , + [XE_GENL_GSC_ERROR_NONFATAL_GLITCH_DET ] ="gsc-nonfatal-glitch-det" , + [XE_GENL_GSC_ERROR_NONFATAL_FUSE_PULL ] ="gsc-nonfatal-fuse-pull" , + [XE_GENL_GSC_ERROR_NONFATAL_FUSE_CRC_CHECK ] ="gsc-nonfatal-fuse-crc-check" , + [XE_GENL_GSC_ERROR_NONFATAL_FUSE_SELFMBIST ] ="gsc-nonfatal-selfmbist" , + [XE_GENL_GSC_ERROR_NONFATAL_AON_PARITY ] ="gsc-nonfatal-aon-parity" , +}; + +static const unsigned long xe_hw_error_map[] = { + [XE_GENL_GT_ERROR_CORRECTABLE_L3_SNG ] =XE_GT_HW_ERR_L3_SNG_CORR , + [XE_GENL_GT_ERROR_CORRECTABLE_GUC ] =XE_GT_HW_ERR_GUC_CORR , + [XE_GENL_GT_ERROR_CORRECTABLE_SAMPLER ] =XE_GT_HW_ERR_SAMPLER_CORR , + [XE_GENL_GT_ERROR_CORRECTABLE_SLM ] =XE_GT_HW_ERR_SLM_CORR , + [XE_GENL_GT_ERROR_CORRECTABLE_EU_IC ] =XE_GT_HW_ERR_EU_IC_CORR , + [XE_GENL_GT_ERROR_CORRECTABLE_EU_GRF ] =XE_GT_HW_ERR_EU_GRF_CORR , + [XE_GENL_GT_ERROR_FATAL_ARR_BIST ] =XE_GT_HW_ERR_ARR_BIST_FATAL , + [XE_GENL_GT_ERROR_FATAL_L3_DOUB ] =XE_GT_HW_ERR_L3_DOUB_FATAL , + [XE_GENL_GT_ERROR_FATAL_L3_ECC_CHK ] =XE_GT_HW_ERR_L3_ECC_CHK_FATAL , + [XE_GENL_GT_ERROR_FATAL_GUC ] =XE_GT_HW_ERR_GUC_FATAL , + [XE_GENL_GT_ERROR_FATAL_IDI_PAR ] =XE_GT_HW_ERR_IDI_PAR_FATAL , + [XE_GENL_GT_ERROR_FATAL_SQIDI ] =XE_GT_HW_ERR_SQIDI_FATAL , + [XE_GENL_GT_ERROR_FATAL_SAMPLER ] =XE_GT_HW_ERR_SAMPLER_FATAL , + [XE_GENL_GT_ERROR_FATAL_SLM ] =XE_GT_HW_ERR_SLM_FATAL , + [XE_GENL_GT_ERROR_FATAL_EU_IC ] =XE_GT_HW_ERR_EU_IC_FATAL , + [XE_GENL_GT_ERROR_FATAL_EU_GRF ] =XE_GT_HW_ERR_EU_GRF_FATAL , + [XE_GENL_GT_ERROR_FATAL_FPU ] =XE_GT_HW_ERR_FPU_FATAL , + [XE_GENL_GT_ERROR_FATAL_TLB ] =XE_GT_HW_ERR_TLB_FATAL , + [XE_GENL_GT_ERROR_FATAL_L3_FABRIC ] =XE_GT_HW_ERR_L3_FABRIC_FATAL , + [XE_GENL_GT_ERROR_CORRECTABLE_SUBSLICE ] =XE_GT_HW_ERR_SUBSLICE_CORR , + [XE_GENL_GT_ERROR_CORRECTABLE_L3BANK ] =XE_GT_HW_ERR_L3BANK_CORR , + [XE_GENL_GT_ERROR_FATAL_SUBSLICE ] =XE_GT_HW_ERR_SUBSLICE_FATAL , + [XE_GENL_GT_ERROR_FATAL_L3BANK ] =XE_GT_HW_ERR_L3BANK_FATAL , + [XE_GENL_SGUNIT_ERROR_CORRECTABLE ] =XE_TILE_HW_ERR_SGUNIT_CORR , + [XE_GENL_SGUNIT_ERROR_NONFATAL ] =XE_TILE_HW_ERR_SGUNIT_NONFATAL , + [XE_GENL_SGUNIT_ERROR_FATAL ] =XE_TILE_HW_ERR_SGUNIT_FATAL , + [XE_GENL_SOC_ERROR_FATAL_PSF_CSC_0 ] =XE_SOC_HW_ERR_CSC_PSF_CMD_FATAL , + [XE_GENL_SOC_ERROR_FATAL_PSF_CSC_1 ] =XE_SOC_HW_ERR_CSC_PSF_CMP_FATAL , + [XE_GENL_SOC_ERROR_FATAL_PSF_CSC_2 ] =XE_SOC_HW_ERR_CSC_PSF_REQ_FATAL , + [XE_GENL_SOC_ERROR_FATAL_PUNIT ] =XE_SOC_HW_ERR_PUNIT_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_PSF_0 ] =XE_SOC_HW_ERR_PCIE_PSF_CMD_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_PSF_1 ] =XE_SOC_HW_ERR_PCIE_PSF_CMP_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_PSF_2 ] =XE_SOC_HW_ERR_PCIE_PSF_REQ_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_CD0_MDFI ] =XE_SOC_HW_ERR_ANR_MDFI_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_MDFI_EAST ] =XE_SOC_HW_ERR_MDFI_T2T_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_MDFI_SOUTH ] =XE_SOC_HW_ERR_MDFI_T2C_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,0 )] =XE_SOC_HW_ERR_HBM0_CHNL0_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,1 )] =XE_SOC_HW_ERR_HBM0_CHNL1_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,2 )] =XE_SOC_HW_ERR_HBM0_CHNL2_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,3 )] =XE_SOC_HW_ERR_HBM0_CHNL3_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,4 )] =XE_SOC_HW_ERR_HBM0_CHNL4_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,5 )] =XE_SOC_HW_ERR_HBM0_CHNL5_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,6 )] =XE_SOC_HW_ERR_HBM0_CHNL6_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,7 )] =XE_SOC_HW_ERR_HBM0_CHNL7_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,8 )] =XE_SOC_HW_ERR_HBM1_CHNL0_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,9 )] =XE_SOC_HW_ERR_HBM1_CHNL1_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,10 )] =XE_SOC_HW_ERR_HBM1_CHNL2_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,11 )] =XE_SOC_HW_ERR_HBM1_CHNL3_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,12 )] =XE_SOC_HW_ERR_HBM1_CHNL4_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,13 )] =XE_SOC_HW_ERR_HBM1_CHNL5_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,14 )] =XE_SOC_HW_ERR_HBM1_CHNL6_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (0 ,15 )] =XE_SOC_HW_ERR_HBM1_CHNL7_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,0 )] =XE_SOC_HW_ERR_HBM2_CHNL0_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,1 )] =XE_SOC_HW_ERR_HBM2_CHNL1_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,2 )] =XE_SOC_HW_ERR_HBM2_CHNL2_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,3 )] =XE_SOC_HW_ERR_HBM2_CHNL3_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,4 )] =XE_SOC_HW_ERR_HBM2_CHNL4_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,5 )] =XE_SOC_HW_ERR_HBM2_CHNL5_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,6 )] =XE_SOC_HW_ERR_HBM2_CHNL6_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,7 )] =XE_SOC_HW_ERR_HBM2_CHNL7_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,8 )] =XE_SOC_HW_ERR_HBM3_CHNL0_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,9 )] =XE_SOC_HW_ERR_HBM3_CHNL1_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,10 )] =XE_SOC_HW_ERR_HBM3_CHNL2_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,11 )] =XE_SOC_HW_ERR_HBM3_CHNL3_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,12 )] =XE_SOC_HW_ERR_HBM3_CHNL4_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,13 )] =XE_SOC_HW_ERR_HBM3_CHNL5_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,14 )] =XE_SOC_HW_ERR_HBM3_CHNL6_FATAL , + [XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,15 )] =XE_SOC_HW_ERR_HBM3_CHNL7_FATAL , + [XE_GENL_GSC_ERROR_CORRECTABLE_SRAM_ECC ] =XE_GSC_HW_ERR_SRAM_CORR , + [XE_GENL_GSC_ERROR_NONFATAL_MIA_SHUTDOWN ] =XE_GSC_HW_ERR_MIA_SHUTDOWN_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_MIA_INT ] =XE_GSC_HW_ERR_MIA_INTERNAL_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_SRAM_ECC ] =XE_GSC_HW_ERR_SRAM_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_WDG_TIMEOUT ] =XE_GSC_HW_ERR_WDG_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_ROM_PARITY ] =XE_GSC_HW_ERR_ROM_PARITY_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_UCODE_PARITY ] =XE_GSC_HW_ERR_UCODE_PARITY_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_GLITCH_DET ] =XE_GSC_HW_ERR_VLT_GLITCH_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_FUSE_PULL ] =XE_GSC_HW_ERR_FUSE_PULL_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_FUSE_CRC_CHECK ] =XE_GSC_HW_ERR_FUSE_CRC_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_FUSE_SELFMBIST ] =XE_GSC_HW_ERR_SELF_MBIST_UNCOR , + [XE_GENL_GSC_ERROR_NONFATAL_AON_PARITY ] =XE_GSC_HW_ERR_AON_RF_PARITY_UNCOR , +}; + +static unsigned int config_gt_id (const u64 config) +{ +return config >> __XE_PMU_GT_SHIFT; +} + +static u64 config_counter (const u64 config) +{ +return config & ~(~0ULL << __XE_PMU_GT_SHIFT); +} + +static bool is_gt_error (const u64 config) +{ +unsigned int error; + + error =config_counter (config); +if (error <=XE_GENL_GT_ERROR_FATAL_FPU ) +return true; + +return false; +} + +static bool is_gt_vector_error (const u64 config) +{ +unsigned int error; + + error =config_counter (config); +if (error >=XE_GENL_GT_ERROR_FATAL_TLB && + error <=XE_GENL_GT_ERROR_FATAL_L3BANK ) +return true; + +return false; +} + +static bool is_pvc_invalid_gt_errors (const u64 config) +{ +switch (config_counter (config)) { +case XE_GENL_GT_ERROR_CORRECTABLE_L3_SNG : +case XE_GENL_GT_ERROR_CORRECTABLE_SAMPLER : +case XE_GENL_GT_ERROR_FATAL_ARR_BIST : +case XE_GENL_GT_ERROR_FATAL_L3_DOUB : +case XE_GENL_GT_ERROR_FATAL_L3_ECC_CHK : +case XE_GENL_GT_ERROR_FATAL_IDI_PAR : +case XE_GENL_GT_ERROR_FATAL_SQIDI : +case XE_GENL_GT_ERROR_FATAL_SAMPLER : +case XE_GENL_GT_ERROR_FATAL_EU_IC : +return true; +default : +return false; + } +} + +static bool is_gsc_hw_error (const u64 config) +{ +if (config_counter (config) >=XE_GENL_GSC_ERROR_CORRECTABLE_SRAM_ECC && +config_counter (config) <=XE_GENL_GSC_ERROR_NONFATAL_AON_PARITY ) +return true; + +return false; +} + +static bool is_soc_error (const u64 config) +{ +if (config_counter (config) >=XE_GENL_SOC_ERROR_FATAL_PSF_CSC_0 && +config_counter (config) <=XE_GENL_PVC_SOC_ERROR_FATAL_HBM (1 ,15 )) +return true; + +return false; +} + +static int +config_status (struct xe_device *xe,u64 config) +{ +unsigned int gt_id =config_gt_id (config); +struct xe_gt *gt =xe_device_get_gt (xe, gt_id); + +if (!IS_DGFX (xe)) +return -ENODEV ; + +if (gt->info.type ==XE_GT_TYPE_UNINITIALIZED ) +return -ENOENT ; + +/* GSC HW ERRORS are present on root tile of +* platform supporting MEMORY SPARING only +*/ +if (is_gsc_hw_error (config) && !(xe->info.platform ==XE_PVC && !gt_id)) +return -ENODEV ; + +/* GT vectors error are valid on Platforms supporting error vectors only */ +if (is_gt_vector_error (config) && xe->info.platform !=XE_PVC ) +return -ENODEV ; + +/* Skip gt errors not supported on pvc */ +if (is_pvc_invalid_gt_errors (config) && xe->info.platform ==XE_PVC ) +return -ENODEV ; + +/* FATAL FPU error is valid on PVC only */ +if (config_counter (config) ==XE_GENL_GT_ERROR_FATAL_FPU && + !(xe->info.platform ==XE_PVC )) +return -ENODEV ; + +if (is_soc_error (config) && !(xe->info.platform ==XE_PVC )) +return -ENODEV ; + +return (config_counter (config) >= +ARRAY_SIZE (xe_hw_error_map)) ? -ENOENT :0 ; +} + +static u64 get_counter_value (struct xe_device *xe,u64 config) { +const unsigned int gt_id =config_gt_id (config); +struct xe_gt *gt =xe_device_get_gt (xe, gt_id); +unsigned int id =config_counter (config); + +if (is_gt_error (config) ||is_gt_vector_error (config)) +return gt->errors.count[xe_hw_error_map[id]]; + +return gt->tile->errors.count[xe_hw_error_map[id]]; +} + +int fill_error_details (struct xe_device *xe,struct genl_info *info,struct sk_buff *new_msg) +{ +struct nlattr *entry_attr; +bool counter = false; +struct xe_gt *gt; +int i, j; + +BUILD_BUG_ON (ARRAY_SIZE (xe_hw_error_events) != +ARRAY_SIZE (xe_hw_error_map)); + +if (info->genlhdr->cmd ==DRM_RAS_CMD_READ_ALL ) + counter = true; + + entry_attr =nla_nest_start (new_msg,DRM_RAS_ATTR_QUERY_REPLY ); +if (!entry_attr) +return -EMSGSIZE ; + +for_each_gt (gt, xe, j) { +char str[MAX_ERROR_NAME ]; +u64 val; + +for (i =0 ; i <ARRAY_SIZE (xe_hw_error_events); i++) { +u64 config =XE_HW_ERROR (j, i); + +if (config_status (xe, config)) +continue ; + +/* should this be cleared everytime */ +snprintf (str,sizeof (str),"error-gt%d-%s" , j, xe_hw_error_events[i]); + +if (nla_put_string (new_msg,DRM_RAS_ATTR_ERROR_NAME , str)) + goto err; +if (nla_put_u64_64bit (new_msg,DRM_RAS_ATTR_ERROR_ID , config,DRM_ATTR_PAD )) + goto err; +if (counter) { + val =get_counter_value (xe, config); +if (nla_put_u64_64bit (new_msg,DRM_RAS_ATTR_ERROR_VALUE , val,DRM_ATTR_PAD )) + goto err; + } + } + } + +nla_nest_end (new_msg, entry_attr); +return 0 ; +err: +drm_dbg_driver (&xe->drm,"msg buff is small\n" ); +nla_nest_cancel (new_msg, entry_attr); +nlmsg_free (new_msg); + +return -EMSGSIZE ; +} + +static int xe_genl_list_errors (struct drm_device *drm,struct sk_buff *msg,struct genl_info *info) +{ +struct xe_device *xe =to_xe_device (drm); +size_t msg_size =NLMSG_DEFAULT_SIZE ; +struct sk_buff *new_msg; +int retries =2 ; +void *usrhdr; +int ret =0 ; + +do { + new_msg =drm_genl_alloc_msg (drm, info, msg_size, &usrhdr); +if (!new_msg) +return -ENOMEM ; + + ret =fill_error_details (xe, info, new_msg); +if (!ret) +break ; + + msg_size +=NLMSG_DEFAULT_SIZE ; + }while (retries--); + +if (!ret) + ret =drm_genl_send (new_msg, info, usrhdr); + +return ret; }static int xe_genl_read_error (struct drm_device *drm,struct sk_buff *msg,struct genl_info *info) { -return 0 ; +struct xe_device *xe =to_xe_device (drm); +size_t msg_size =NLMSG_DEFAULT_SIZE ; +struct sk_buff *new_msg; +void *usrhdr; +int ret =0 ; +int retries =2 ; +u64 config, val; + + config =nla_get_u64 (info->attrs[DRM_RAS_ATTR_ERROR_ID ]); + ret =config_status (xe, config); +if (ret) +return ret; +do { + new_msg =drm_genl_alloc_msg (drm, info, msg_size, &usrhdr); +if (!new_msg) +return -ENOMEM ; + + val =get_counter_value (xe, config); +if (nla_put_u64_64bit (new_msg,DRM_RAS_ATTR_ERROR_VALUE , val,DRM_ATTR_PAD )) { + msg_size +=NLMSG_DEFAULT_SIZE ; +continue ; + } + +break ; + }while (retries--); + + ret =drm_genl_send (new_msg, info, usrhdr); + +return ret; }/* driver callbacks to DRM netlink commands*/
include/uapi/drm/xe_drm.h +61 -0
67 lines not on this page · raw message
Signature · 1 line
2.25.1
RFC 4/5 drm/netlink: Define multicast groups
In reply to Aravind IddamsettyNetlink subsystem supports event notifications to userspace. we define two multicast groups for correctable and uncorrectable errors to which userspace can subscribe and be notified when any of those errors happen. The group names are local to the driver's genl netlink family.
--- drivers/gpu/drm/drm_netlink.c | 2 ++ include/drm/drm_netlink.h | 10 ++++++++++ include/uapi/drm/drm_netlink.h | 4 ++++ 3 files changed, 16 insertions(+)
drivers/gpu/drm/drm_netlink.c +2 -0
@@ -124,6 +124,8 @@ static void drm_genl_family_init(struct drm_device *dev) dev->drm_genl_family.ops = drm_genl_ops; dev->drm_genl_family.n_ops =ARRAY_SIZE (drm_genl_ops); dev->drm_genl_family.maxattr =DRM_ATTR_MAX ; + dev->drm_genl_family.mcgrps = drm_event_mcgrps; + dev->drm_genl_family.n_mcgrps =ARRAY_SIZE (drm_event_mcgrps); dev->drm_genl_family.module = dev->dev->driver->owner; }
include/drm/drm_netlink.h +10 -0
@@ -28,6 +28,16 @@ static const struct nla_policy drm_attr_policy_read_one[DRM_ATTR_MAX + 1] = { [DRM_RAS_ATTR_ERROR_ID] = { .type = NLA_U64 }, }; +enum mcgrps_events { +DRM_GENL_MCAST_CORR_ERR , +DRM_GENL_MCAST_UNCORR_ERR , +}; + +static const struct genl_multicast_group drm_event_mcgrps[] = { + [DRM_GENL_MCAST_CORR_ERR ] = { .name =DRM_GENL_MCAST_GROUP_NAME_CORR_ERR , }, + [DRM_GENL_MCAST_UNCORR_ERR ] = { .name =DRM_GENL_MCAST_GROUP_NAME_UNCORR_ERR , }, +}; +int drm_genl_register (struct drm_device *dev);void drm_genl_exit (void );int drm_genl_send (struct sk_buff *msg,struct genl_info *info,void *usrhdr);
include/uapi/drm/drm_netlink.h +4 -0
@@ -26,6 +26,8 @@#define _DRM_NETLINK_H_#define DRM_GENL_VERSION 1 +#define DRM_GENL_MCAST_GROUP_NAME_CORR_ERR "drm_corr_err" +#define DRM_GENL_MCAST_GROUP_NAME_UNCORR_ERR "drm_uncorr_err"#if defined(__cplusplus)extern "C" {
@@ -43,6 +45,8 @@ enum drm_genl_error_cmds {DRM_RAS_CMD_READ_ONE ,/** @DRM_RAS_CMD_READ_ALL: Command to get counters of all errors */ DRM_RAS_CMD_READ_ALL , +/** @DRM_RAS_CMD_ERROR_EVENT: Command sent as part of multicast event */ +DRM_RAS_CMD_ERROR_EVENT , __DRM_CMD_MAX, DRM_CMD_MAX = __DRM_CMD_MAX - 1,
Signature · 1 line
2.25.1
RFC v2 5/5 drm/xe/RAS: send multicast event on occurrence of an error
In reply to Aravind IddamsettyWhenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups.
v2: Rebase
--- drivers/gpu/drm/xe/xe_hw_error.c | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
drivers/gpu/drm/xe/xe_hw_error.c +33 -0
@@ -773,6 +773,37 @@ xe_soc_hw_error_handler(struct xe_tile *tile, const enum hardware_error hw_err) (HARDWARE_ERROR_MAX << 1) + 1); } +static void +generate_netlink_event (struct xe_device *xe,const enum hardware_error hw_err) +{ +struct sk_buff *msg; +void *hdr; + +if (!xe->drm.drm_genl_family.module) +return ; + + msg =nlmsg_new (NLMSG_DEFAULT_SIZE ,GFP_ATOMIC ); +if (!msg) { +drm_dbg_driver (&xe->drm,"couldn't allocate memory for error multicast event\n" ); +return ; + } + + hdr =genlmsg_put (msg,0 ,0 , &xe->drm.drm_genl_family,0 ,DRM_RAS_CMD_ERROR_EVENT ); +if (!hdr) { +drm_dbg_driver (&xe->drm,"mutlicast msg buffer is small\n" ); +nlmsg_free (msg); +return ; + } + +genlmsg_end (msg, hdr); + +genlmsg_multicast (&xe->drm.drm_genl_family, msg,0 , + hw_err ? +DRM_GENL_MCAST_UNCORR_ERR + :DRM_GENL_MCAST_CORR_ERR , +GFP_ATOMIC ); +} +static void xe_hw_error_source_handler (struct xe_tile *tile,const enum hardware_error hw_err) {
@@ -826,6 +857,8 @@ xe_hw_error_source_handler(struct xe_tile *tile, const enum hardware_error hw_er }xe_mmio_write32 (mmio,DEV_ERR_STAT_REG (hw_err), errsrc); + +generate_netlink_event (tile_to_xe (tile), hw_err); unlock:spin_unlock_irqrestore (&tile_to_xe (tile)->irq.lock, flags); }
Signature · 1 line
2.25.1
Patchwork
CI[Intel-xe] ✗ CI.Patch_applied: failure for Proposal to use netlink for RAS and Telemetry across drm subsystem (rev3)
In reply to Aravind Iddamsetty== Series Details ==
== Series Details ==
Series: Proposal to use netlink for RAS and Telemetry across drm subsystem (rev3)
URL : https://patchwork.freedesktop.org/series/118435/
State : failure
== Summary ==
=== Applying kernel patches on branch 'drm-xe-next' with base: === Base commit: 3c4a322ad drm/xe: Add missing ADL entries to xe_test_wa === git am output follows ===
error: patch failed: include/drm/drm_device.h:326
error: include/drm/drm_device.h: patch does not apply .git/rebase-apply/patch:320: new blank line at EOF.
+
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: drm/netlink: Add netlink infrastructure
Patch failed at 0001 drm/netlink: Add netlink infrastructure When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".