Skip to contentSkip to conversation

ncurses: Mitigate CVE-2023-29491

PATCH In review Marek Vasut 2 participants 3 messages Oct 9, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ncurses: Mitigate CVE-2023-29491

Configure with "--disable-root-environ" to disallow loading of custom terminfo entries in setuid/setgid programs, mitigating the impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

---
 meta/recipes-core/ncurses/ncurses.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/ncurses/ncurses.inc +1 -0
index 1abcfae1fe..7e85044bdb 100644
@@ -87,6 +87,7 @@ ncurses_configure() {
 	        --enable-sigwinch \
 	        --enable-pc-files \
 	        --disable-rpath-hack \
+	        --disable-root-environ \
 		${EXCONFIG_ARGS} \
 	        --with-manpage-format=normal \
 	        --without-manpage-renames \
Signature · 1 line
2.40.1
#1 lore raw

Hi Marek,

Could you please describe why you add this configuration in kirkstone branch? This CVE is already patched:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/ncurses/files/CVE-2023-29491.patch?h=kirkstone

Peter

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Marek Vasut via lists.openembedded.org
Sent: Monday, October 9, 2023 18:32
To: [email protected]; [email protected]
Cc: Marek Vasut <[email protected]>
Subject: [OE-core] [kirkstone][PATCH] ncurses: Mitigate CVE-2023-29491

Quoted 24 lines

Configure with "--disable-root-environ" to disallow loading of custom terminfo entries in setuid/setgid programs, mitigating the impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

---
 meta/recipes-core/ncurses/ncurses.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/ncurses/ncurses.inc +1 -1
index 1abcfae1fe..7e85044bdb 100644
@@ -87,6 +87,7 @@ ncurses_configure() {
 	        --enable-sigwinch \
 	        --enable-pc-files \
 	        --disable-rpath-hack \
+	        --disable-root-environ \
 		${EXCONFIG_ARGS} \
 	        --with-manpage-format=normal \
 	        --without-manpage-renames \
--

2.40.1

#2 lore raw
Quoted 25 lines · Peter

Hi Marek,

Could you please describe why you add this configuration in kirkstone branch? This CVE is already patched:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/ncurses/files/CVE-2023-29491.patch?h=kirkstone

Peter

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Marek Vasut via lists.openembedded.org
Sent: Monday, October 9, 2023 18:32
To: [email protected]; [email protected]
Cc: Marek Vasut <[email protected]>
Subject: [OE-core] [kirkstone][PATCH] ncurses: Mitigate CVE-2023-29491

Quoted 10 lines

Configure with "--disable-root-environ" to disallow loading of custom terminfo entries in setuid/setgid programs, mitigating the impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

---
  meta/recipes-core/ncurses/ncurses.inc | 1 +
  1 file changed, 1 insertion(+)
Quoted 12 lines

meta/recipes-core/ncurses/ncurses.inc ncurses_configure() { · line 93

Quoted 12 lines
meta/recipes-core/ncurses/ncurses.inc +1 -0
index 1abcfae1fe..7e85044bdb 100644
@@ -87,6 +87,7 @@ ncurses_configure() {
  	        --enable-sigwinch \
  	        --enable-pc-files \
  	        --disable-rpath-hack \
+	        --disable-root-environ \
  		${EXCONFIG_ARGS} \
  	        --with-manpage-format=normal \
  	        --without-manpage-renames \

See my reply to the master branch patch.