Skip to contentSkip to conversation

sched/headers: remove comment referring to cpu_load since this has been removed

PATCH Applied Colin Ian King 2 participants 3 messages Oct 10, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/headers: remove comment referring to cpu_load since this has been removed

There is a comment that refers to cpu_load, however, this cpu_load was removed with commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]") back in 2019. The comment does not make sense with respect to this removed array, so remove the comment.

---
 kernel/sched/sched.h | 4 ----
 1 file changed, 4 deletions(-)
kernel/sched/sched.h +0 -4
index faf9031422e1..65cad0e5729e 100644
@@ -948,10 +948,6 @@ struct rq {
 	/* runqueue lock: */
 	raw_spinlock_t		__lock;
 
-	/*
-	 * nr_running and cpu_load should be in the same cacheline because
-	 * remote CPUs use both these fields when doing load calculation.
-	 */
 	unsigned int		nr_running;
 #ifdef CONFIG_NUMA_BALANCING
 	unsigned int		nr_numa_running;
Signature · 1 line
2.39.2
merge bot Applied
#1 lore raw

[tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, since this has been removed

The following commit has been merged into the sched/core branch of tip:

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     2616fdce9b8c7815d5578b28aea98595ebd0f290
Gitweb:        https://git.kernel.org/tip/2616fdce9b8c7815d5578b28aea98595ebd0f290
Author:        Colin Ian King <[email protected]>
AuthorDate:    Tue, 10 Oct 2023 16:57:44 +01:00
Committer:     Ingo Molnar <[email protected]>
CommitterDate: Tue, 10 Oct 2023 23:29:14 +02:00

sched/headers: Remove comment referring to rq::cpu_load, since this has been removed

There is a comment that refers to cpu_load, however, this cpu_load was removed with:

55627e3cd22c ("sched/core: Remove rq->cpu_load[]")

... back in 2019. The comment does not make sense with respect to this removed array, so remove the comment.

---
 kernel/sched/sched.h | 4 ----
 1 file changed, 4 deletions(-)
kernel/sched/sched.h +0 -4
index faf9031..65cad0e 100644
@@ -948,10 +948,6 @@ struct rq {
 	/* runqueue lock: */
 	raw_spinlock_t		__lock;
 
-	/*
-	 * nr_running and cpu_load should be in the same cacheline because
-	 * remote CPUs use both these fields when doing load calculation.
-	 */
 	unsigned int		nr_running;
 #ifdef CONFIG_NUMA_BALANCING
 	unsigned int		nr_numa_running;
merge bot Applied
#2 lore raw

[tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, since this has been removed

In reply to Colin Ian King
The following commit has been merged into the sched/core branch of tip:

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     b19fdb16fb2167c6bc9ee8fbc0c1d2d4fd3e2eb8
Gitweb:        https://git.kernel.org/tip/b19fdb16fb2167c6bc9ee8fbc0c1d2d4fd3e2eb8
Author:        Colin Ian King <[email protected]>
AuthorDate:    Tue, 10 Oct 2023 16:57:44 +01:00
Committer:     Ingo Molnar <[email protected]>
CommitterDate: Tue, 10 Oct 2023 23:42:20 +02:00

sched/headers: Remove comment referring to rq::cpu_load, since this has been removed

There is a comment that refers to cpu_load, however, this cpu_load was removed with:

55627e3cd22c ("sched/core: Remove rq->cpu_load[]")

... back in 2019. The comment does not make sense with respect to this removed array, so remove the comment.

---
 kernel/sched/sched.h | 4 ----
 1 file changed, 4 deletions(-)
kernel/sched/sched.h +0 -4
index faf9031..65cad0e 100644
@@ -948,10 +948,6 @@ struct rq {
 	/* runqueue lock: */
 	raw_spinlock_t		__lock;
 
-	/*
-	 * nr_running and cpu_load should be in the same cacheline because
-	 * remote CPUs use both these fields when doing load calculation.
-	 */
 	unsigned int		nr_running;
 #ifdef CONFIG_NUMA_BALANCING
 	unsigned int		nr_numa_running;