pinctrl: cherryview: reduce scope of PIN_CONFIG_BIAS_HIGH_IMPEDANCE case
Subsystems (3)
PATCH 1/1 pinctrl: cherryview: reduce scope of PIN_CONFIG_BIAS_HIGH_IMPEDANCE case
We have a couple of pinconfig cases inside the braces which are meant for PIN_CONFIG_BIAS_HIGH_IMPEDANCE case. Although it is valid C, it makes the code less readable and prone to misinterpretation. Limit the braces to PIN_CONFIG_BIAS_HIGH_IMPEDANCE case to avoid this.
Signed-off-by Raag Jadav <[email protected]>
Acked-by Mika Westerberg <[email protected]>
--- drivers/pinctrl/intel/pinctrl-cherryview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/pinctrl-cherryview.c +1 -1
@@ -894,6 +894,7 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin,return -EINVAL ;break ; + }case PIN_CONFIG_DRIVE_PUSH_PULL :if (ctrl1 &CHV_PADCTRL1_ODEN )
@@ -904,7 +905,6 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin,if (!(ctrl1 &CHV_PADCTRL1_ODEN ))return -EINVAL ;break ; - }default :return -ENOTSUPP ;
base-commit: 55176feaa4d8f7d07005c6199d7843bc2991773d
Signature · 1 line
2.17.1
Quoted 4 lines · Raag Jadav
We have a couple of pinconfig cases inside the braces which are meant for
PIN_CONFIG_BIAS_HIGH_IMPEDANCEcase. Although it is valid C, it makes the code less readable and prone to misinterpretation. Limit the braces toPIN_CONFIG_BIAS_HIGH_IMPEDANCEcase to avoid this.
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko