Skip to contentSkip to conversation

oeqa/qemurunner: Ensure we retry after BrokenPipeError

PATCH New Richard Purdie 1 participant 1 message Oct 11, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 oeqa/qemurunner: Ensure we retry after BrokenPipeError

If the BrokenPipeError occurs when writing to the serial port to wake it up, defer the write and try again (which will happen on the 5s timeout of the select call). Why it should return ESHUTDOWN and then work later I'm not sure but it does appear to make it work. For now we need 'working' QA tests whilst the issue is debugged.

---
 meta/lib/oeqa/utils/qemurunner.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oeqa/utils/qemurunner.py +1 -1
index cb3231da63b..a52fa41768f 100644
@@ -465,9 +465,9 @@ class QemuRunner:
                 self.logger.warning('Probing the serial port to wake it up!')
                 try:
                     self.server_socket.sendall(bytes("\n\n", "utf-8"))
+                    sentnewlines = True
                 except BrokenPipeError as e:
                     self.logger.debug('Probe failed %s' % repr(e))
-                sentnewlines = True
             for file in sread:
                 if file is self.server_socket:
                     qemusock, addr = self.server_socket.accept()
Signature · 1 line
2.39.2