Skip to contentSkip to conversation

hardening: x86: drop reference to removed config AMD_IOMMU_V2

PATCH Applied Lukas Bulwahn 4 participants 5 messages Oct 12, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hardening: x86: drop reference to removed config AMD_IOMMU_V2

Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the config AMD_IOMMU_V2.

Remove the reference to this config in the x86 architecture-specific hardening config fragment as well.

---
Joerg, please pick this patch on top of the commit above. Thanks.

 arch/x86/configs/hardening.config | 1 -
 1 file changed, 1 deletion(-)
arch/x86/configs/hardening.config +0 -1
index 19bb0c7a7669..7b497f3b7bc3 100644
@@ -9,7 +9,6 @@ CONFIG_INTEL_IOMMU=y
 CONFIG_INTEL_IOMMU_DEFAULT_ON=y
 CONFIG_INTEL_IOMMU_SVM=y
 CONFIG_AMD_IOMMU=y
-CONFIG_AMD_IOMMU_V2=y
 
 # Enable CET Shadow Stack for userspace.
 CONFIG_X86_USER_SHADOW_STACK=y
Signature · 1 line
2.17.1
#1 lore raw
Quoted 11 lines · Lukas Bulwahn

Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the config AMD_IOMMU_V2.

Remove the reference to this config in the x86 architecture-specific hardening config fragment as well.

---
Joerg, please pick this patch on top of the commit above. Thanks.

 arch/x86/configs/hardening.config | 1 -

Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I missing something?

-Vasant

Quoted 14 lines
 1 file changed, 1 deletion(-)
arch/x86/configs/hardening.config +0 -1
index 19bb0c7a7669..7b497f3b7bc3 100644
@@ -9,7 +9,6 @@ CONFIG_INTEL_IOMMU=y
 CONFIG_INTEL_IOMMU_DEFAULT_ON=y
 CONFIG_INTEL_IOMMU_SVM=y
 CONFIG_AMD_IOMMU=y
-CONFIG_AMD_IOMMU_V2=y
 
 # Enable CET Shadow Stack for userspace.
 CONFIG_X86_USER_SHADOW_STACK=y
#2 lore raw
Quoted 9 lines · Vasant Hegde
Quoted 6 lines · Lukas Bulwahn

Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the config AMD_IOMMU_V2.

Remove the reference to this config in the x86 architecture-specific hardening config fragment as well.

Quoted 9 lines
Quoted 5 lines

---
Joerg, please pick this patch on top of the commit above. Thanks.

 arch/x86/configs/hardening.config | 1 -

Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I missing something?

It was added on Aug 24 in linux-next.

regards,
dan carpenter

Reviewed-by
#3 lore raw
Quoted 14 lines · Dan Carpenter
Quoted 13 lines · Vasant Hegde
Quoted 10 lines · Lukas Bulwahn

Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the config AMD_IOMMU_V2.

Remove the reference to this config in the x86 architecture-specific hardening config fragment as well.

---
Joerg, please pick this patch on top of the commit above. Thanks.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
 arch/x86/configs/hardening.config | 1 -

Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I missing something?

It was added on Aug 24 in linux-next.

Thanks Dan. I can see the patch in linux-next.

-Vasant

Applied
#4 lore raw
In reply to Lukas Bulwahn
Quoted 8 lines · Lukas Bulwahn

Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the config AMD_IOMMU_V2.

Remove the reference to this config in the x86 architecture-specific hardening config fragment as well.

[...]

Applied to for-next/hardening, thanks!

[1/1] hardening: x86: drop reference to removed config AMD_IOMMU_V2

      https://git.kernel.org/kees/c/faed498d0db7

Take care,

Signature · 1 line
Kees Cook