Skip to contentSkip to conversation

dt-bindings: clocks: qcom,gcc-ipq8074: allow QMP PCI PHY PIPE clocks

PATCH Applied Robert Marko 3 participants 4 messages Oct 13, 2023 – Dec 3, 2023

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 dt-bindings: clocks: qcom,gcc-ipq8074: allow QMP PCI PHY PIPE clocks

QMP PCI PHY PIPE clocks are inputs for the GCC clock controller. In order to describe this in DTS, allow passing them as the inputs to GCC.

This has a benefit that it avoids doing a global matching by name.

---
Changes in v3:
* Change the commit message to describe the relationship between PIPE clocks and GCC controller

 Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml +4 -0
index 52e7831a8d6d..2d44ddc45aab 100644
@@ -27,11 +27,15 @@ properties:
     items:
       - description: board XO clock
       - description: sleep clock
+      - description: Gen3 QMP PCIe PHY PIPE clock
+      - description: Gen2 QMP PCIe PHY PIPE clock
 
   clock-names:
     items:
       - const: xo
       - const: sleep_clk
+      - const: pcie0_pipe
+      - const: pcie1_pipe
 
 required:
   - compatible
Signature · 1 line
2.41.0
#1 lore raw

PATCH v3 2/2 arm64: dts: qcom: ipq8074: pass QMP PCI PHY PIPE clocks to GCC

Pass QMP PCI PHY PIPE clocks to the GCC controller so it does not have to find them by matching globaly by name.

If not passed directly, driver maintains backwards compatibility by then falling back to global lookup.

---
Changes in v2:
* Make clocks and clock-names one-per-line

 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +8 -2
index 38fcb2675b9a..d8e8a5cded64 100644
@@ -579,8 +579,14 @@ qpic_pins: qpic-state {
 		gcc: gcc@1800000 {
 			compatible = "qcom,gcc-ipq8074";
 			reg = <0x01800000 0x80000>;
-			clocks = <&xo>, <&sleep_clk>;
-			clock-names = "xo", "sleep_clk";
+			clocks = <&xo>,
+				 <&sleep_clk>,
+				 <&pcie_qmp0>,
+				 <&pcie_qmp1>;
+			clock-names = "xo",
+				      "sleep_clk",
+				      "pcie0_pipe",
+				      "pcie1_pipe";
 			#clock-cells = <1>;
 			#power-domain-cells = <1>;
 			#reset-cells = <1>;
Signature · 1 line
2.41.0
Reviewed-by on v3 2/2
#2 lore raw

Re: [PATCH v3 2/2] arm64: dts: qcom: ipq8074: pass QMP PCI PHY PIPE clocks to GCC

Quoted 7 lines · Robert Marko

Pass QMP PCI PHY PIPE clocks to the GCC controller so it does not have to find them by matching globaly by name.

If not passed directly, driver maintains backwards compatibility by then falling back to global lookup.

Quoted 7 lines

---
Changes in v2:
* Make clocks and clock-names one-per-line

 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Signature · 2 lines
With best wishes
Dmitry
maintainer Applied
#3 lore raw

Re: (subset) [PATCH v3 1/2] dt-bindings: clocks: qcom,gcc-ipq8074: allow QMP PCI PHY PIPE clocks

In reply to Robert Marko
Quoted 6 lines · Robert Marko

QMP PCI PHY PIPE clocks are inputs for the GCC clock controller. In order to describe this in DTS, allow passing them as the inputs to GCC.

This has a benefit that it avoids doing a global matching by name.

Applied, thanks!

[1/2] dt-bindings: clocks: qcom,gcc-ipq8074: allow QMP PCI PHY PIPE clocks

      commit: afc4f14be33c50f066392f1e9671473419ba7ded
[2/2] arm64: dts: qcom: ipq8074: pass QMP PCI PHY PIPE clocks to GCC
      commit: 591da388c344f934601548cb44f54eab012c6c94

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>