Skip to contentSkip to conversation

staging: rtl8192u: Remove broken driver

PATCH Superseded Philipp Hortmann 2 participants 2 messages Oct 14, 2023 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192u: Remove broken driver

Tests on rtl8192u hardware have shown that this driver is broken since 2016. Remove broken driver. Find fix for two of the bugs in mailing list:
("[RFC PATCH 0/2] staging: rtl8192u: Fix two crashing bugs")

---
Did not find any artifacts of rtl8192u in MAINTAINERS.

---
 drivers/staging/Kconfig                       |    2 -
 drivers/staging/rtl8192u/Kconfig              |   12 -
 drivers/staging/rtl8192u/Makefile             |   27 -
 drivers/staging/rtl8192u/TODO                 |   16 -
 drivers/staging/rtl8192u/authors              |    1 -
 drivers/staging/rtl8192u/changes              |    4 -
 drivers/staging/rtl8192u/ieee80211/dot11d.c   |  174 -
 drivers/staging/rtl8192u/ieee80211/dot11d.h   |   57 -
 .../staging/rtl8192u/ieee80211/ieee80211.h    | 2385 --------
 .../rtl8192u/ieee80211/ieee80211_crypt.c      |  235 -
 .../rtl8192u/ieee80211/ieee80211_crypt.h      |   86 -
 .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c |  421 --
 .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c |  718 ---
 .../rtl8192u/ieee80211/ieee80211_crypt_wep.c  |  247 -
 .../rtl8192u/ieee80211/ieee80211_module.c     |  287 -
 .../staging/rtl8192u/ieee80211/ieee80211_rx.c | 2430 ---------
 .../rtl8192u/ieee80211/ieee80211_softmac.c    | 3056 -----------
 .../rtl8192u/ieee80211/ieee80211_softmac_wx.c |  598 --
 .../staging/rtl8192u/ieee80211/ieee80211_tx.c |  839 ---
 .../staging/rtl8192u/ieee80211/ieee80211_wx.c |  810 ---
 .../staging/rtl8192u/ieee80211/rtl819x_BA.h   |   54 -
 .../rtl8192u/ieee80211/rtl819x_BAProc.c       |  700 ---
 .../staging/rtl8192u/ieee80211/rtl819x_HT.h   |  302 --
 .../rtl8192u/ieee80211/rtl819x_HTProc.c       | 1295 -----
 .../staging/rtl8192u/ieee80211/rtl819x_Qos.h  |   82 -
 .../staging/rtl8192u/ieee80211/rtl819x_TS.h   |  102 -
 .../rtl8192u/ieee80211/rtl819x_TSProc.c       |  534 --
 drivers/staging/rtl8192u/r8180_93cx6.c        |  170 -
 drivers/staging/rtl8192u/r8180_93cx6.h        |   25 -
 drivers/staging/rtl8192u/r8190_rtl8256.c      |  294 -
 drivers/staging/rtl8192u/r8190_rtl8256.h      |   24 -
 drivers/staging/rtl8192u/r8192U.h             | 1129 ----
 drivers/staging/rtl8192u/r8192U_core.c        | 4800 -----------------
 drivers/staging/rtl8192u/r8192U_debugfs.c     |  188 -
 drivers/staging/rtl8192u/r8192U_dm.c          | 2821 ----------
 drivers/staging/rtl8192u/r8192U_dm.h          |  176 -
 drivers/staging/rtl8192u/r8192U_hw.h          |  246 -
 drivers/staging/rtl8192u/r8192U_wx.c          |  943 ----
 drivers/staging/rtl8192u/r8192U_wx.h          |   24 -
 drivers/staging/rtl8192u/r819xU_cmdpkt.c      |  508 --
 drivers/staging/rtl8192u/r819xU_cmdpkt.h      |  190 -
 drivers/staging/rtl8192u/r819xU_firmware.c    |  340 --
 drivers/staging/rtl8192u/r819xU_firmware.h    |   19 -
 .../staging/rtl8192u/r819xU_firmware_img.c    |  549 --
 .../staging/rtl8192u/r819xU_firmware_img.h    |   26 -
 drivers/staging/rtl8192u/r819xU_phy.c         | 1646 ------
 drivers/staging/rtl8192u/r819xU_phy.h         |   81 -
 drivers/staging/rtl8192u/r819xU_phyreg.h      |  143 -
 48 files changed, 29816 deletions(-)
 delete mode 100644 drivers/staging/rtl8192u/Kconfig
 delete mode 100644 drivers/staging/rtl8192u/Makefile
 delete mode 100644 drivers/staging/rtl8192u/TODO
 delete mode 100644 drivers/staging/rtl8192u/authors
 delete mode 100644 drivers/staging/rtl8192u/changes
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/dot11d.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/dot11d.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
 delete mode 100644 drivers/staging/rtl8192u/r8180_93cx6.c
 delete mode 100644 drivers/staging/rtl8192u/r8180_93cx6.h
 delete mode 100644 drivers/staging/rtl8192u/r8190_rtl8256.c
 delete mode 100644 drivers/staging/rtl8192u/r8190_rtl8256.h
 delete mode 100644 drivers/staging/rtl8192u/r8192U.h
 delete mode 100644 drivers/staging/rtl8192u/r8192U_core.c
 delete mode 100644 drivers/staging/rtl8192u/r8192U_debugfs.c
 delete mode 100644 drivers/staging/rtl8192u/r8192U_dm.c
 delete mode 100644 drivers/staging/rtl8192u/r8192U_dm.h
 delete mode 100644 drivers/staging/rtl8192u/r8192U_hw.h
 delete mode 100644 drivers/staging/rtl8192u/r8192U_wx.c
 delete mode 100644 drivers/staging/rtl8192u/r8192U_wx.h
 delete mode 100644 drivers/staging/rtl8192u/r819xU_cmdpkt.c
 delete mode 100644 drivers/staging/rtl8192u/r819xU_cmdpkt.h
 delete mode 100644 drivers/staging/rtl8192u/r819xU_firmware.c
 delete mode 100644 drivers/staging/rtl8192u/r819xU_firmware.h
 delete mode 100644 drivers/staging/rtl8192u/r819xU_firmware_img.c
 delete mode 100644 drivers/staging/rtl8192u/r819xU_firmware_img.h
 delete mode 100644 drivers/staging/rtl8192u/r819xU_phy.c
 delete mode 100644 drivers/staging/rtl8192u/r819xU_phy.h
 delete mode 100644 drivers/staging/rtl8192u/r819xU_phyreg.h
drivers/staging/Kconfig +0 -2
index f9aef39cac2e..21a158dabe6c 100644
@@ -28,8 +28,6 @@ source "drivers/staging/wlan-ng/Kconfig"
 
 source "drivers/staging/olpc_dcon/Kconfig"
 
-source "drivers/staging/rtl8192u/Kconfig"
-
 source "drivers/staging/rtl8192e/Kconfig"
 
 source "drivers/staging/rtl8723bs/Kconfig"
drivers/staging/rtl8192u/Kconfig deleted +0 -12
deleted file mode 100644
index f3b112a058ca..000000000000
@@ -1,12 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config RTL8192U
-	tristate "RealTek RTL8192U Wireless LAN NIC driver"
-	depends on PCI && WLAN && USB
-	depends on m
-	select WIRELESS_EXT
-	select WEXT_PRIV
-	select CRC32
-	select CRYPTO
-	select CRYPTO_AES
-	select CRYPTO_CCM
-	select CRYPTO_LIB_ARC4
drivers/staging/rtl8192u/Makefile deleted +0 -27
deleted file mode 100644
index d32dfd89a606..000000000000
@@ -1,27 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-NIC_SELECT = RTL8192U
-
-ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
-ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
-ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
-
-r8192u_usb-y := r8192U_core.o r8180_93cx6.o r8192U_wx.o		\
-		  r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o	\
-		  r819xU_cmdpkt.o r8192U_dm.o r819xU_firmware_img.o	\
-		  r8192U_debugfs.o					\
-		  ieee80211/ieee80211_crypt.o				\
-		  ieee80211/ieee80211_crypt_tkip.o			\
-		  ieee80211/ieee80211_crypt_ccmp.o			\
-		  ieee80211/ieee80211_crypt_wep.o			\
-		  ieee80211/ieee80211_rx.o				\
-		  ieee80211/ieee80211_softmac.o				\
-		  ieee80211/ieee80211_tx.o				\
-		  ieee80211/ieee80211_wx.o				\
-		  ieee80211/ieee80211_module.o				\
-		  ieee80211/ieee80211_softmac_wx.o			\
-		  ieee80211/rtl819x_HTProc.o				\
-		  ieee80211/rtl819x_TSProc.o				\
-		  ieee80211/rtl819x_BAProc.o				\
-		  ieee80211/dot11d.o
-
-obj-$(CONFIG_RTL8192U) += r8192u_usb.o
drivers/staging/rtl8192u/TODO deleted +0 -16
deleted file mode 100644
index ab9d5d145b3b..000000000000
@@ -1,16 +0,0 @@
-To-do list:
-
-* Correct the coding style according to Linux guidelines; please read the document
-  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
-* Remove unnecessary debugging/printing macros; for those that are still needed
-  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
-* Remove dead code such as unusued functions, variables, fields, etc..
-* Use in-kernel API and remove unnecessary wrappers where possible.
-* Fix bugs due to code that sleeps in atomic context.
-* Remove the HAL layer and migrate its functionality into the relevant parts of
-  the driver.
-* Switch to use LIB80211.
-* Switch to use MAC80211.
-* Switch to use CFG80211.
-* Improve the error handling of various functions, particularly those that use
-  existing kernel APIs.
drivers/staging/rtl8192u/authors deleted +0 -1
deleted file mode 100644
index 0fab11228b48..000000000000
@@ -1 +0,0 @@
-Andrea Merello <[email protected]>
drivers/staging/rtl8192u/changes deleted +0 -4
deleted file mode 100644
index 0485d6eec7b5..000000000000
@@ -1,4 +0,0 @@
-v 0.1
-
-First version.
-This is based on the rtl8180-sa2400 pre-0.22-CVS code..
drivers/staging/rtl8192u/ieee80211/dot11d.c deleted +0 -174

174 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/dot11d.h deleted +0 -57

57 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211.h deleted +0 -2385

2,385 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c deleted +0 -235

235 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h deleted +0 -86

81 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c deleted +0 -421

421 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c deleted +0 -718

718 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c deleted +0 -247

247 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_module.c deleted +0 -287

287 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c deleted +0 -2430

2,430 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c deleted +0 -3056

3,056 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c deleted +0 -598

598 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c deleted +0 -839

839 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c deleted +0 -810

810 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h deleted +0 -54

54 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c deleted +0 -700

700 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h deleted +0 -302

302 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c deleted +0 -1295

1,295 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h deleted +0 -82

82 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h deleted +0 -102

102 lines not on this page · raw message

drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c deleted +0 -534

534 lines not on this page · raw message

drivers/staging/rtl8192u/r8180_93cx6.c deleted +0 -170

170 lines not on this page · raw message

drivers/staging/rtl8192u/r8180_93cx6.h deleted +0 -25
deleted file mode 100644
index 0cdd00a4f7b8..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8192u/r8190_rtl8256.c deleted +0 -294

294 lines not on this page · raw message

drivers/staging/rtl8192u/r8190_rtl8256.h deleted +0 -24
deleted file mode 100644
index 9ea67f86f911..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8192u/r8192U.h deleted +0 -1129

1,129 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_core.c deleted +0 -4800

4,800 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_debugfs.c deleted +0 -188

188 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_dm.c deleted +0 -2821

2,821 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_dm.h deleted +0 -176

176 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_hw.h deleted +0 -246

246 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_wx.c deleted +0 -943

943 lines not on this page · raw message

drivers/staging/rtl8192u/r8192U_wx.h deleted +0 -24
deleted file mode 100644
index 27423cd64b4c..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8192u/r819xU_cmdpkt.c deleted +0 -508

508 lines not on this page · raw message

drivers/staging/rtl8192u/r819xU_cmdpkt.h deleted +0 -190

190 lines not on this page · raw message

drivers/staging/rtl8192u/r819xU_firmware.c deleted +0 -340

340 lines not on this page · raw message

drivers/staging/rtl8192u/r819xU_firmware.h deleted +0 -19
deleted file mode 100644
index b84344c1e62b..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8192u/r819xU_firmware_img.c deleted +0 -549

549 lines not on this page · raw message

drivers/staging/rtl8192u/r819xU_firmware_img.h deleted +0 -26
deleted file mode 100644
index 61585a72465e..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8192u/r819xU_phy.c deleted +0 -1646

1,646 lines not on this page · raw message

drivers/staging/rtl8192u/r819xU_phy.h deleted +0 -81

81 lines not on this page · raw message

drivers/staging/rtl8192u/r819xU_phyreg.h deleted +0 -143

143 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.42.0

Part of the diff is not shown here. View the raw message.

Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Philipp Hortmann

Tests on rtl8192u hardware have shown that this driver is broken since 2016. Remove broken driver. Find fix for two of the bugs in mailing list:
("[RFC PATCH 0/2] staging: rtl8192u: Fix two crashing bugs")

Looks good to me, but I'd suggest adding the links to the patch you mention and the discussion: