Skip to contentSkip to conversation

staging: qlge: Replace the occurrences of (1<<x) by BIT(x)

PATCH In review Nandha Kumar Singaram 2 participants 3 messages Oct 15, 2023 – Oct 17, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: qlge: Replace the occurrences of (1<<x) by BIT(x)

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Prefer using the BIT macro

---
 drivers/staging/qlge/qlge.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/qlge/qlge.h +2 -2
index d0dd659834ee..69c5b332fd7c 100644
@@ -1273,7 +1273,7 @@ struct qlge_net_req_iocb {
  */
 struct wqicb {
 	__le16 len;
-#define Q_LEN_V		(1 << 4)
+#define Q_LEN_V		BIT(4)
 #define Q_LEN_CPP_CONT	0x0000
 #define Q_LEN_CPP_16	0x0001
 #define Q_LEN_CPP_32	0x0002
@@ -1308,7 +1308,7 @@ struct cqicb {
 #define FLAGS_LI	0x40
 #define FLAGS_LC	0x80
 	__le16 len;
-#define LEN_V		(1 << 4)
+#define LEN_V		BIT(4)
 #define LEN_CPP_CONT	0x0000
 #define LEN_CPP_32	0x0001
 #define LEN_CPP_64	0x0002
Signature · 1 line
2.25.1
reviewer
#1 lore raw
Quoted 4 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Prefer using the BIT macro

Hi Nandha,

I am assuming that checkpatch clean ups are acceptable, perhaps even desired, in staging. So this patch seems appropriate to me.

I do, however, see a lot more potential uses of BIT() in qlge.h. Could you take a second look?

...

#2 lore raw
Quoted 8 lines · Simon Horman
Quoted 4 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Prefer using the BIT macro

Hi Nandha,

Quoted 7 lines

I am assuming that checkpatch clean ups are acceptable, perhaps even desired, in staging. So this patch seems appropriate to me.

I do, however, see a lot more potential uses of BIT() in qlge.h. Could you take a second look?

...

Hi Simon,

I will look into it and update the patch

Thanks,
Nandha Kumar Singaram