Skip to contentSkip to conversation

arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible

PATCH Applied Johan Hovold 4 participants 4 messages Oct 16, 2023 – Dec 3, 2023

Subsystems (4)
Stable branch Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible

The sc8280xp Display Port PHYs can be used in either DP or eDP mode and this is configured using the devicetree compatible string which defaults to DP mode in the SoC dtsi.

Override the default compatible string for the CRD eDP PHY node so that the eDP settings are used.

Fixes 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
Cc [email protected] # 6.3
Signed-off-by Johan Hovold <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +2 -0
index 772953dc428e..31a2a2d27f4e 100644
@@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
 };
 
 &mdss0_dp3_phy {
+	compatible = "qcom,sc8280xp-edp-phy";
+
 	vdda-phy-supply = <&vreg_l6b>;
 	vdda-pll-supply = <&vreg_l3b>;
Signature · 1 line
2.41.0
#1 lore raw
Quoted 20 lines · Johan Hovold

The sc8280xp Display Port PHYs can be used in either DP or eDP mode and this is configured using the devicetree compatible string which defaults to DP mode in the SoC dtsi.

Override the default compatible string for the CRD eDP PHY node so that the eDP settings are used.

Fixes 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
Cc [email protected] # 6.3
Signed-off-by Johan Hovold <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +0 -0
index 772953dc428e..31a2a2d27f4e 100644

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts mdss0_dp3_out: endpoint { · line 461

Quoted 4 lines
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +1 -0
@@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
 };
 
 &mdss0_dp3_phy {
+       compatible = "qcom,sc8280xp-edp-phy";

Same question here as the one I've sent for Konrad's patch. Is it the same PHY type, just being repurposed for eDP or is it a different PHY type?

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +1 -1
+
        vdda-phy-supply = <&vreg_l6b>;
        vdda-pll-supply = <&vreg_l3b>;
 
--

2.41.0

Signature · 2 lines
With best wishes
Dmitry
#2 lore raw
Quoted 23 lines · Dmitry Baryshkov
Quoted 22 lines · Johan Hovold

The sc8280xp Display Port PHYs can be used in either DP or eDP mode and this is configured using the devicetree compatible string which defaults to DP mode in the SoC dtsi.

Override the default compatible string for the CRD eDP PHY node so that the eDP settings are used.

Fixes 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
Cc [email protected] # 6.3
Signed-off-by Johan Hovold <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +0 -0
index 772953dc428e..31a2a2d27f4e 100644
@@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
 };
Quoted 6 lines

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts mdss0_dp3_out: endpoint { · line 461

Quoted 2 lines
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +1 -0
 &mdss0_dp3_phy {
+       compatible = "qcom,sc8280xp-edp-phy";

Same question here as the one I've sent for Konrad's patch. Is it the same PHY type, just being repurposed for eDP or is it a different PHY type?

Just replied in the other thread:

	https://lore.kernel.org/lkml/[email protected]/

Johan

maintainer Applied
#3 lore raw
In reply to Johan Hovold
Quoted 8 lines · Johan Hovold

The sc8280xp Display Port PHYs can be used in either DP or eDP mode and this is configured using the devicetree compatible string which defaults to DP mode in the SoC dtsi.

Override the default compatible string for the CRD eDP PHY node so that the eDP settings are used.

[...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible

      commit: 663affdb12b3e26c77d103327cf27de720c8117e

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>