crypto: qcom: add HW_RANDOM dependency
PATCH 1/1 crypto: qcom: add HW_RANDOM dependency
From: Arnd Bergmann <[email protected]>
The driver now calls into the hwrng subsystem and causes a link failure if that is not reachable:
x86_64-linux-ld: vmlinux.o: in function `qcom_rng_probe':
qcom-rng.c:(.text+0xfefc7e): undefined reference to `devm_hwrng_register'
Add a Kconfig dependency as we have for the pure hw_random drivers. I see that there are some other crypto drivers that instead use 'select HW_RANDOM', but those seem to be mistakes as that may lead to circular dependencies, and a simple driver should not force-enable an entire subsytem.
--- drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/crypto/Kconfig +1 -0
@@ -601,6 +601,7 @@ config CRYPTO_DEV_QCE_SW_MAX_LEN config CRYPTO_DEV_QCOM_RNG tristate "Qualcomm Random Number Generator Driver" depends on ARCH_QCOM || COMPILE_TEST + depends on HW_RANDOM select CRYPTO_RNG help This driver provides support for the Random Number
Signature · 1 line
2.39.2
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The driver now calls into the hwrng subsystem and causes a link failure if that is not reachable:
x86_64-linux-ld: vmlinux.o: in function `qcom_rng_probe':
qcom-rng.c:(.text+0xfefc7e): undefined reference to `devm_hwrng_register'
Quoted 8 lines
Add a
Kconfigdependency as we have for the purehw_randomdrivers. I see that there are some other crypto drivers that instead use 'selectHW_RANDOM', but those seem to be mistakes as that may lead to circular dependencies, and a simple driver should not force-enable an entire subsytem.Fixes f29cd5bb64c25 ("crypto: qcom-rng - Add hw_random interface support")Signed-off-by Arnd Bergmann <[email protected]>---
Quoted 15 lines
drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/crypto/Kconfig +1
-0@@ -601,6 +601,7 @@ config CRYPTO_DEV_QCE_SW_MAX_LEN config CRYPTO_DEV_QCOM_RNG tristate "Qualcomm Random Number Generator Driver" depends on ARCH_QCOM || COMPILE_TEST + depends on HW_RANDOM select CRYPTO_RNG help This driver provides support for the Random Number
Quoted 24 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The driver now calls into the hwrng subsystem and causes a link failure if that is not reachable:
x86_64-linux-ld: vmlinux.o: in function `qcom_rng_probe':
qcom-rng.c:(.text+0xfefc7e): undefined reference to `devm_hwrng_register'Add a
Kconfigdependency as we have for the purehw_randomdrivers. I see that there are some other crypto drivers that instead use 'selectHW_RANDOM', but those seem to be mistakes as that may lead to circular dependencies, and a simple driver should not force-enable an entire subsytem.Fixes f29cd5bb64c25 ("crypto: qcom-rng - Add hw_random interface support")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/crypto/Kconfig +0
-0
drivers/crypto/Kconfig config CRYPTO_DEV_QCE_SW_MAX_LEN · line 607
Quoted 7 lines
drivers/crypto/Kconfig +1
-0@@ -601,6 +601,7 @@ config CRYPTO_DEV_QCE_SW_MAX_LEN config CRYPTO_DEV_QCOM_RNG tristate "Qualcomm Random Number Generator Driver" depends on ARCH_QCOM || COMPILE_TEST + depends on HW_RANDOM select CRYPTO_RNG help This driver provides support for the Random Number