Skip to contentSkip to conversation

KVM: x86/mmu: Stop kicking vCPUs to sync the dirty log when PML is disabled

PATCH Applied David Matlack 2 participants 2 messages Oct 16, 2023 – Oct 18, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: x86/mmu: Stop kicking vCPUs to sync the dirty log when PML is disabled

Stop kicking vCPUs in kvm_arch_sync_dirty_log() when PML is disabled. Kicking vCPUs when PML is disabled serves no purpose and could negatively impact guest performance.

This restores KVM's behavior to prior to 5.12 commit a018eba53870 ("KVM:
x86: Move MMU's PML logic to common code"), which replaced a static_call_cond(kvm_x86_flush_log_dirty) with unconditional calls to kvm_vcpu_kick().

Fixes a018eba53870 ("KVM: x86: Move MMU's PML logic to common code")
---
 arch/x86/kvm/x86.c | 3 +++
 1 file changed, 3 insertions(+)
arch/x86/kvm/x86.c +3 -0
index 41cce5031126..af97de19b2ce 100644
@@ -6259,6 +6259,9 @@ void kvm_arch_sync_dirty_log(struct kvm *kvm, struct kvm_memory_slot *memslot)
 	struct kvm_vcpu *vcpu;
 	unsigned long i;
 
+	if (!kvm_x86_ops.cpu_dirty_log_size)
+		return;
+
 	kvm_for_each_vcpu(i, vcpu, kvm)
 		kvm_vcpu_kick(vcpu);
 }

base-commit: ba8c993c3748931a307648616f68892bcb6afe28

Signature · 1 line
2.42.0.655.g421f12c284-goog
maintainer Applied
#1 lore raw
Quoted 10 lines · David Matlack

Stop kicking vCPUs in kvm_arch_sync_dirty_log() when PML is disabled. Kicking vCPUs when PML is disabled serves no purpose and could negatively impact guest performance.

This restores KVM's behavior to prior to 5.12 commit a018eba53870 ("KVM:
x86: Move MMU's PML logic to common code"), which replaced a static_call_cond(kvm_x86_flush_log_dirty) with unconditional calls to kvm_vcpu_kick().

[...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86/mmu: Stop kicking vCPUs to sync the dirty log when PML is disabled

      https://github.com/kvm-x86/linux/commit/3d30bfcbdc26

--
https://github.com/kvm-x86/linux/tree/next