Skip to contentSkip to conversation

staging: rtl8192u: remove entry from Makefile

PATCH In review Greg Kroah-Hartman 3 participants 5 messages Oct 17, 2023 Staging

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 staging: rtl8192u: remove entry from Makefile

In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the driver was removed, along with the Kconfig entry, but the Makefile line in drivers/staging/Makefile was not updated, so things like 'make clean' fail to work properly as they will decend into all subdirectories to try to clean things up.

Resolve this by removing the entry in the main staging Makefile.

Cc Philipp Hortmann <[email protected]>
Cc Arnd Bergmann <[email protected]>
Fixes 697455ce4110 ("staging: rtl8192u: Remove broken driver")
---
 drivers/staging/Makefile | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/Makefile +0 -1
index ffa70dda481d..0f6379436443 100644
@@ -4,7 +4,6 @@
 obj-y				+= media/
 obj-$(CONFIG_PRISM2_USB)	+= wlan-ng/
 obj-$(CONFIG_FB_OLPC_DCON)	+= olpc_dcon/
-obj-$(CONFIG_RTL8192U)		+= rtl8192u/
 obj-$(CONFIG_RTL8192E)		+= rtl8192e/
 obj-$(CONFIG_RTL8723BS)		+= rtl8723bs/
 obj-$(CONFIG_R8712U)		+= rtl8712/
Signature · 1 line
2.42.0
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Greg Kroah-Hartman

In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the driver was removed, along with the Kconfig entry, but the Makefile line in drivers/staging/Makefile was not updated, so things like 'make clean' fail to work properly as they will decend into all subdirectories to try to clean things up.

Quoted 7 lines

Resolve this by removing the entry in the main staging Makefile.

Cc Philipp Hortmann <[email protected]>
Cc Arnd Bergmann <[email protected]>
Fixes 697455ce4110 ("staging: rtl8192u: Remove broken driver")

Thx Greg, that fixed things for my case. In case anyone cares:

Ciao, Thorsten

author maintainer
#2 lore raw
Quoted 9 lines · Thorsten Leemhuis
Quoted 8 lines · Greg Kroah-Hartman

In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the driver was removed, along with the Kconfig entry, but the Makefile line in drivers/staging/Makefile was not updated, so things like 'make clean' fail to work properly as they will decend into all subdirectories to try to clean things up.

Resolve this by removing the entry in the main staging Makefile.

Quoted 7 lines
Quoted 5 lines
Cc Philipp Hortmann <[email protected]>
Cc Arnd Bergmann <[email protected]>
Fixes 697455ce4110 ("staging: rtl8192u: Remove broken driver")

Thx Greg, that fixed things for my case. In case anyone cares:

I care, thanks!

#3 lore raw
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Thorsten Leemhuis
Quoted 13 lines · Greg Kroah-Hartman

In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the driver was removed, along with the Kconfig entry, but the Makefile line in drivers/staging/Makefile was not updated, so things like 'make clean' fail to work properly as they will decend into all subdirectories to try to clean things up.

Resolve this by removing the entry in the main staging Makefile.

Cc Philipp Hortmann <[email protected]>
Cc Arnd Bergmann <[email protected]>
Fixes 697455ce4110 ("staging: rtl8192u: Remove broken driver")
Quoted 3 lines
Quoted 1 line

Thx Greg, that fixed things for my case. In case anyone cares:

I care, thanks!

Sorry for messing up. I did a compile test of the entire kernel but I was not aware that I also need to test 'make clean'

Bye Philipp

author maintainer
#4 lore raw
Quoted 17 lines · Philipp Hortmann
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Thorsten Leemhuis
Quoted 13 lines · Greg Kroah-Hartman

In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the driver was removed, along with the Kconfig entry, but the Makefile line in drivers/staging/Makefile was not updated, so things like 'make clean' fail to work properly as they will decend into all subdirectories to try to clean things up.

Resolve this by removing the entry in the main staging Makefile.

Cc Philipp Hortmann <[email protected]>
Cc Arnd Bergmann <[email protected]>
Fixes 697455ce4110 ("staging: rtl8192u: Remove broken driver")
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Thx Greg, that fixed things for my case. In case anyone cares:

I care, thanks!

Sorry for messing up. I did a compile test of the entire kernel but I was not aware that I also need to test 'make clean'

Not a problem, I didn't either, and neither did the 0-day bot.

greg k-h