fpga: disable KUnit test suites when module support is enabled
PATCH 1/1 fpga: disable KUnit test suites when module support is enabled
The fpga core currently assumes that all manager, bridge, and region devices have a parent device associated with a driver that can be used to take the module's refcount. This behavior causes the fpga test suites to crash with a null-ptr-deref since parent fake devices do not have a driver. This patch disables all fpga KUnit test suites when loadable module support is enabled until the fpga core is fixed. Test suites can still be run using the KUnit default UML kernel.
--- drivers/fpga/tests/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/tests/Kconfig +2 -2
@@ -1,6 +1,6 @@ config FPGA_KUNIT_TESTS - tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS - depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y + bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS + depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n default KUNIT_ALL_TESTS help This builds unit tests for the FPGA subsystem
Signature · 1 line
2.41.0
Quoted 9 lines · Marco Pagani
The fpga core currently assumes that all manager, bridge, and region devices have a parent device associated with a driver that can be used to take the module's refcount. This behavior causes the fpga test suites to crash with a null-ptr-deref since parent fake devices do not have a driver. This patch disables all fpga KUnit test suites when loadable module support is enabled until the fpga core is fixed. Test suites can still be run using the KUnit default UML kernel.
Signed-off-by Marco Pagani <[email protected]>
LGTM, I've tested on my machine.
Hi Greg:
Could you help review and pull it in for 6.6-final if it's OK.
https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/
Thanks,
Yilun
Quoted 20 lines
--- drivers/fpga/tests/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/fpga/tests/Kconfig +2
-2@@ -1,6 +1,6 @@ config FPGA_KUNIT_TESTS - tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS - depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y + bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS + depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n default KUNIT_ALL_TESTS help This builds unit tests for the FPGA subsystemSignature · 1 line
2.41.0
Quoted 13 lines · Xu Yilun
Quoted 9 lines · Marco Pagani
The fpga core currently assumes that all manager, bridge, and region devices have a parent device associated with a driver that can be used to take the module's refcount. This behavior causes the fpga test suites to crash with a null-ptr-deref since parent fake devices do not have a driver. This patch disables all fpga KUnit test suites when loadable module support is enabled until the fpga core is fixed. Test suites can still be run using the KUnit default UML kernel.
Signed-off-by Marco Pagani <[email protected]>LGTM, I've tested on my machine.
Quoted 7 lines
Acked-by Xu Yilun <[email protected]>Hi Greg:
Could you help review and pull it in for 6.6-final if it's OK.
https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/
Needs a "Fixes:" tag please, you can provide it here in this email thread and b4 will pick it up automatically for me.
thanks,
greg k-h
Quoted 16 lines · Greg KH
Quoted 15 lines · Xu Yilun
Quoted 9 lines · Marco Pagani
The fpga core currently assumes that all manager, bridge, and region devices have a parent device associated with a driver that can be used to take the module's refcount. This behavior causes the fpga test suites to crash with a null-ptr-deref since parent fake devices do not have a driver. This patch disables all fpga KUnit test suites when loadable module support is enabled until the fpga core is fixed. Test suites can still be run using the KUnit default UML kernel.
Signed-off-by Marco Pagani <[email protected]>LGTM, I've tested on my machine.
Acked-by Xu Yilun <[email protected]>
Quoted 8 lines
Quoted 5 lines
Hi Greg:
Could you help review and pull it in for 6.6-final if it's OK.
https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/
Needs a "Fixes:" tag please, you can provide it here in this email thread and b4 will pick it up automatically for me.
Thanks,
Yilun
Quoted 4 lines
thanks,
greg k-h