Skip to contentSkip to conversation

staging: greybus: Alignment should match open parenthesis

PATCH In review Nandha Kumar Singaram 3 participants 4 messages Oct 19, 2023 – Oct 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: Alignment should match open parenthesis

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

---
 drivers/staging/greybus/camera.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +7 -7
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
 		struct gb_camera_configure_streams_response *resp,
 		unsigned int nstreams)
 {
@@ -378,8 +377,8 @@ struct ap_csi_config_request {
 #define GB_CAMERA_CSI_CLK_FREQ_MARGIN		150000000U
 
 static int gb_camera_setup_data_connection(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp,
-		struct gb_camera_csi_params *csi_params)
+					   struct gb_camera_configure_streams_response *resp,
+					   struct gb_camera_csi_params *csi_params)
 {
 	struct ap_csi_config_request csi_cfg;
 	struct gb_connection *conn;
@@ -783,8 +782,9 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len)
 }
 
 static int gb_camera_op_configure_streams(void *priv, unsigned int *nstreams,
-		unsigned int *flags, struct gb_camera_stream *streams,
-		struct gb_camera_csi_params *csi_params)
+					  unsigned int *flags,
+					  struct gb_camera_stream *streams,
+					  struct gb_camera_csi_params *csi_params)
 {
 	struct gb_camera *gcam = priv;
 	struct gb_camera_stream_config *gb_streams;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

Sometimes checkpatch.pl warns about things that are not really that important. One class of this type of issue is white space errors.

Yes, consistency is good, but the kernel simply doesn't have universally consistent conventions, and I doubt it ever will. There might be times where a source file consistently follows a white space convention that differs from what checkpatch wants. Suggesting a wholesale change to that file to "fix" that typically wouldn't be welcome.

Unfortunately without some experience it's hard to know which checkpatch warnings can be safely ignored. I would place white space warnings at a lower priority for fixing than some others. For example, this is also a pretty trivial warning:
CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid
precedence issues
And it is most likely not a problem in this case, but fixing this type of warning is probably more constructive than just adjusting white space.

I have no objection to your patch, and it's a fine way to get some experience with the patch process, but I don't think this particular change is necessary.

-Alex

Quoted 51 lines
---
  drivers/staging/greybus/camera.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +7 -7
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
  }
 
  static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
  {
  	unsigned int max_pkt_size = 0;
  	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
   * Validate the stream configuration response verifying padding is correctly
   * set and the returned number of streams is supported
   */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
  		struct gb_camera_configure_streams_response *resp,
  		unsigned int nstreams)
  {
@@ -378,8 +377,8 @@ struct ap_csi_config_request {
  #define GB_CAMERA_CSI_CLK_FREQ_MARGIN		150000000U
 
  static int gb_camera_setup_data_connection(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp,
-		struct gb_camera_csi_params *csi_params)
+					   struct gb_camera_configure_streams_response *resp,
+					   struct gb_camera_csi_params *csi_params)
  {
  	struct ap_csi_config_request csi_cfg;
  	struct gb_connection *conn;
@@ -783,8 +782,9 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len)
  }
 
  static int gb_camera_op_configure_streams(void *priv, unsigned int *nstreams,
-		unsigned int *flags, struct gb_camera_stream *streams,
-		struct gb_camera_csi_params *csi_params)
+					  unsigned int *flags,
+					  struct gb_camera_stream *streams,
+					  struct gb_camera_csi_params *csi_params)
  {
  	struct gb_camera *gcam = priv;
  	struct gb_camera_stream_config *gb_streams;
#3 lore raw
In reply to Nandha Kumar Singaram
Quoted 22 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

---
 drivers/staging/greybus/camera.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +1 -1
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 270

Quoted 6 lines
drivers/staging/greybus/camera.c +1 -2
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,

Why change this line?

It's fine, but then:

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 272

Quoted 2 lines
drivers/staging/greybus/camera.c +0 -0
 		struct gb_camera_configure_streams_response *resp,
 		unsigned int nstreams)

These lines are not fixed up?

thanks,

greg k-h

#2 lore raw
In reply to Alex Elder
Quoted 73 lines · Alex Elder
Quoted 2 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

Sometimes checkpatch.pl warns about things that are not really that important. One class of this type of issue is white space errors.

Yes, consistency is good, but the kernel simply doesn't have universally consistent conventions, and I doubt it ever will. There might be times where a source file consistently follows a white space convention that differs from what checkpatch wants. Suggesting a wholesale change to that file to "fix" that typically wouldn't be welcome.

Unfortunately without some experience it's hard to know
which checkpatch warnings can be safely ignored. I would
place white space warnings at a lower priority for fixing
than some others. For example, this is also a pretty
trivial warning:
CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid precedence
issues
And it is most likely not a problem in this case, but fixing this type of warning is probably more constructive than
just adjusting white space.

I have no objection to your patch, and it's a fine way to get some experience with the patch process, but I don't think this particular change is necessary.

-Alex

Quoted 40 lines
---
  drivers/staging/greybus/camera.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +4 -5
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
  }
  static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
  {
  	unsigned int max_pkt_size = 0;
  	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
   * Validate the stream configuration response verifying padding is correctly
   * set and the returned number of streams is supported
   */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
  		struct gb_camera_configure_streams_response *resp,
  		unsigned int nstreams)
  {
@@ -378,8 +377,8 @@ struct ap_csi_config_request {
  #define GB_CAMERA_CSI_CLK_FREQ_MARGIN		150000000U
  static int gb_camera_setup_data_connection(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp,
-		struct gb_camera_csi_params *csi_params)
+					   struct gb_camera_configure_streams_response *resp,
+					   struct gb_camera_csi_params *csi_params)
  {
  	struct ap_csi_config_request csi_cfg;
  	struct gb_connection *conn;
@@ -783,8 +782,9 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len)
  }
  static int gb_camera_op_configure_streams(void *priv, unsigned int *nstreams,
Quoted 9 lines

drivers/staging/greybus/camera.c static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) · line 790

Quoted 8 lines
drivers/staging/greybus/camera.c +3 -2
-		unsigned int *flags, struct gb_camera_stream *streams,
-		struct gb_camera_csi_params *csi_params)
+					  unsigned int *flags,
+					  struct gb_camera_stream *streams,
+					  struct gb_camera_csi_params *csi_params)
  {
  	struct gb_camera *gcam = priv;
  	struct gb_camera_stream_config *gb_streams;

Thanks Alex for the review and feedback.

Regards,
Nandha Kumar