Skip to contentSkip to conversation

staging: greybus: Alignment should match open parenthesis

PATCH Nandha Kumar Singaram 2 participants 4 messages Oct 21, 2023 Staging

lore
Share & tools
lore
#0 lore raw

[email protected], [email protected], [email protected], [email protected]
Bcc:
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis Reply-To:
In-Reply-To: <2023102131-slacker-lily-28ff@gregkh>

Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

---
 drivers/staging/greybus/camera.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +0 -0
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
Quoted 16 lines

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 270

Quoted 13 lines
drivers/staging/greybus/camera.c +2 -3
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,

Why change this line?

did these Code change to fix CHECK: Lines should not end with a '(' reported by checkpatch.pl

Quoted 10 lines

It's fine, but then:

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 272

Quoted 2 lines
drivers/staging/greybus/camera.c +0 -0
 		struct gb_camera_configure_streams_response *resp,
 		unsigned int nstreams)

These lines are not fixed up?

thanks,

greg k-h

Fixing these lines results in another checkpatch check(CHECK: line length of 113 exceeds 100 columns) so didn't added any change

Thanks,
Nandha Kumar

#1 lore raw
Quoted 40 lines · Nandha Kumar Singaram

[email protected], [email protected], [email protected], [email protected]
Bcc:
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis Reply-To:
In-Reply-To: <2023102131-slacker-lily-28ff@gregkh>

Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

---
 drivers/staging/greybus/camera.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +0 -0
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
Quoted 16 lines

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 270

Quoted 13 lines
drivers/staging/greybus/camera.c +2 -3
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,

Why change this line?

Quoted 2 lines

did these Code change to fix CHECK: Lines should not end with a '(' reported by checkpatch.pl

That's great, but you didn't say that in your changelog text, so it looks wrong here :(

thanks,

greg k-h

#2 lore raw
Quoted 44 lines · Greg Kroah-Hartman
Quoted 40 lines · Nandha Kumar Singaram

[email protected], [email protected], [email protected], [email protected]
Bcc:
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis Reply-To:
In-Reply-To: <2023102131-slacker-lily-28ff@gregkh>

Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

---
 drivers/staging/greybus/camera.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +0 -0
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
Quoted 16 lines

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 270

Quoted 13 lines
drivers/staging/greybus/camera.c +2 -3
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,

Why change this line?

Quoted 2 lines

did these Code change to fix CHECK: Lines should not end with a '(' reported by checkpatch.pl

Quoted 6 lines

That's great, but you didn't say that in your changelog text, so it looks wrong here :(

thanks,

greg k-h

Sorry for missing that, will add and send the updated patch.

Regards,
Nandha Kumar

#3 lore raw
Quoted 45 lines · Nandha Kumar Singaram
Quoted 44 lines · Greg Kroah-Hartman
Quoted 42 lines · Nandha Kumar Singaram

[email protected], [email protected], [email protected], [email protected]
Bcc:
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis Reply-To:
In-Reply-To: <2023102131-slacker-lily-28ff@gregkh>

Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

---
 drivers/staging/greybus/camera.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/greybus/camera.c +0 -0
index cdbb42cd413b..405c8e78aa72 100644
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
Quoted 16 lines

drivers/staging/greybus/camera.c static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, · line 270

Quoted 13 lines
drivers/staging/greybus/camera.c +2 -3
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,

Why change this line?

did these Code change to fix CHECK: Lines should not end with a '(' reported by checkpatch.pl

Quoted 8 lines
Quoted 6 lines

That's great, but you didn't say that in your changelog text, so it looks wrong here :(

thanks,

greg k-h

Sorry for missing that, will add and send the updated patcha

Careful, remember to only do one logical thing per patch.

good luck!

greg k-h