drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

PATCH Applied Arnd Bergmann 4 participants 6 messages Oct 23, 2023 – Jan 12, 2024

Subsystems (3)

DRM drivers DRM misc DRM panel drivers

lore

Share & tools

lore

Arnd Bergmann

author

2023-10-23 11:56 UTC #0 lore raw

PATCH 1/1 drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

From: Arnd Bergmann <[email protected]>

As with several other panel drivers, this fails to link without the DP helper library:

ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'

Select the same symbols that the others already use.

Fixes 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")

Signed-off-by Arnd Bergmann <[email protected]>

---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

drivers/gpu/drm/panel/Kconfig +2 -0

index 99e14dc212ecb..a4ac4b47777fe 100644
@@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
 	help
 	  Say Y here if you want to enable support for Raydium RM692E5-based
 	  display panels, such as the one found in the Fairphone 5 smartphone.

Signature · 1 line

2.39.2

Neil Armstrong

maintainer Reviewed-by on v1 1/1

2023-10-23 13:02 UTC #1 lore raw

Quoted 21 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>
As with several other panel drivers, this fails to link without the DP helper library:
ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
Select the same symbols that the others already use.
Fixes 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
Signed-off-by Arnd Bergmann <[email protected]>
---
  drivers/gpu/drm/panel/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/Kconfig +0 -0
index 99e14dc212ecb..a4ac4b47777fe 100644

drivers/gpu/drm/panel/Kconfig config DRM_PANEL_RAYDIUM_RM692E5 · line 537

Quoted 8 lines

drivers/gpu/drm/panel/Kconfig +2 -0

@@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
  	depends on OF
  	depends on DRM_MIPI_DSI
  	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
  	help
  	  Say Y here if you want to enable support for Raydium RM692E5-based
  	  display panels, such as the one found in the Fairphone 5 smartphone.

Reviewed-by Neil Armstrong <[email protected]>

Neil Armstrong

maintainer

2023-10-23 13:25 UTC #2 lore raw

In reply to Arnd Bergmann

Hi,

Quoted 21 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>
As with several other panel drivers, this fails to link without the DP helper library:
ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
Select the same symbols that the others already use.
Fixes 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
Signed-off-by Arnd Bergmann <[email protected]>
---
  drivers/gpu/drm/panel/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/Kconfig +0 -0
index 99e14dc212ecb..a4ac4b47777fe 100644

drivers/gpu/drm/panel/Kconfig config DRM_PANEL_RAYDIUM_RM692E5 · line 537

Quoted 8 lines

drivers/gpu/drm/panel/Kconfig +2 -0

@@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
  	depends on OF
  	depends on DRM_MIPI_DSI
  	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
  	help
  	  Say Y here if you want to enable support for Raydium RM692E5-based
  	  display panels, such as the one found in the Fairphone 5 smartphone.

Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.

Neil

Konrad Dybcio

2023-10-23 13:35 UTC #3 lore raw

Quoted 19 lines · Neil Armstrong

Hi,
Quoted 16 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
As with several other panel drivers, this fails to link without the DP helper library:
ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
Select the same symbols that the others already use.
Fixes 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
Signed-off-by Arnd Bergmann <[email protected]>
---
drivers/gpu/drm/panel/Kconfig | 2 ++
  1 file changed, 2 insertions(+)

Quoted 15 lines

Quoted 5 lines
drivers/gpu/drm/panel/Kconfig +0 -0
index 99e14dc212ecb..a4ac4b47777fe 100644
@@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
Quoted 8 lines
      depends on OF
      depends on DRM_MIPI_DSI
      depends on BACKLIGHT_CLASS_DEVICE
+    select DRM_DISPLAY_DP_HELPER
+    select DRM_DISPLAY_HELPER
      help
        Say Y here if you want to enable support for Raydium RM692E5-based display panels, such as the one found in the Fairphone 5 smartphone.
Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.

Thanks Arnd, Neil.

Sounds like this helper should be extracted from DP specific code in the future though, no?

Konrad

Luca Weiss

2023-12-28 07:47 UTC #4 lore raw

In reply to Neil Armstrong

Quoted 19 lines · Neil Armstrong

Hi,
Quoted 16 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
As with several other panel drivers, this fails to link without the DP helper library:
ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
Select the same symbols that the others already use.
Fixes 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
Signed-off-by Arnd Bergmann <[email protected]>
---
  drivers/gpu/drm/panel/Kconfig | 2 ++
  1 file changed, 2 insertions(+)

Quoted 15 lines

drivers/gpu/drm/panel/Kconfig config DRM_PANEL_RAYDIUM_RM692E5 · line 537
Quoted 13 lines
drivers/gpu/drm/panel/Kconfig +2 -0
index 99e14dc212ecb..a4ac4b47777fe 100644
@@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
  	depends on OF
  	depends on DRM_MIPI_DSI
  	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
  	help
  	  Say Y here if you want to enable support for Raydium RM692E5-based
  	  display panels, such as the one found in the Fairphone 5 smartphone.
Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.

Hi Neil,

I think this patch is still pending, I don't see it in linux-next.

It was also reported by a buildbot today
https://lore.kernel.org/lkml/[email protected]/

Regards
Luca

Quoted 2 lines

Neil

Neil Armstrong

maintainer Applied

2024-01-12 09:29 UTC #5 lore raw

In reply to Arnd Bergmann

Hi,

Quoted 9 lines · Arnd Bergmann

As with several other panel drivers, this fails to link without the DP helper library:
ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
Select the same symbols that the others already use.
[...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=589830b13ac21bddf99b9bc5a4ec17813d0869ef

Signature · 1 line

Neil