fix for "lib/stackdepot: allow users to evict stack traces"
Subsystems (2)
PATCH 1/1 fix for "lib/stackdepot: allow users to evict stack traces"
From: Andrey Konovalov <[email protected]>
Commit "lib/stackdepot: allow users to evict stack traces" adds another user for depot_fetch_stack, which holds a write lock. Thus, we need to update the lockdep annotation.
--- lib/stackdepot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/stackdepot.c +1 -1
@@ -388,7 +388,7 @@ static struct stack_record *depot_fetch_stack(depot_stack_handle_t handle)size_t offset = parts.offset <<DEPOT_STACK_ALIGN ;struct stack_record *stack; -lockdep_assert_held_read (&pool_rwlock); +lockdep_assert_held (&pool_rwlock);if (parts.pool_index > pools_num) { WARN(1, "pool index %d out of bounds (%d) for stack id %08x\n",
Signature · 1 line
2.25.1
Andrew Morton
maintainerQuoted 6 lines · On Fri, 27 Oct 2023 00:33:40 +0200 [email protected] wrote:
From: Andrey Konovalov <[email protected]>
Commit "lib/stackdepot: allow users to evict stack traces" adds another user for
depot_fetch_stack, which holds a write lock. Thus, we need to update the lockdep annotation.
We're at -rc7, which is rather late to be merging material such as this patchset. Please resend it all after -rc1 and include this fixup, thanks.
Quoted 5 lines · Andrew Morton
Quoted 2 lines · On Fri, 27 Oct 2023 00:33:40 +0200 [email protected] wrote:
From: Andrey Konovalov <[email protected]>
Quoted 8 lines
Quoted 4 lines
Commit "lib/stackdepot: allow users to evict stack traces" adds another user for
depot_fetch_stack, which holds a write lock. Thus, we need to update the lockdep annotation.We're at -rc7, which is rather late to be merging material such as this patchset. Please resend it all after -rc1 and include this fixup, thanks.
Ack.
I might send a few more additions to the series for review before then, but then resend everything together after rc1.