ti: fix possible memory leak in _ti_omap4_clkctrl_setup()
Subsystems (2)
PATCH v2 1/1 ti: fix possible memory leak in _ti_omap4_clkctrl_setup()
kstrndup() and kstrdup_and_replace() in clkctrl_get_name() can perform dynamic memory allocation. So clkctrl_name() needs to be freed when provider->clkdm_name is NULL.
Fixes bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
Signed-off-by Hangyu Hua <[email protected]>
---
v2: fix commit info.
drivers/clk/ti/clkctrl.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/ti/clkctrl.c +1 -0
@@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node) provider->clkdm_name =kasprintf (GFP_KERNEL ,"%s_clkdm" , clkctrl_name);if (!provider->clkdm_name) { +kfree (clkctrl_name);kfree (provider);return ; }
Signature · 1 line
2.34.1
Quoted 2 lines · Hangyu Hua
kstrndup()andkstrdup_and_replace()inclkctrl_get_name()can perform dynamic memory allocation. Soclkctrl_name()needs to be freed when
s/clkctrl_name()/clkctrl_name
Quoted 23 lines
provider->clkdm_nameis NULL.Fixes bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")Signed-off-by Hangyu Hua <[email protected]>---
v2: fix commit info.
drivers/clk/ti/clkctrl.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/ti/clkctrl.c +1
-0@@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node) provider->clkdm_name =kasprintf (GFP_KERNEL ,"%s_clkdm" , clkctrl_name);if (!provider->clkdm_name) { +kfree (clkctrl_name);kfree (provider);return ; }