soc: apple: mailbox: Add explicit include of platform_device.h
PATCH RESEND 1/1 soc: apple: mailbox: Add explicit include of platform_device.h
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other and pull in various other headers. In preparation to fix this, adjust the includes for what is actually needed.
platform_device.h is implicitly included by of_platform.h, but that's going to be removed.
---
Note this was added in the merge window and missed the last round.
Arnd, Can you apply this directly.
--- drivers/soc/apple/mailbox.c | 1 + 1 file changed, 1 insertion(+)
drivers/soc/apple/mailbox.c +1 -0
@@ -26,6 +26,7 @@#include <linux/module.h> #include <linux/of.h> #include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spinlock.h> #include <linux/types.h>
Signature · 1 line
2.42.0
Quoted 33 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other and pull in various other headers. In preparation to fix this, adjust the includes for what is actually needed.
platform_device.his implicitly included byof_platform.h, but that's going to be removed.Signed-off-by Rob Herring <[email protected]>---
Note this was added in the merge window and missed the last round.Arnd, Can you apply this directly.
--- drivers/soc/apple/mailbox.c | 1 + 1 file changed, 1 insertion(+)drivers/soc/apple/mailbox.c +1
-1@@ -26,6 +26,7 @@#include <linux/module.h> #include <linux/of.h> #include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spinlock.h> #include <linux/types.h> --
Quoted 3 lines
2.42.0
Pretty obvious patch.
Signature · 1 line
真実はいつも一つ！/ Always, there's only one truth!
Quoted 6 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other and pull in various other headers. In preparation to fix this, adjust the includes for what is actually needed.
Quoted 8 lines
platform_device.his implicitly included byof_platform.h, but that's going to be removed.Signed-off-by Rob Herring <[email protected]>---
Note this was added in the merge window and missed the last round.Arnd, Can you apply this directly.
Just noticed this but I'm confused. I never sent Arnd the pull for this, so it's not upstream nor on the way yet. I've applied it to asahi-soc/mailbox though. Thanks for reminding me, I'll send the pull now :)
- Hector