pinctrl: tangier: Move default strength assignment to a switch-case
PATCH 1/1 pinctrl: tangier: Move default strength assignment to a switch-case
iWhen ->pin_config_set() is called from the GPIO library (assumed GpioIo() ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.
--- drivers/pinctrl/intel/pinctrl-tangier.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/pinctrl/intel/pinctrl-tangier.c +2 -8
@@ -368,14 +368,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,break ;case PIN_CONFIG_BIAS_PULL_UP : -/* Set default strength value in case none is given */ -if (arg ==1 ) - arg =20000 ; -switch (arg) {case 50000 : term =BUFCFG_PUPD_VAL_50K ;break ; +case 1 :/* Set default strength value in case none is given */ case 20000 : term =BUFCFG_PUPD_VAL_20K ;break ;
@@ -394,14 +391,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,break ;case PIN_CONFIG_BIAS_PULL_DOWN : -/* Set default strength value in case none is given */ -if (arg ==1 ) - arg =20000 ; -switch (arg) {case 50000 : term =BUFCFG_PUPD_VAL_50K ;break ; +case 1 :/* Set default strength value in case none is given */ case 20000 : term =BUFCFG_PUPD_VAL_20K ;break ;
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 5 lines · Andy Shevchenko
iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo()ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.
Looks good.
iWhen -> When
Raag
Quoted 8 lines · Raag Jadav
Quoted 5 lines · Andy Shevchenko
iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo()ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.Looks good.
Thank you for review. Can you give your Rb tag then?
Quoted 1 line
iWhen -> When
I'll fix it locally.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Raag Jadav
Reviewed-byQuoted 11 lines · Andy Shevchenko
Quoted 8 lines · Raag Jadav
Quoted 5 lines · Andy Shevchenko
iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo()ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.Looks good.
Thank you for review. Can you give your Rb tag then?
Since I'm not a maintainer, I'm not sure if I qualify. But anyway, here you go.
Mika Westerberg
maintainerQuoted 18 lines · Andy Shevchenko
iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo()ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/pinctrl/intel/pinctrl-tangier.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)drivers/pinctrl/intel/pinctrl-tangier.c +0
-0@@ -368,14 +368,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,break ;
drivers/pinctrl/intel/pinctrl-tangier.c static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, · line 375
Quoted 10 lines
drivers/pinctrl/intel/pinctrl-tangier.c +1
-4case PIN_CONFIG_BIAS_PULL_UP : -/* Set default strength value in case none is given */ -if (arg ==1 ) - arg =20000 ; -switch (arg) {case 50000 : term =BUFCFG_PUPD_VAL_50K ;break ; +case 1 :/* Set default strength value in case none is given */
The comment is good but I think would it make sense to have constant for this instead?
Quoted 21 lines
drivers/pinctrl/intel/pinctrl-tangier.c +1
-4case 20000 : term =BUFCFG_PUPD_VAL_20K ;break ;@@ -394,14 +391,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,break ;case PIN_CONFIG_BIAS_PULL_DOWN : -/* Set default strength value in case none is given */ -if (arg ==1 ) - arg =20000 ; -switch (arg) {case 50000 : term =BUFCFG_PUPD_VAL_50K ;break ; +case 1 :/* Set default strength value in case none is given */ case 20000 : term =BUFCFG_PUPD_VAL_20K ;break ;Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 1 line · Mika Westerberg
On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote:
...
Quoted 4 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ case 1: /* Set default strength value in case none is given */The comment is good but I think would it make sense to have constant for this instead?
If so, it makes sense to get it via entire GPIO library, and not locally for Intel stuff. That said, I prefer to do that separately. Do you agree?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Mika Westerberg
maintainerQuoted 5 lines · Andy Shevchenko
Quoted 1 line · Mika Westerberg
On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote:
...
Quoted 7 lines
Quoted 4 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ case 1: /* Set default strength value in case none is given */The comment is good but I think would it make sense to have constant for this instead?
If so, it makes sense to get it via entire GPIO library, and not locally for Intel stuff. That said, I prefer to do that separately. Do you agree?
Yes, agree.
Quoted 5 lines · Andy Shevchenko
iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo()ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.
(...)
Quoted 1 line
+ case 1: /* Set default strength value in case none is given */
So where does this 1 come from in the end? That's the piece I am missing in this explanation. Somewhere, someone decided to pass 1 to indicate "pull to default resistance".
Is it coming from ACPI firmware?
Then a comment such as "the firmware author chose to pass 1 for default pull" should be added to the constant definition in the code.
Other than that it looks good!
Yours,
Linus Walleij
Quoted 2 lines · Linus Walleij
On Mon, Oct 30, 2023 at 4:54 PM Andy Shevchenko
<[email protected]> wrote:
(...)
Quoted 7 lines
Quoted 1 line
+ case 1: /* Set default strength value in case none is given */
So where does this 1 come from in the end? That's the piece I am missing in this explanation. Somewhere, someone decided to pass 1 to indicate "pull to default resistance".
Is it coming from ACPI firmware?
No, it's pure Linux kernel decision.gpio_set_bias() is who made that. That's why it needs to be chosen on global level.
We may even document somewhere that arguments let's say up to 10 do not make any sense in real life, as even for 1.2 v it will give 120 mA current on a single pin. Yet, theoretically that's possible for discrete industrial GPIOs, so we can choose "very big number" if such case appears in the future. I don't want to change 1 to something else right now as it may break things.
Quoted 2 lines
for default pull" should be added to the constant definition in the code.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Linus Walleij
On Mon, Oct 30, 2023 at 4:54 PM Andy Shevchenko
<[email protected]> wrote:
(...)
Quoted 8 lines
Quoted 7 lines
Quoted 1 line
+ case 1: /* Set default strength value in case none is given */
So where does this 1 come from in the end? That's the piece I am missing in this explanation. Somewhere, someone decided to pass 1 to indicate "pull to default resistance".
Is it coming from ACPI firmware?
Quoted 8 lines
No, it's pure Linux kernel decision.
gpio_set_bias()is who made that. That's why it needs to be chosen on global level.We may even document somewhere that arguments let's say up to 10 do not make any sense in real life, as even for 1.2 v it will give 120 mA current on a single pin. Yet, theoretically that's possible for discrete industrial GPIOs, so we can choose "very big number" if such case appears in the future. I don't want
Just realized that "very big number" is limited to 16-bit value right now and 65 kOhm is quite reasonable value for the pull bias (yet we can use exact 0xffff for the "special" case).
Quoted 4 lines
to change 1 to something else right now as it may break things.
Quoted 2 lines
for default pull" should be added to the constant definition in the code.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Linus Walleij
Reviewed-byQuoted 11 lines · Andy Shevchenko
Quoted 5 lines · Linus Walleij
So where does this 1 come from in the end? That's the piece I am missing in this explanation. Somewhere, someone decided to pass 1 to indicate "pull to default resistance".
Is it coming from ACPI firmware?
No, it's pure Linux kernel decision.
gpio_set_bias()is who made that. That's why it needs to be chosen on global level.
Aha I see, that makes sense.
Yours,
Linus Walleij
Quoted 8 lines · Linus Walleij
Quoted 6 lines · Andy Shevchenko
Quoted 4 lines · Linus Walleij
So where does this 1 come from in the end? That's the piece I am missing in this explanation. Somewhere, someone decided to pass 1 to indicate "pull to default resistance".
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Is it coming from ACPI firmware?
No, it's pure Linux kernel decision.
gpio_set_bias()is who made that. That's why it needs to be chosen on global level.Aha I see, that makes sense.
Reviewed-by Linus Walleij <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko