wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

PATCH In review Tom Waldron 3 participants 7 messages Nov 1, 2023

Subsystems (2)

Arm MediaTek MediaTek MT76 wireless LAN driver

lore

Share & tools

lore

Tom Waldron

author

2023-11-01 09:55 UTC #0 lore raw

PATCH 1/1 wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).

Signed-off-by Tom Waldron <[email protected]>

---
 drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/net/wireless/mediatek/mt76/mt7921/pci.c +2 -0

index 3dda84a93..ba805cb02 100644
@@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
 		.driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
 		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
+	{ PCI_DEVICE(0x0b48, 0x7922),
+		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
 	{ },
 };

Signature · 1 line

2.41.0

Kalle Valo

2023-11-01 13:19 UTC #1 lore raw

Quoted 4 lines · Tom Waldron

Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).
Signed-off-by Tom Waldron <[email protected]>

Should I take this to wireless? Felix&Lorenzo, ack?

Signature · 3 lines

https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Tom Waldron

author

2023-11-01 14:03 UTC #2 lore raw

Yes, it seems I missed some of the output from get_maintainer.pl and only caught the last few lines. I've CC's some of the others including Felix & Lorenzo.

Thank you for spotting this, Kalle.

Quoted 14 lines · Kalle Valo

Quoted 4 lines · Tom Waldron
Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).
Signed-off-by Tom Waldron <[email protected]>
Should I take this to wireless? Felix&Lorenzo, ack?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Lorenzo Bianconi

maintainer

2023-11-01 15:00 UTC #3 lore raw

In reply to Tom Waldron

Quoted 13 lines

Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).
Signed-off-by Tom Waldron <[email protected]>
---
 drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -0
index 3dda84a93..ba805cb02 100644

drivers/net/wireless/mediatek/mt76/mt7921/pci.c static const struct pci_device_id mt7921_pci_device_table[] = { · line 25

Quoted 5 lines

drivers/net/wireless/mediatek/mt76/mt7921/pci.c +2 -0

@@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
 		.driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
 		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
+	{ PCI_DEVICE(0x0b48, 0x7922),
+		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },

is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?

Regards,
Lorenzo

Quoted 6 lines

drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -0
 	{ },
 };
 
Signature · 1 line
2.41.0

PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though a website named pcilookup.com suggests it belongs to TechnoTrend AG. I think it's more likely to be part of AMD RZ600 series - rebranded mediatek devices. Not sure how any of this might be verified.

Quoted 31 lines · Lorenzo Bianconi

Quoted 14 lines
Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).
Signed-off-by Tom Waldron <[email protected]>
---
 drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -0
index 3dda84a93..ba805cb02 100644
drivers/net/wireless/mediatek/mt76/mt7921/pci.c static const struct pci_device_id mt7921_pci_device_table[] = { · line 25
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +2 -0
@@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
              .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
      { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
              .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
+     { PCI_DEVICE(0x0b48, 0x7922),
+             .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
Regards,
Lorenzo
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -1
      { },
 };
 
--
2.41.0

Lorenzo Bianconi

maintainer Acked-by

2023-11-01 15:35 UTC #5 lore raw

Quoted 4 lines

PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though a website named pcilookup.com suggests it belongs to TechnoTrend AG. I think it's more likely to be part of AMD RZ600 series - rebranded mediatek devices. Not sure how any of this might be verified.

I have just found it here: include/linux/pci_ids.h but I am not sure if it is related. Anyway:

Acked-by Lorenzo Bianconi <[email protected]>

Quoted 33 lines · Lorenzo Bianconi

Quoted 31 lines
Quoted 14 lines
Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).
Signed-off-by Tom Waldron <[email protected]>
---
 drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -0
index 3dda84a93..ba805cb02 100644
drivers/net/wireless/mediatek/mt76/mt7921/pci.c static const struct pci_device_id mt7921_pci_device_table[] = { · line 25
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +2 -0
@@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
              .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
      { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
              .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
+     { PCI_DEVICE(0x0b48, 0x7922),
+             .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
Regards,
Lorenzo
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -1
      { },
 };
 
--
2.41.0

Tom Waldron

author

2023-11-01 15:49 UTC #6 lore raw

Just realised that I had based my changes on the wrong repo(linux stable). Also that this change has already been made in the wireless-next repo. It seems the ITTIM vendor was used in this case.

Please ignore this submission and please accept my apologies for taking up your time.

Regards

Tom

Quoted 44 lines · Lorenzo Bianconi

Quoted 5 lines
PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though a website named pcilookup.com suggests it belongs to TechnoTrend AG. I think it's more likely to be part of AMD RZ600 series - rebranded mediatek devices. Not sure how any of this might be verified.
I have just found it here: include/linux/pci_ids.h but I am not sure if it is related. Anyway:
Acked-by Lorenzo Bianconi <[email protected]>
Quoted 33 lines · Lorenzo Bianconi
Quoted 31 lines
Quoted 14 lines
Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip. Change tested on Redmi Book Pro 15 2023 (Fedora 38).
Signed-off-by Tom Waldron <[email protected]>
---
 drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -0
index 3dda84a93..ba805cb02 100644
drivers/net/wireless/mediatek/mt76/mt7921/pci.c static const struct pci_device_id mt7921_pci_device_table[] = { · line 25
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +2 -0
@@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
              .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
      { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
              .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
+     { PCI_DEVICE(0x0b48, 0x7922),
+             .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
Regards,
Lorenzo
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt7921/pci.c +0 -1
      { },
 };
 
--
2.41.0