Skip to contentSkip to conversation

Patch "tty: 8250: Add support for Intashield IX cards" has been added to the 5.10-stable tree

DISCUSSION Cameron Williams 2 participants 2 messages Nov 6, 2023 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 2023110636-sandfish-thickness-bdc1@gregkh

#1 lore raw
Quoted 8 lines · On Mon, Nov 06, 2023 at 01:18:36PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

tty: 8250: Add support for Intashield IX cards

to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
tty-8250-add-support-for-intashield-ix-cards.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

I don't think this patch should be in 5.10-stable. It's using the pbn_oxsemi_x_15625000 configuration which isn't available in the version of the driver (it's actually pbn_oxsemi_x_3906250 in this version). The rest of the patches to be merged look OK for this branch (as they are all using the generic configuration rather than Oxsemi).

Quoted 1 line

Thanks,
Cameron

Quoted 58 lines

From 62d2ec2ded278c7512d91ca7bf8eb9bac46baf90 Mon Sep 17 00:00:00 2001
From: Cameron Williams <[email protected]>
Date: Fri, 20 Oct 2023 17:03:16 +0100
Subject: tty: 8250: Add support for Intashield IX cards

From: Cameron Williams <[email protected]>

commit 62d2ec2ded278c7512d91ca7bf8eb9bac46baf90 upstream.

Add support for the IX-100, IX-200 and IX-400 serial cards.

---
 drivers/tty/serial/8250/8250_pci.c |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
drivers/tty/serial/8250/8250_pci.c +21 -0
@@ -5150,6 +5150,27 @@ static const struct pci_device_id serial
 	{	PCI_VENDOR_ID_INTASHIELD, PCI_DEVICE_ID_INTASHIELD_IS400,
 		PCI_ANY_ID, PCI_ANY_ID, 0, 0,    /* 135a.0dc0 */
 		pbn_b2_4_115200 },
+	/*
+	 * IntaShield IX-100
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4027,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_1_15625000 },
+	/*
+	 * IntaShield IX-200
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4028,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_2_15625000 },
+	/*
+	 * IntaShield IX-400
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4029,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_4_15625000 },
 	/* Brainboxes Devices */
 	/*
 	* Brainboxes UC-101

Patches currently in stable-queue which might be from [email protected] are

queue-5.10/tty-8250-add-support-for-additional-brainboxes-uc-cards.patch queue-5.10/tty-8250-add-support-for-intashield-ix-cards.patch queue-5.10/tty-8250-add-support-for-brainboxes-up-cards.patch queue-5.10/tty-8250-add-support-for-intashield-is-100.patch queue-5.10/tty-8250-remove-uc-257-and-uc-431.patch

maintainer
#2 lore raw
Quoted 13 lines · Cameron Williams
Quoted 12 lines · On Mon, Nov 06, 2023 at 01:18:36PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

tty: 8250: Add support for Intashield IX cards

to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
tty-8250-add-support-for-intashield-ix-cards.patch
and it can be found in the queue-5.10 subdirectory.

Quoted 8 lines
Quoted 3 lines

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

I don't think this patch should be in 5.10-stable. It's using the pbn_oxsemi_x_15625000 configuration which isn't available in the version of the driver (it's actually pbn_oxsemi_x_3906250 in this version). The rest of the patches to be merged look OK for this branch (as they are all using the generic configuration rather than Oxsemi).

Yes, it broke the build and I dropped it right after it, my scripts committed it before I could build-test it.

thanks for the quick response!

greg k-h