pinctrl: s32cc: Avoid possible string truncation
Subsystems (4)
PATCH 1/1 pinctrl: s32cc: Avoid possible string truncation
With "W=1" and "-Wformat-truncation" build options, the kernel test robot found a possible string truncation warning in pinctrl-s32cc.c, which uses an 8-byte char array to hold a memory region name "map%u". Since the maximum number of digits that a u32 value can present is 10, and the "map" string occupies 3 bytes with a termination '\0', which means the rest 4 bytes cannot fully present the integer "X" that exceeds 4 digits.
Here we check if the number >= 10000, which is the lowest value that contains more than 4 digits.
--- drivers/pinctrl/nxp/pinctrl-s32cc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/nxp/pinctrl-s32cc.c +2 -2
@@ -843,8 +843,8 @@ static int s32_pinctrl_probe_dt(struct platform_device *pdev,if (!np)return -ENODEV ; -if (mem_regions ==0 ) { -dev_err (&pdev->dev,"mem_regions is 0\n" ); +if (mem_regions ==0 || mem_regions >=10000 ) { +dev_err (&pdev->dev,"mem_regions is invalid: %u\n" , mem_regions);return -EINVAL ; }
Signature · 1 line
2.40.0
Quoted 7 lines · Chester Lin
With "W=1" and "-Wformat-truncation" build options, the kernel test robot found a possible string truncation warning in
pinctrl-s32cc.c, which uses an 8-byte char array to hold a memory region name "map%u". Since the maximum number of digits that a u32 value can present is 10, and the "map" string occupies 3 bytes with a termination '\0', which means the rest 4 bytes cannot fully present the integer "X" that exceeds 4 digits.
Quoted 6 lines
Here we check if the number >= 10000, which is the lowest value that contains more than 4 digits.
Reported-by kernel test robot <[email protected]>Signed-off-by Chester Lin <[email protected]>
Thanks for fixing this!
Patch applied for fixes.
Yours,
Linus Walleij